From 04886afd291178643638af0fc387942202a676b2 Mon Sep 17 00:00:00 2001 From: Jesse Plamondon-Willard Date: Fri, 16 Nov 2018 21:32:48 -0500 Subject: [PATCH] fix update-check errors sometimes being overwritten with a generic error message --- docs/release-notes.md | 3 ++- src/SMAPI.Web/Controllers/ModsApiController.cs | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/release-notes.md b/docs/release-notes.md index d3036135..5762c623 100644 --- a/docs/release-notes.md +++ b/docs/release-notes.md @@ -45,10 +45,11 @@ * mods can now load PNGs even if the game is currently drawing. * When comparing mod versions, SMAPI now considers `-unofficial` to be lower-precedence than any other value (e.g. `1.0-beta` is now considered newer than `1.0-unofficial` regardless of normal sorting). * Fixed content packs' `ReadJsonFile` allowing non-relative paths. - * Fixed content pack always failing to load if they declare a dependency on a SMAPI mod. + * Fixed content packs always failing to load if they declare a dependency on a SMAPI mod. * Fixed trace logs not showing path for invalid mods. * Fixed 'no update keys' warning not shown for mods with only invalid update keys. * Fixed `Context.IsPlayerFree` being true before the player finishes transitioning to a new location in multiplayer. + * Fixed update-check errors sometimes being overwritten with a generic error message. * Suppressed the game's 'added crickets' debug output. * Updated dependencies (Harmony 1.0.9.1 → 1.2.0.1, Mono.Cecil 0.10 → 0.10.1). * **Deprecations:** diff --git a/src/SMAPI.Web/Controllers/ModsApiController.cs b/src/SMAPI.Web/Controllers/ModsApiController.cs index 05568d5e..f0835592 100644 --- a/src/SMAPI.Web/Controllers/ModsApiController.cs +++ b/src/SMAPI.Web/Controllers/ModsApiController.cs @@ -252,7 +252,7 @@ namespace StardewModdingAPI.Web.Controllers return await this.Cache.GetOrCreateAsync($"{repository.VendorKey}:{parsed.ID}".ToLower(), async entry => { ModInfoModel result = await repository.GetModInfoAsync(parsed.ID); - if (result.Error != null) + if (result.Error == null) { if (result.Version == null) result.Error = $"The update key '{updateKey}' matches a mod with no version number.";