From 9dd702a16228a245247371866d8074ffc1539ba5 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sun, 26 Mar 2023 18:05:29 -0400
Subject: [PATCH 01/19] embed debug symbols for Linux/macOS compatibility

This fixes error stack traces not having line numbers on Linux/macOS.
---
 build/common.targets                        | 3 +++
 build/deploy-local-smapi.targets            | 4 ----
 build/unix/prepare-install-package.sh       | 5 ++---
 build/windows/prepare-install-package.ps1   | 5 ++---
 docs/release-notes.md                       | 4 ++++
 src/SMAPI.Installer/InteractiveInstaller.cs | 4 ++--
 6 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/build/common.targets b/build/common.targets
index 1ead1508..bb13a26a 100644
--- a/build/common.targets
+++ b/build/common.targets
@@ -14,6 +14,9 @@ repo. It imports the other MSBuild files as needed.
     <DefineConstants>$(DefineConstants);SMAPI_DEPRECATED</DefineConstants>
     <DebugSymbols>true</DebugSymbols>
 
+    <!--embed symbols for error stack trace line numbers on Linux/macOS: https://github.com/dotnet/runtime/issues/39987-->
+    <DebugType>embedded</DebugType>
+
     <!--enable nullable annotations, except in .NET Standard 2.0 where they aren't supported-->
     <Nullable Condition="'$(TargetFramework)' != 'netstandard2.0'">enable</Nullable>
     <NoWarn Condition="'$(TargetFramework)' == 'netstandard2.0'">$(NoWarn);CS8632</NoWarn>
diff --git a/build/deploy-local-smapi.targets b/build/deploy-local-smapi.targets
index 6ea5f0a2..e6c01800 100644
--- a/build/deploy-local-smapi.targets
+++ b/build/deploy-local-smapi.targets
@@ -18,7 +18,6 @@ This assumes `find-game-folder.targets` has already been imported and validated.
     <Copy SourceFiles="$(TargetDir)\$(TargetName).dll" DestinationFolder="$(GamePath)" />
     <Copy SourceFiles="$(TargetDir)\$(TargetName).exe" DestinationFolder="$(GamePath)" Condition="$(OS) == 'Windows_NT'" />
     <Copy SourceFiles="$(TargetDir)\$(TargetName)" DestinationFolder="$(GamePath)" Condition="$(OS) != 'Windows_NT'" />
-    <Copy SourceFiles="$(TargetDir)\$(TargetName).pdb" DestinationFolder="$(GamePath)" />
     <Copy SourceFiles="$(TargetDir)\$(TargetName).xml" DestinationFolder="$(GamePath)" />
     <Copy SourceFiles="$(TargetDir)\SMAPI.config.json" DestinationFiles="$(GamePath)\smapi-internal\config.json" />
     <Copy SourceFiles="$(TargetDir)\SMAPI.metadata.json" DestinationFiles="$(GamePath)\smapi-internal\metadata.json" />
@@ -62,7 +61,6 @@ This assumes `find-game-folder.targets` has already been imported and validated.
     </ItemGroup>
 
     <Copy SourceFiles="$(TargetDir)\$(TargetName).dll" DestinationFolder="$(GamePath)\Mods\$(AssemblyName)" />
-    <Copy SourceFiles="$(TargetDir)\$(TargetName).pdb" DestinationFolder="$(GamePath)\Mods\$(AssemblyName)" Condition="Exists('$(TargetDir)\$(TargetName).pdb')" />
     <Copy SourceFiles="$(TargetDir)\manifest.json" DestinationFolder="$(GamePath)\Mods\$(AssemblyName)" />
     <Copy SourceFiles="@(TranslationFiles)" DestinationFolder="$(GamePath)\Mods\$(AssemblyName)\i18n" />
   </Target>
@@ -70,12 +68,10 @@ This assumes `find-game-folder.targets` has already been imported and validated.
   <!-- toolkit -->
   <Target Name="CopyToolkit" Condition="'$(MSBuildProjectName)' == 'SMAPI.Toolkit'" AfterTargets="PostBuildEvent">
     <Copy SourceFiles="$(TargetDir)\$(TargetName).dll" DestinationFolder="$(GamePath)\smapi-internal" />
-    <Copy SourceFiles="$(TargetDir)\$(TargetName).pdb" DestinationFolder="$(GamePath)\smapi-internal" />
     <Copy SourceFiles="$(TargetDir)\$(TargetName).xml" DestinationFolder="$(GamePath)\smapi-internal" />
   </Target>
   <Target Name="CopyToolkitCoreInterfaces" Condition="'$(MSBuildProjectName)' == 'SMAPI.Toolkit.CoreInterfaces'" AfterTargets="PostBuildEvent">
     <Copy SourceFiles="$(TargetDir)\$(TargetName).dll" DestinationFolder="$(GamePath)\smapi-internal" />
-    <Copy SourceFiles="$(TargetDir)\$(TargetName).pdb" DestinationFolder="$(GamePath)\smapi-internal" />
     <Copy SourceFiles="$(TargetDir)\$(TargetName).xml" DestinationFolder="$(GamePath)\smapi-internal" />
   </Target>
 </Project>
diff --git a/build/unix/prepare-install-package.sh b/build/unix/prepare-install-package.sh
index 304579b9..3e33c277 100755
--- a/build/unix/prepare-install-package.sh
+++ b/build/unix/prepare-install-package.sh
@@ -122,7 +122,7 @@ for folder in ${folders[@]}; do
     fi
 
     # bundle root files
-    for name in "StardewModdingAPI" "StardewModdingAPI.dll" "StardewModdingAPI.pdb" "StardewModdingAPI.xml" "steam_appid.txt"; do
+    for name in "StardewModdingAPI" "StardewModdingAPI.dll" "StardewModdingAPI.xml" "steam_appid.txt"; do
         if [ $name == "StardewModdingAPI" ] && [ $folder == "windows" ]; then
             name="$name.exe"
         fi
@@ -134,7 +134,7 @@ for folder in ${folders[@]}; do
     cp -r "$smapiBin/i18n" "$bundlePath/smapi-internal"
 
     # bundle smapi-internal
-    for name in "0Harmony.dll" "0Harmony.xml" "Mono.Cecil.dll" "Mono.Cecil.Mdb.dll" "Mono.Cecil.Pdb.dll" "MonoMod.Common.dll" "Newtonsoft.Json.dll" "Pathoschild.Http.Client.dll" "Pintail.dll" "TMXTile.dll" "SMAPI.Toolkit.dll" "SMAPI.Toolkit.pdb" "SMAPI.Toolkit.xml" "SMAPI.Toolkit.CoreInterfaces.dll" "SMAPI.Toolkit.CoreInterfaces.pdb" "SMAPI.Toolkit.CoreInterfaces.xml" "System.Net.Http.Formatting.dll"; do
+    for name in "0Harmony.dll" "0Harmony.xml" "Mono.Cecil.dll" "Mono.Cecil.Mdb.dll" "Mono.Cecil.Pdb.dll" "MonoMod.Common.dll" "Newtonsoft.Json.dll" "Pathoschild.Http.Client.dll" "Pintail.dll" "TMXTile.dll" "SMAPI.Toolkit.dll" "SMAPI.Toolkit.xml" "SMAPI.Toolkit.CoreInterfaces.dll" "SMAPI.Toolkit.CoreInterfaces.xml" "System.Net.Http.Formatting.dll"; do
         cp "$smapiBin/$name" "$bundlePath/smapi-internal"
     done
 
@@ -164,7 +164,6 @@ for folder in ${folders[@]}; do
         mkdir "$targetPath" --parents
 
         cp "$fromPath/$modName.dll" "$targetPath"
-        cp "$fromPath/$modName.pdb" "$targetPath"
         cp "$fromPath/manifest.json" "$targetPath"
         if [ -d "$fromPath/i18n" ]; then
             cp -r "$fromPath/i18n" "$targetPath"
diff --git a/build/windows/prepare-install-package.ps1 b/build/windows/prepare-install-package.ps1
index 71de1154..434d2466 100644
--- a/build/windows/prepare-install-package.ps1
+++ b/build/windows/prepare-install-package.ps1
@@ -142,7 +142,7 @@ foreach ($folder in $folders) {
     }
 
     # bundle root files
-    foreach ($name in @("StardewModdingAPI", "StardewModdingAPI.dll", "StardewModdingAPI.pdb", "StardewModdingAPI.xml", "steam_appid.txt")) {
+    foreach ($name in @("StardewModdingAPI", "StardewModdingAPI.dll", "StardewModdingAPI.xml", "steam_appid.txt")) {
         if ($name -eq "StardewModdingAPI" -and $folder -eq "windows") {
             $name = "$name.exe"
         }
@@ -154,7 +154,7 @@ foreach ($folder in $folders) {
     cp -Recurse "$smapiBin/i18n" "$bundlePath/smapi-internal"
 
     # bundle smapi-internal
-    foreach ($name in @("0Harmony.dll", "0Harmony.xml", "Mono.Cecil.dll", "Mono.Cecil.Mdb.dll", "Mono.Cecil.Pdb.dll", "MonoMod.Common.dll", "Newtonsoft.Json.dll", "Pathoschild.Http.Client.dll", "Pintail.dll", "TMXTile.dll", "SMAPI.Toolkit.dll", "SMAPI.Toolkit.pdb", "SMAPI.Toolkit.xml", "SMAPI.Toolkit.CoreInterfaces.dll", "SMAPI.Toolkit.CoreInterfaces.pdb", "SMAPI.Toolkit.CoreInterfaces.xml", "System.Net.Http.Formatting.dll")) {
+    foreach ($name in @("0Harmony.dll", "0Harmony.xml", "Mono.Cecil.dll", "Mono.Cecil.Mdb.dll", "Mono.Cecil.Pdb.dll", "MonoMod.Common.dll", "Newtonsoft.Json.dll", "Pathoschild.Http.Client.dll", "Pintail.dll", "TMXTile.dll", "SMAPI.Toolkit.dll", "SMAPI.Toolkit.xml", "SMAPI.Toolkit.CoreInterfaces.dll", "SMAPI.Toolkit.CoreInterfaces.xml", "System.Net.Http.Formatting.dll")) {
         cp "$smapiBin/$name" "$bundlePath/smapi-internal"
     }
 
@@ -189,7 +189,6 @@ foreach ($folder in $folders) {
         mkdir "$targetPath" > $null
 
         cp "$fromPath/$modName.dll" "$targetPath"
-        cp "$fromPath/$modName.pdb" "$targetPath"
         cp "$fromPath/manifest.json" "$targetPath"
         if (Test-Path "$fromPath/i18n" -PathType Container) {
             cp -Recurse "$fromPath/i18n" "$targetPath"
diff --git a/docs/release-notes.md b/docs/release-notes.md
index e99218bd..d091d153 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -7,6 +7,10 @@
   _If needed, you can update to SMAPI 3.16.0 first and then install the latest version._
 -->
 
+## Upcoming release
+* For players:
+  * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
+
 ## 3.18.3
 Released 09 April 2023 for Stardew Valley 1.5.6 or later.
 
diff --git a/src/SMAPI.Installer/InteractiveInstaller.cs b/src/SMAPI.Installer/InteractiveInstaller.cs
index d00a5df4..32a4e6e5 100644
--- a/src/SMAPI.Installer/InteractiveInstaller.cs
+++ b/src/SMAPI.Installer/InteractiveInstaller.cs
@@ -47,8 +47,8 @@ namespace StardewModdingApi.Installer
             yield return GetInstallPath("StardewModdingAPI.dll");
             yield return GetInstallPath("StardewModdingAPI.exe");
             yield return GetInstallPath("StardewModdingAPI.exe.config");
-            yield return GetInstallPath("StardewModdingAPI.exe.mdb");  // Linux/macOS only
-            yield return GetInstallPath("StardewModdingAPI.pdb");      // Windows only
+            yield return GetInstallPath("StardewModdingAPI.exe.mdb");  // before 3.18.4 (Linux/macOS only)
+            yield return GetInstallPath("StardewModdingAPI.pdb");      // before 3.18.4 (Windows only)
             yield return GetInstallPath("StardewModdingAPI.runtimeconfig.json");
             yield return GetInstallPath("StardewModdingAPI.xml");
             yield return GetInstallPath("smapi-internal");

From 445370b75b71ae27a974a6bc746db707653aee8c Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 11:50:05 -0400
Subject: [PATCH 02/19] embed debug symbols for Linux/macOS compatibility in
 mod build package

---
 docs/technical/mod-package.md                | 3 +++
 src/SMAPI.ModBuildConfig/build/smapi.targets | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/docs/technical/mod-package.md b/docs/technical/mod-package.md
index ab8a2c95..023ef070 100644
--- a/docs/technical/mod-package.md
+++ b/docs/technical/mod-package.md
@@ -416,6 +416,9 @@ The NuGet package is generated automatically in `StardewModdingAPI.ModBuildConfi
 when you compile it.
 
 ## Release notes
+## Upcoming release
+* Replaced `.pdb` files with embedded symbols by default. This fixes logged SMAPI errors not having line numbers on Linux/macOS.
+
 ### 4.1.0
 Released 08 January 2023.
 
diff --git a/src/SMAPI.ModBuildConfig/build/smapi.targets b/src/SMAPI.ModBuildConfig/build/smapi.targets
index b4fd312e..41b5bc86 100644
--- a/src/SMAPI.ModBuildConfig/build/smapi.targets
+++ b/src/SMAPI.ModBuildConfig/build/smapi.targets
@@ -8,8 +8,9 @@
   ** Set build options
   **********************************************-->
   <PropertyGroup>
-    <!-- enable line numbers in stack traces -->
+    <!-- enable line numbers in stack traces (needs to embedded for Linux/macOS: https://github.com/dotnet/runtime/issues/39987) -->
     <DebugSymbols>true</DebugSymbols>
+    <DebugType>embedded</DebugType>
 
     <!-- don't create the 'refs' folder (which isn't useful for mods) -->
     <ProduceReferenceAssembly>false</ProduceReferenceAssembly>

From 342b91ff804c682717c25c6908d1033b799445b6 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 22 Apr 2023 11:55:39 -0400
Subject: [PATCH 03/19] add multiplayer player type to window titles

---
 docs/release-notes.md        |  1 +
 src/SMAPI/Framework/SCore.cs | 17 ++++++++++-------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index d091d153..49545d50 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -9,6 +9,7 @@
 
 ## Upcoming release
 * For players:
+  * In multiplayer, the game/SMAPI window titles now show whether you're the main player or a farmhand.
   * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
 
 ## 3.18.3
diff --git a/src/SMAPI/Framework/SCore.cs b/src/SMAPI/Framework/SCore.cs
index abba7f3b..d16f7248 100644
--- a/src/SMAPI/Framework/SCore.cs
+++ b/src/SMAPI/Framework/SCore.cs
@@ -852,6 +852,9 @@ namespace StardewModdingAPI.Framework
 
                         this.Monitor.Log(context);
 
+                        // add context to window titles
+                        this.UpdateWindowTitles();
+
                         // raise events
                         this.OnLoadStageChanged(LoadStage.Ready);
                         events.SaveLoaded.RaiseEmpty();
@@ -1203,6 +1206,7 @@ namespace StardewModdingAPI.Framework
 
                 case LoadStage.None:
                     this.JustReturnedToTitle = true;
+                    this.UpdateWindowTitles();
                     break;
 
                 case LoadStage.Loaded:
@@ -1450,15 +1454,14 @@ namespace StardewModdingAPI.Framework
             string consoleTitle = $"SMAPI {Constants.ApiVersion} - running Stardew Valley {Constants.GameVersion}";
             string gameTitle = $"Stardew Valley {Constants.GameVersion} - running SMAPI {Constants.ApiVersion}";
 
+            string suffix = "";
             if (this.ModRegistry.AreAllModsLoaded)
-            {
-                int modsLoaded = this.ModRegistry.GetAll().Count();
-                consoleTitle += $" with {modsLoaded} mods";
-                gameTitle += $" with {modsLoaded} mods";
-            }
+                suffix += $" with {this.ModRegistry.GetAll().Count()} mods";
+            if (Context.IsMultiplayer)
+                suffix += $" [{(Context.IsMainPlayer ? "main player" : "farmhand")}]";
 
-            this.Game.Window.Title = gameTitle;
-            this.LogManager.SetConsoleTitle(consoleTitle);
+            this.Game.Window.Title = gameTitle + suffix;
+            this.LogManager.SetConsoleTitle(consoleTitle + suffix);
         }
 
         /// <summary>Log a warning if software known to cause issues is installed.</summary>

From 76a0497684c9773d1e27f7c88e17bdaaeb9bde39 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sun, 30 Apr 2023 13:41:43 -0400
Subject: [PATCH 04/19] fix ModFolder not being JSON-serializable

---
 docs/release-notes.md                         |  3 ++
 .../Framework/ModScanning/ModFolder.cs        | 35 +++++++++++++++++--
 2 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index 49545d50..0b0a37d8 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -12,6 +12,9 @@
   * In multiplayer, the game/SMAPI window titles now show whether you're the main player or a farmhand.
   * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
 
+* For SMAPI toolkit users:
+  * Fixed `ModFolder` not being JSON-serializable.
+
 ## 3.18.3
 Released 09 April 2023 for Stardew Valley 1.5.6 or later.
 
diff --git a/src/SMAPI.Toolkit/Framework/ModScanning/ModFolder.cs b/src/SMAPI.Toolkit/Framework/ModScanning/ModFolder.cs
index da2a3c85..106e3622 100644
--- a/src/SMAPI.Toolkit/Framework/ModScanning/ModFolder.cs
+++ b/src/SMAPI.Toolkit/Framework/ModScanning/ModFolder.cs
@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
+using Newtonsoft.Json;
 using StardewModdingAPI.Toolkit.Serialization.Models;
 using StardewModdingAPI.Toolkit.Utilities;
 
@@ -9,14 +10,25 @@ namespace StardewModdingAPI.Toolkit.Framework.ModScanning
     /// <summary>The info about a mod read from its folder.</summary>
     public class ModFolder
     {
+        /*********
+        ** Fields
+        *********/
+        /// <summary>The backing field for <see cref="Directory"/>.</summary>
+        private DirectoryInfo? DirectoryImpl;
+
+
         /*********
         ** Accessors
         *********/
         /// <summary>A suggested display name for the mod folder.</summary>
         public string DisplayName { get; }
 
+        /// <summary>The folder path containing the mod's manifest.json.</summary>
+        public string DirectoryPath { get; }
+
         /// <summary>The folder containing the mod's manifest.json.</summary>
-        public DirectoryInfo Directory { get; }
+        [JsonIgnore]
+        public DirectoryInfo Directory => this.DirectoryImpl ??= new DirectoryInfo(this.DirectoryPath);
 
         /// <summary>The mod type.</summary>
         public ModType Type { get; }
@@ -52,7 +64,8 @@ namespace StardewModdingAPI.Toolkit.Framework.ModScanning
         public ModFolder(DirectoryInfo root, DirectoryInfo directory, ModType type, Manifest? manifest, ModParseError manifestParseError, string? manifestParseErrorText)
         {
             // save info
-            this.Directory = directory;
+            this.DirectoryImpl = directory;
+            this.DirectoryPath = directory.FullName;
             this.Type = type;
             this.Manifest = manifest;
             this.ManifestParseError = manifestParseError;
@@ -64,6 +77,24 @@ namespace StardewModdingAPI.Toolkit.Framework.ModScanning
                 : PathUtilities.GetRelativePath(root.FullName, directory.FullName);
         }
 
+        /// <summary>Construct an instance.</summary>
+        /// <param name="displayName">A suggested display name for the mod folder.</param>
+        /// <param name="directoryPath">The folder path containing the mod's manifest.json.</param>
+        /// <param name="type">The mod type.</param>
+        /// <param name="manifest">The mod manifest.</param>
+        /// <param name="manifestParseError">The error which occurred parsing the manifest, if any.</param>
+        /// <param name="manifestParseErrorText">A human-readable message for the <paramref name="manifestParseError"/>, if any.</param>
+        [JsonConstructor]
+        public ModFolder(string displayName, string directoryPath, ModType type, Manifest? manifest, ModParseError manifestParseError, string? manifestParseErrorText)
+        {
+            this.DisplayName = displayName;
+            this.DirectoryPath = directoryPath;
+            this.Type = type;
+            this.Manifest = manifest;
+            this.ManifestParseError = manifestParseError;
+            this.ManifestParseErrorText = manifestParseErrorText;
+        }
+
         /// <summary>Get the update keys for a mod.</summary>
         /// <param name="manifest">The mod manifest.</param>
         public IEnumerable<string> GetUpdateKeys(Manifest manifest)

From 5d2afc0aa4eabe6afc7ee24f4ee4e044aea24d6e Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sun, 30 Apr 2023 13:43:23 -0400
Subject: [PATCH 05/19] fix error deserializing null semantic version

---
 docs/release-notes.md                                        | 5 ++++-
 .../Serialization/Converters/SemanticVersionConverter.cs     | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index 0b0a37d8..c957484a 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -12,6 +12,9 @@
   * In multiplayer, the game/SMAPI window titles now show whether you're the main player or a farmhand.
   * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
 
+* For mod authors:
+  * Fixed error loading a mod if it sets `"MinimumApiVersion": null` explicitly.
+
 * For SMAPI toolkit users:
   * Fixed `ModFolder` not being JSON-serializable.
 
@@ -23,7 +26,7 @@ Released 09 April 2023 for Stardew Valley 1.5.6 or later.
   * Fixed installer error for some Linux players due to a non-portable shebang (thanks to freyacoded!).
   * Fixed error using load order overrides when there are broken mods installed (thanks to atravita!).
   * Removed `LargeAddressAware` flag on SMAPI (no longer needed since it's 64-bit now).
-  * Improved translations. Thganks to stylemate (updated Korean)!
+  * Improved translations. Thanks to stylemate (updated Korean)!
 
 * For mod authors:
   * Added `IsActiveForScreen()` method to `PerScreen<T>`.
diff --git a/src/SMAPI.Toolkit/Serialization/Converters/SemanticVersionConverter.cs b/src/SMAPI.Toolkit/Serialization/Converters/SemanticVersionConverter.cs
index 913d54e0..650815b5 100644
--- a/src/SMAPI.Toolkit/Serialization/Converters/SemanticVersionConverter.cs
+++ b/src/SMAPI.Toolkit/Serialization/Converters/SemanticVersionConverter.cs
@@ -44,6 +44,9 @@ namespace StardewModdingAPI.Toolkit.Serialization.Converters
             string path = reader.Path;
             switch (reader.TokenType)
             {
+                case JsonToken.Null:
+                    return null;
+
                 case JsonToken.StartObject:
                     return this.ReadObject(JObject.Load(reader));
 

From 3c46bdaeb3e9b484f9f93754e74fe4b30c2d7eaf Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sun, 14 May 2023 16:10:59 -0400
Subject: [PATCH 06/19] fix install error if a game folder has an invalid
 symlink

---
 docs/release-notes.md                                   | 1 +
 src/SMAPI.Toolkit/Framework/GameScanning/GameScanner.cs | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index c957484a..34090bf8 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -11,6 +11,7 @@
 * For players:
   * In multiplayer, the game/SMAPI window titles now show whether you're the main player or a farmhand.
   * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
+  * Fixed install error if a game folder has an invalid symlink.
 
 * For mod authors:
   * Fixed error loading a mod if it sets `"MinimumApiVersion": null` explicitly.
diff --git a/src/SMAPI.Toolkit/Framework/GameScanning/GameScanner.cs b/src/SMAPI.Toolkit/Framework/GameScanning/GameScanner.cs
index 88142805..45f3e203 100644
--- a/src/SMAPI.Toolkit/Framework/GameScanning/GameScanner.cs
+++ b/src/SMAPI.Toolkit/Framework/GameScanning/GameScanner.cs
@@ -73,7 +73,7 @@ namespace StardewModdingAPI.Toolkit.Framework.GameScanning
                 return GameFolderType.NoGameFound;
 
             // apparently valid
-            if (dir.EnumerateFiles("Stardew Valley.dll").Any())
+            if (File.Exists(Path.Combine(dir.FullName, "Stardew Valley.dll")))
                 return GameFolderType.Valid;
 
             // doesn't contain any version of Stardew Valley

From 2f1f274b2dbc41e41098bed384b0014cfa62e756 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Fri, 16 Jun 2023 22:38:08 -0400
Subject: [PATCH 07/19] fix Context.HasRemotePlayers being true when there's no
 farmhands

---
 docs/release-notes.md | 1 +
 src/SMAPI/Context.cs  | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index 34090bf8..832feb92 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -14,6 +14,7 @@
   * Fixed install error if a game folder has an invalid symlink.
 
 * For mod authors:
+  * Fixed `Context.HasRemotePlayers` being true when there's no farmhands connected.
   * Fixed error loading a mod if it sets `"MinimumApiVersion": null` explicitly.
 
 * For SMAPI toolkit users:
diff --git a/src/SMAPI/Context.cs b/src/SMAPI/Context.cs
index 978459e8..3e3ee784 100644
--- a/src/SMAPI/Context.cs
+++ b/src/SMAPI/Context.cs
@@ -88,7 +88,7 @@ namespace StardewModdingAPI
         public static bool IsSplitScreen => LocalMultiplayer.IsLocalMultiplayer();
 
         /// <summary>Whether there are players connected over the network.</summary>
-        public static bool HasRemotePlayers => Context.IsMultiplayer && !Game1.hasLocalClientsOnly;
+        public static bool HasRemotePlayers => Context.IsMultiplayer && !Game1.hasLocalClientsOnly && Game1.getOnlineFarmers().Count > 1;
 
         /// <summary>Whether the current player is the main player. This is always true in single-player, and true when hosting in multiplayer.</summary>
         public static bool IsMainPlayer => Game1.IsMasterGame && Context.ScreenId == 0 && TitleMenu.subMenu is not FarmhandMenu;
@@ -97,8 +97,7 @@ namespace StardewModdingAPI
         /*********
         ** Public methods
         *********/
-        /// <summary>Get whether a screen ID is still active.</summary>
-        /// <param name="id">The screen ID.</param>
+        /// <summary>Get whether a screen ID is still active.</summary> <param name="id">The screen ID.</param>
         public static bool HasScreenId(int id)
         {
             return Context.ActiveScreenIds.Contains(id);

From 251d83472cd15982b150a1c58ec7b960d6a35e60 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 12:01:49 -0400
Subject: [PATCH 08/19] update dependencies

---
 docs/release-notes.md                              |  1 +
 .../SMAPI.ModBuildConfig.Analyzer.Tests.csproj     |  4 ++--
 .../SMAPI.ModBuildConfig.csproj                    |  2 +-
 src/SMAPI.Tests/SMAPI.Tests.csproj                 |  8 ++++----
 src/SMAPI.Toolkit/SMAPI.Toolkit.csproj             |  4 ++--
 src/SMAPI.Web/SMAPI.Web.csproj                     | 14 +++++++-------
 src/SMAPI/SMAPI.csproj                             |  4 ++--
 7 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index 832feb92..449e3791 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -16,6 +16,7 @@
 * For mod authors:
   * Fixed `Context.HasRemotePlayers` being true when there's no farmhands connected.
   * Fixed error loading a mod if it sets `"MinimumApiVersion": null` explicitly.
+  * Updated Newtonsoft.Json 13.0.2 &rarr; 13.0.3 (see [changes](https://github.com/JamesNK/Newtonsoft.Json/releases/tag/13.0.3)) and Pintail 2.2.2 &rarr; 2.3.0 (see [changes](https://github.com/Nanoray-pl/Pintail/blob/master/docs/release-notes.md#230)).
 
 * For SMAPI toolkit users:
   * Fixed `ModFolder` not being JSON-serializable.
diff --git a/src/SMAPI.ModBuildConfig.Analyzer.Tests/SMAPI.ModBuildConfig.Analyzer.Tests.csproj b/src/SMAPI.ModBuildConfig.Analyzer.Tests/SMAPI.ModBuildConfig.Analyzer.Tests.csproj
index 1719d39b..454f2ecf 100644
--- a/src/SMAPI.ModBuildConfig.Analyzer.Tests/SMAPI.ModBuildConfig.Analyzer.Tests.csproj
+++ b/src/SMAPI.ModBuildConfig.Analyzer.Tests/SMAPI.ModBuildConfig.Analyzer.Tests.csproj
@@ -6,9 +6,9 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.10.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.2" />
     <PackageReference Include="NUnit" Version="3.13.3" />
-    <PackageReference Include="NUnit3TestAdapter" Version="4.3.1" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
+    <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj b/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj
index badabfc7..6d9a0d9e 100644
--- a/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj
+++ b/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj
@@ -24,7 +24,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Build.Utilities.Core" Version="16.10" />
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
 
     <!--
       This is imported through Microsoft.Build.Utilities.Core. When installed by a mod, NuGet
diff --git a/src/SMAPI.Tests/SMAPI.Tests.csproj b/src/SMAPI.Tests/SMAPI.Tests.csproj
index 0b1fb638..4c320696 100644
--- a/src/SMAPI.Tests/SMAPI.Tests.csproj
+++ b/src/SMAPI.Tests/SMAPI.Tests.csproj
@@ -14,12 +14,12 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="FluentAssertions" Version="6.8.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
+    <PackageReference Include="FluentAssertions" Version="6.11.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.2" />
     <PackageReference Include="Moq" Version="4.18.4" />
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="NUnit" Version="3.13.3" />
-    <PackageReference Include="NUnit3TestAdapter" Version="4.3.1" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
+    <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/src/SMAPI.Toolkit/SMAPI.Toolkit.csproj b/src/SMAPI.Toolkit/SMAPI.Toolkit.csproj
index 2a9a8294..dce5fe1b 100644
--- a/src/SMAPI.Toolkit/SMAPI.Toolkit.csproj
+++ b/src/SMAPI.Toolkit/SMAPI.Toolkit.csproj
@@ -9,8 +9,8 @@
   <Import Project="..\..\build\common.targets" />
 
   <ItemGroup>
-    <PackageReference Include="HtmlAgilityPack" Version="1.11.46" />
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
+    <PackageReference Include="HtmlAgilityPack" Version="1.11.48" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="Pathoschild.Http.FluentClient" Version="4.3.0" />
     <PackageReference Include="System.Management" Version="5.0.0" Condition="'$(OS)' == 'Windows_NT'" />
     <PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" Condition="'$(OS)' == 'Windows_NT'" />
diff --git a/src/SMAPI.Web/SMAPI.Web.csproj b/src/SMAPI.Web/SMAPI.Web.csproj
index 1e568572..1cb2704d 100644
--- a/src/SMAPI.Web/SMAPI.Web.csproj
+++ b/src/SMAPI.Web/SMAPI.Web.csproj
@@ -15,15 +15,15 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Azure.Storage.Blobs" Version="12.14.1" />
-    <PackageReference Include="Hangfire.AspNetCore" Version="1.7.32" />
-    <PackageReference Include="Hangfire.MemoryStorage" Version="1.7.0" />
-    <PackageReference Include="HtmlAgilityPack" Version="1.11.46" />
+    <PackageReference Include="Azure.Storage.Blobs" Version="12.16.0" />
+    <PackageReference Include="Hangfire.AspNetCore" Version="1.8.2" />
+    <PackageReference Include="Hangfire.MemoryStorage" Version="1.8.0" />
+    <PackageReference Include="HtmlAgilityPack" Version="1.11.48" />
     <PackageReference Include="Humanizer.Core" Version="2.14.1" />
     <PackageReference Include="JetBrains.Annotations" Version="2022.3.1" />
-    <PackageReference Include="Markdig" Version="0.30.4" />
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="7.0.1" />
-    <PackageReference Include="Newtonsoft.Json.Schema" Version="3.0.14" />
+    <PackageReference Include="Markdig" Version="0.31.0" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="7.0.8" />
+    <PackageReference Include="Newtonsoft.Json.Schema" Version="3.0.15" />
     <PackageReference Include="Pathoschild.FluentNexus" Version="1.0.5" />
     <PackageReference Include="Pathoschild.Http.FluentClient" Version="4.3.0" />
   </ItemGroup>
diff --git a/src/SMAPI/SMAPI.csproj b/src/SMAPI/SMAPI.csproj
index 530b75aa..1be286b4 100644
--- a/src/SMAPI/SMAPI.csproj
+++ b/src/SMAPI/SMAPI.csproj
@@ -23,9 +23,9 @@
   <ItemGroup>
     <PackageReference Include="Mono.Cecil" Version="0.11.4" />
     <PackageReference Include="MonoMod.Common" Version="22.3.5.1" />
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
+    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageReference Include="Pathoschild.Http.FluentClient" Version="4.3.0" />
-    <PackageReference Include="Pintail" Version="2.2.2" />
+    <PackageReference Include="Pintail" Version="2.3.0" />
     <PackageReference Include="Platonymous.TMXTile" Version="1.5.9" />
     <PackageReference Include="System.Reflection.Emit" Version="4.7.0" />
 

From 15ab3ccd0908895cb5d8ded1cc2be4a8d895ef21 Mon Sep 17 00:00:00 2001
From: Christopher Hiller <boneskull@boneskull.com>
Date: Sat, 6 May 2023 21:43:03 -0700
Subject: [PATCH 09/19] fix invalid field in manifest.json

VS is complaining that this line should be an array.
---
 src/SMAPI.Web/wwwroot/schemas/manifest.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/SMAPI.Web/wwwroot/schemas/manifest.json b/src/SMAPI.Web/wwwroot/schemas/manifest.json
index 7457b993..727e5cbd 100644
--- a/src/SMAPI.Web/wwwroot/schemas/manifest.json
+++ b/src/SMAPI.Web/wwwroot/schemas/manifest.json
@@ -43,7 +43,7 @@
             "description": "The DLL filename SMAPI should load for this mod. Mutually exclusive with ContentPackFor.",
             "type": "string",
             "pattern": "^[a-zA-Z0-9_.-]+\\.dll$",
-            "examples": "LookupAnything.dll",
+            "examples": ["LookupAnything.dll"],
             "@errorMessages": {
                 "pattern": "Invalid value; must be a filename ending with .dll."
             }

From 654ad4b4b223e510b630a5d39769685b030b7da0 Mon Sep 17 00:00:00 2001
From: Marie Ramlow <me@nycode.dev>
Date: Fri, 26 May 2023 17:26:14 +0200
Subject: [PATCH 10/19] Add headless flag for unattended execution

---
 build/windows/finalize-install-package.sh   |  2 ++
 docs/technical/smapi.md                     |  3 +-
 src/SMAPI.Installer/InteractiveInstaller.cs | 36 +++++++++++++++------
 src/SMAPI.Installer/Program.cs              |  4 ++-
 4 files changed, 34 insertions(+), 11 deletions(-)

diff --git a/build/windows/finalize-install-package.sh b/build/windows/finalize-install-package.sh
index 117e33e5..8428cf41 100755
--- a/build/windows/finalize-install-package.sh
+++ b/build/windows/finalize-install-package.sh
@@ -1,5 +1,7 @@
 #!/usr/bin/env bash
 
+set -ex
+
 ##########
 ## Read config
 ##########
diff --git a/docs/technical/smapi.md b/docs/technical/smapi.md
index d115aefa..3dd66c78 100644
--- a/docs/technical/smapi.md
+++ b/docs/technical/smapi.md
@@ -32,6 +32,7 @@ argument | purpose
 `--install` | Preselects the install action, skipping the prompt asking what the user wants to do.
 `--uninstall` | Preselects the uninstall action, skipping the prompt asking what the user wants to do.
 `--game-path "path"` | Specifies the full path to the folder containing the Stardew Valley executable, skipping automatic detection and any prompt to choose a path. If the path is not valid, the installer displays an error.
+`--headless` | Installs or Uninstalls SMAPI without any user interaction. Should only be used in scripts, tools or if you know what you're doing.
 
 SMAPI itself recognises five arguments, but these are meant for internal use or testing, and might
 change without warning. **On Linux/macOS**, command-line arguments won't work; see _environment
@@ -96,7 +97,7 @@ Windows](#on-windows)_ section below to create a build that retains the icon.**
    2. Run `sudo apt update` in WSL to update the package list.
    3. The rest of the instructions below should be run in WSL.
 2. Install the required software:
-   1. Install the [.NET 5 SDK](https://docs.microsoft.com/en-us/dotnet/core/install/linux-ubuntu).  
+   1. Install the [.NET 5 SDK](https://docs.microsoft.com/en-us/dotnet/core/install/linux-ubuntu).
       _For Ubuntu-based systems, you can run `lsb_release -a` to get the Ubuntu version number._
    2. [Install Steam](https://linuxconfig.org/how-to-install-steam-on-ubuntu-20-04-focal-fossa-linux).
    3. Launch `steam` and install the game like usual.
diff --git a/src/SMAPI.Installer/InteractiveInstaller.cs b/src/SMAPI.Installer/InteractiveInstaller.cs
index 32a4e6e5..d07538e7 100644
--- a/src/SMAPI.Installer/InteractiveInstaller.cs
+++ b/src/SMAPI.Installer/InteractiveInstaller.cs
@@ -33,6 +33,9 @@ namespace StardewModdingApi.Installer
             "SMAPI.ErrorHandler"
         };
 
+        /// <summary>If the installer should run headless, does not ask the user for any input when true.</summary>
+        private readonly bool Headless;
+
         /// <summary>Get the absolute file or folder paths to remove when uninstalling SMAPI.</summary>
         /// <param name="installDir">The folder for Stardew Valley and SMAPI.</param>
         /// <param name="modsDir">The folder for SMAPI mods.</param>
@@ -97,10 +100,11 @@ namespace StardewModdingApi.Installer
         *********/
         /// <summary>Construct an instance.</summary>
         /// <param name="bundlePath">The absolute path to the directory containing the files to copy into the game folder.</param>
-        public InteractiveInstaller(string bundlePath)
+        public InteractiveInstaller(string bundlePath, bool headless)
         {
             this.BundlePath = bundlePath;
             this.ConsoleWriter = new ColorfulConsoleWriter(EnvironmentUtility.DetectPlatform());
+            this.Headless = headless;
         }
 
         /// <summary>Run the install or uninstall script.</summary>
@@ -142,14 +146,14 @@ namespace StardewModdingApi.Installer
             if (context.IsUnix)
             {
                 this.PrintError($"This is the installer for Windows. Run the 'install on {context.Platform}.{(context.Platform == Platform.Mac ? "command" : "sh")}' file instead.");
-                Console.ReadLine();
+                this.AwaitConfirmation();
                 return;
             }
 #else
             if (context.IsWindows)
             {
                 this.PrintError($"This is the installer for Linux/macOS. Run the 'install on Windows.exe' file instead.");
-                Console.ReadLine();
+                this.AwaitConfirmation();
                 return;
             }
 #endif
@@ -163,7 +167,12 @@ namespace StardewModdingApi.Installer
             if (installArg && uninstallArg)
             {
                 this.PrintError("You can't specify both --install and --uninstall command-line flags.");
-                Console.ReadLine();
+                this.AwaitConfirmation();
+                return;
+            }
+            if (!installArg && !uninstallArg && Headless)
+            {
+                this.PrintError("Either --install or --uninstall is required when running with --headless.");
                 return;
             }
 
@@ -180,7 +189,7 @@ namespace StardewModdingApi.Installer
             ** Step 2: choose a theme (can't auto-detect on Linux/macOS)
             *********/
             MonitorColorScheme scheme = MonitorColorScheme.AutoDetect;
-            if (context.IsUnix)
+            if (context.IsUnix && !Headless)
             {
                 /****
                 ** print header
@@ -245,7 +254,7 @@ namespace StardewModdingApi.Installer
                 if (installDir == null)
                 {
                     this.PrintError("Failed finding your game path.");
-                    Console.ReadLine();
+                    this.AwaitConfirmation();
                     return;
                 }
 
@@ -262,7 +271,7 @@ namespace StardewModdingApi.Installer
             if (!File.Exists(paths.GameDllPath))
             {
                 this.PrintError("The detected game install path doesn't contain a Stardew Valley executable.");
-                Console.ReadLine();
+                this.AwaitConfirmation();
                 return;
             }
             Console.Clear();
@@ -513,7 +522,7 @@ namespace StardewModdingApi.Installer
                 );
             }
 
-            Console.ReadKey();
+            this.AwaitConfirmation();
         }
 
 
@@ -594,7 +603,7 @@ namespace StardewModdingApi.Installer
                 {
                     this.PrintError($"Oops! The installer couldn't delete {path}: [{ex.GetType().Name}] {ex.Message}.");
                     this.PrintError("Try rebooting your computer and then run the installer again. If that doesn't work, try deleting it yourself then press any key to retry.");
-                    Console.ReadKey();
+                    this.AwaitConfirmation();
                 }
             }
         }
@@ -906,5 +915,14 @@ namespace StardewModdingApi.Installer
                 _ => true
             };
         }
+
+        /// <summary>Await confirmation (pressing enter) from the User.</summary>
+        private void AwaitConfirmation()
+        {
+            if (!this.Headless)
+            {
+                Console.ReadLine();
+            }
+        }
     }
 }
diff --git a/src/SMAPI.Installer/Program.cs b/src/SMAPI.Installer/Program.cs
index dc452a46..cf38f1cf 100644
--- a/src/SMAPI.Installer/Program.cs
+++ b/src/SMAPI.Installer/Program.cs
@@ -4,6 +4,7 @@ using System.IO;
 using System.IO.Compression;
 using System.Reflection;
 using System.Threading;
+using System.Linq;
 
 namespace StardewModdingApi.Installer
 {
@@ -47,8 +48,9 @@ namespace StardewModdingApi.Installer
             // set up assembly resolution
             AppDomain.CurrentDomain.AssemblyResolve += Program.CurrentDomain_AssemblyResolve;
 
+            var headless = args.Contains("--headless");
             // launch installer
-            var installer = new InteractiveInstaller(bundleDir.FullName);
+            var installer = new InteractiveInstaller(bundleDir.FullName, headless);
 
             try
             {

From 05695be39073b1235ddc3b4d0445b8c074930080 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 12:36:02 -0400
Subject: [PATCH 11/19] remove unrelated `set -ex` in build script

---
 build/windows/finalize-install-package.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/build/windows/finalize-install-package.sh b/build/windows/finalize-install-package.sh
index 8428cf41..117e33e5 100755
--- a/build/windows/finalize-install-package.sh
+++ b/build/windows/finalize-install-package.sh
@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
 
-set -ex
-
 ##########
 ## Read config
 ##########

From 5196c3bad96b212625290595ff177e2e45f9a099 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 12:36:02 -0400
Subject: [PATCH 12/19] rename `--headless` to `--no-prompt`, and parse with
 the other args

---
 docs/technical/smapi.md                     |  4 +-
 src/SMAPI.Installer/InteractiveInstaller.cs | 96 ++++++++++-----------
 src/SMAPI.Installer/Program.cs              |  4 +-
 3 files changed, 51 insertions(+), 53 deletions(-)

diff --git a/docs/technical/smapi.md b/docs/technical/smapi.md
index 3dd66c78..d1591143 100644
--- a/docs/technical/smapi.md
+++ b/docs/technical/smapi.md
@@ -32,7 +32,7 @@ argument | purpose
 `--install` | Preselects the install action, skipping the prompt asking what the user wants to do.
 `--uninstall` | Preselects the uninstall action, skipping the prompt asking what the user wants to do.
 `--game-path "path"` | Specifies the full path to the folder containing the Stardew Valley executable, skipping automatic detection and any prompt to choose a path. If the path is not valid, the installer displays an error.
-`--headless` | Installs or Uninstalls SMAPI without any user interaction. Should only be used in scripts, tools or if you know what you're doing.
+`--no-prompt` | Don't let the installer wait for user input (e.g. for cases where it's being run by a script). If the installer is unable to continue without user input, it'll fail instead.
 
 SMAPI itself recognises five arguments, but these are meant for internal use or testing, and might
 change without warning. **On Linux/macOS**, command-line arguments won't work; see _environment
@@ -97,7 +97,7 @@ Windows](#on-windows)_ section below to create a build that retains the icon.**
    2. Run `sudo apt update` in WSL to update the package list.
    3. The rest of the instructions below should be run in WSL.
 2. Install the required software:
-   1. Install the [.NET 5 SDK](https://docs.microsoft.com/en-us/dotnet/core/install/linux-ubuntu).
+   1. Install the [.NET 5 SDK](https://docs.microsoft.com/en-us/dotnet/core/install/linux-ubuntu).  
       _For Ubuntu-based systems, you can run `lsb_release -a` to get the Ubuntu version number._
    2. [Install Steam](https://linuxconfig.org/how-to-install-steam-on-ubuntu-20-04-focal-fossa-linux).
    3. Launch `steam` and install the game like usual.
diff --git a/src/SMAPI.Installer/InteractiveInstaller.cs b/src/SMAPI.Installer/InteractiveInstaller.cs
index d07538e7..c21ccdf5 100644
--- a/src/SMAPI.Installer/InteractiveInstaller.cs
+++ b/src/SMAPI.Installer/InteractiveInstaller.cs
@@ -33,9 +33,6 @@ namespace StardewModdingApi.Installer
             "SMAPI.ErrorHandler"
         };
 
-        /// <summary>If the installer should run headless, does not ask the user for any input when true.</summary>
-        private readonly bool Headless;
-
         /// <summary>Get the absolute file or folder paths to remove when uninstalling SMAPI.</summary>
         /// <param name="installDir">The folder for Stardew Valley and SMAPI.</param>
         /// <param name="modsDir">The folder for SMAPI mods.</param>
@@ -100,11 +97,10 @@ namespace StardewModdingApi.Installer
         *********/
         /// <summary>Construct an instance.</summary>
         /// <param name="bundlePath">The absolute path to the directory containing the files to copy into the game folder.</param>
-        public InteractiveInstaller(string bundlePath, bool headless)
+        public InteractiveInstaller(string bundlePath)
         {
             this.BundlePath = bundlePath;
             this.ConsoleWriter = new ColorfulConsoleWriter(EnvironmentUtility.DetectPlatform());
-            this.Headless = headless;
         }
 
         /// <summary>Run the install or uninstall script.</summary>
@@ -139,40 +135,24 @@ namespace StardewModdingApi.Installer
             Console.Title = $"SMAPI {context.GetInstallerVersion()} installer on {context.Platform} {context.PlatformName}";
             Console.WriteLine();
 
-            /****
-            ** Check if correct installer
-            ****/
-#if SMAPI_FOR_WINDOWS
-            if (context.IsUnix)
-            {
-                this.PrintError($"This is the installer for Windows. Run the 'install on {context.Platform}.{(context.Platform == Platform.Mac ? "command" : "sh")}' file instead.");
-                this.AwaitConfirmation();
-                return;
-            }
-#else
-            if (context.IsWindows)
-            {
-                this.PrintError($"This is the installer for Linux/macOS. Run the 'install on Windows.exe' file instead.");
-                this.AwaitConfirmation();
-                return;
-            }
-#endif
-
             /****
             ** read command-line arguments
             ****/
-            // get action from CLI
+            // get input mode
+            bool allowUserInput = !args.Contains("--no-prompt");
+
+            // get action
             bool installArg = args.Contains("--install");
             bool uninstallArg = args.Contains("--uninstall");
             if (installArg && uninstallArg)
             {
                 this.PrintError("You can't specify both --install and --uninstall command-line flags.");
-                this.AwaitConfirmation();
+                this.AwaitConfirmation(allowUserInput);
                 return;
             }
-            if (!installArg && !uninstallArg && Headless)
+            if (!allowUserInput && !installArg && !uninstallArg)
             {
-                this.PrintError("Either --install or --uninstall is required when running with --headless.");
+                this.PrintError("You must specify --install or --uninstall when running with --no-prompt.");
                 return;
             }
 
@@ -184,12 +164,31 @@ namespace StardewModdingApi.Installer
                     gamePathArg = args[pathIndex];
             }
 
+            /****
+            ** Check if correct installer
+            ****/
+#if SMAPI_FOR_WINDOWS
+            if (context.IsUnix)
+            {
+                this.PrintError($"This is the installer for Windows. Run the 'install on {context.Platform}.{(context.Platform == Platform.Mac ? "command" : "sh")}' file instead.");
+                this.AwaitConfirmation(allowUserInput);
+                return;
+            }
+#else
+            if (context.IsWindows)
+            {
+                this.PrintError($"This is the installer for Linux/macOS. Run the 'install on Windows.exe' file instead.");
+                this.AwaitConfirmation();
+                return;
+            }
+#endif
+
 
             /*********
             ** Step 2: choose a theme (can't auto-detect on Linux/macOS)
             *********/
             MonitorColorScheme scheme = MonitorColorScheme.AutoDetect;
-            if (context.IsUnix && !Headless)
+            if (context.IsUnix && allowUserInput)
             {
                 /****
                 ** print header
@@ -254,7 +253,7 @@ namespace StardewModdingApi.Installer
                 if (installDir == null)
                 {
                     this.PrintError("Failed finding your game path.");
-                    this.AwaitConfirmation();
+                    this.AwaitConfirmation(allowUserInput);
                     return;
                 }
 
@@ -271,7 +270,7 @@ namespace StardewModdingApi.Installer
             if (!File.Exists(paths.GameDllPath))
             {
                 this.PrintError("The detected game install path doesn't contain a Stardew Valley executable.");
-                this.AwaitConfirmation();
+                this.AwaitConfirmation(allowUserInput);
                 return;
             }
             Console.Clear();
@@ -349,7 +348,7 @@ namespace StardewModdingApi.Installer
                 if (context.IsUnix && File.Exists(paths.BackupLaunchScriptPath))
                 {
                     this.PrintDebug("Removing SMAPI launcher...");
-                    this.InteractivelyDelete(paths.VanillaLaunchScriptPath);
+                    this.InteractivelyDelete(paths.VanillaLaunchScriptPath, allowUserInput);
                     File.Move(paths.BackupLaunchScriptPath, paths.VanillaLaunchScriptPath);
                 }
 
@@ -361,7 +360,7 @@ namespace StardewModdingApi.Installer
                 {
                     this.PrintDebug(action == ScriptAction.Install ? "Removing previous SMAPI files..." : "Removing SMAPI files...");
                     foreach (string path in removePaths)
-                        this.InteractivelyDelete(path);
+                        this.InteractivelyDelete(path, allowUserInput);
                 }
 
                 // move global save data folder (changed in 3.2)
@@ -373,7 +372,7 @@ namespace StardewModdingApi.Installer
                     if (oldDir.Exists)
                     {
                         if (newDir.Exists)
-                            this.InteractivelyDelete(oldDir.FullName);
+                            this.InteractivelyDelete(oldDir.FullName, allowUserInput);
                         else
                             oldDir.MoveTo(newDir.FullName);
                     }
@@ -388,7 +387,7 @@ namespace StardewModdingApi.Installer
                     this.PrintDebug("Adding SMAPI files...");
                     foreach (FileSystemInfo sourceEntry in paths.BundleDir.EnumerateFileSystemInfos().Where(this.ShouldCopy))
                     {
-                        this.InteractivelyDelete(Path.Combine(paths.GameDir.FullName, sourceEntry.Name));
+                        this.InteractivelyDelete(Path.Combine(paths.GameDir.FullName, sourceEntry.Name), allowUserInput);
                         this.RecursiveCopy(sourceEntry, paths.GameDir);
                     }
 
@@ -403,7 +402,7 @@ namespace StardewModdingApi.Installer
                             if (!File.Exists(paths.BackupLaunchScriptPath))
                                 File.Move(paths.VanillaLaunchScriptPath, paths.BackupLaunchScriptPath);
                             else
-                                this.InteractivelyDelete(paths.VanillaLaunchScriptPath);
+                                this.InteractivelyDelete(paths.VanillaLaunchScriptPath, allowUserInput);
                         }
 
                         // add new launcher
@@ -473,7 +472,7 @@ namespace StardewModdingApi.Installer
 
                             // remove existing folder
                             if (targetFolder.Exists)
-                                this.InteractivelyDelete(targetFolder.FullName);
+                                this.InteractivelyDelete(targetFolder.FullName, allowUserInput);
 
                             // copy files
                             this.RecursiveCopy(sourceMod.Directory, paths.ModsDir, filter: this.ShouldCopy);
@@ -491,7 +490,7 @@ namespace StardewModdingApi.Installer
 
 #if SMAPI_DEPRECATED
                     // remove obsolete appdata mods
-                    this.InteractivelyRemoveAppDataMods(paths.ModsDir, bundledModsDir);
+                    this.InteractivelyRemoveAppDataMods(paths.ModsDir, bundledModsDir, allowUserInput);
 #endif
                 }
             }
@@ -522,7 +521,7 @@ namespace StardewModdingApi.Installer
                 );
             }
 
-            this.AwaitConfirmation();
+            this.AwaitConfirmation(allowUserInput);
         }
 
 
@@ -590,7 +589,8 @@ namespace StardewModdingApi.Installer
 
         /// <summary>Interactively delete a file or folder path, and block until deletion completes.</summary>
         /// <param name="path">The file or folder path.</param>
-        private void InteractivelyDelete(string path)
+        /// <param name="allowUserInput">Whether the installer can ask for user input from the terminal.</param>
+        private void InteractivelyDelete(string path, bool allowUserInput)
         {
             while (true)
             {
@@ -603,7 +603,7 @@ namespace StardewModdingApi.Installer
                 {
                     this.PrintError($"Oops! The installer couldn't delete {path}: [{ex.GetType().Name}] {ex.Message}.");
                     this.PrintError("Try rebooting your computer and then run the installer again. If that doesn't work, try deleting it yourself then press any key to retry.");
-                    this.AwaitConfirmation();
+                    this.AwaitConfirmation(allowUserInput);
                 }
             }
         }
@@ -823,7 +823,8 @@ namespace StardewModdingApi.Installer
         /// <summary>Interactively move mods out of the app data directory.</summary>
         /// <param name="properModsDir">The directory which should contain all mods.</param>
         /// <param name="packagedModsDir">The installer directory containing packaged mods.</param>
-        private void InteractivelyRemoveAppDataMods(DirectoryInfo properModsDir, DirectoryInfo packagedModsDir)
+        /// <param name="allowUserInput">Whether the installer can ask for user input from the terminal.</param>
+        private void InteractivelyRemoveAppDataMods(DirectoryInfo properModsDir, DirectoryInfo packagedModsDir, bool allowUserInput)
         {
             // get packaged mods to delete
             string[] packagedModNames = packagedModsDir.GetDirectories().Select(p => p.Name).ToArray();
@@ -850,7 +851,7 @@ namespace StardewModdingApi.Installer
                 if (isDir && packagedModNames.Contains(entry.Name, StringComparer.OrdinalIgnoreCase))
                 {
                     this.PrintDebug($"   Deleting {entry.Name} because it's bundled into SMAPI...");
-                    this.InteractivelyDelete(entry.FullName);
+                    this.InteractivelyDelete(entry.FullName, allowUserInput);
                     continue;
                 }
 
@@ -916,13 +917,12 @@ namespace StardewModdingApi.Installer
             };
         }
 
-        /// <summary>Await confirmation (pressing enter) from the User.</summary>
-        private void AwaitConfirmation()
+        /// <summary>Wait until the user presses enter to confirm, if user input is allowed.</summary>
+        /// <param name="allowUserInput">Whether the installer can ask for user input from the terminal.</param>
+        private void AwaitConfirmation(bool allowUserInput)
         {
-            if (!this.Headless)
-            {
+            if (allowUserInput)
                 Console.ReadLine();
-            }
         }
     }
 }
diff --git a/src/SMAPI.Installer/Program.cs b/src/SMAPI.Installer/Program.cs
index cf38f1cf..dc452a46 100644
--- a/src/SMAPI.Installer/Program.cs
+++ b/src/SMAPI.Installer/Program.cs
@@ -4,7 +4,6 @@ using System.IO;
 using System.IO.Compression;
 using System.Reflection;
 using System.Threading;
-using System.Linq;
 
 namespace StardewModdingApi.Installer
 {
@@ -48,9 +47,8 @@ namespace StardewModdingApi.Installer
             // set up assembly resolution
             AppDomain.CurrentDomain.AssemblyResolve += Program.CurrentDomain_AssemblyResolve;
 
-            var headless = args.Contains("--headless");
             // launch installer
-            var installer = new InteractiveInstaller(bundleDir.FullName, headless);
+            var installer = new InteractiveInstaller(bundleDir.FullName);
 
             try
             {

From 7c6da8e5ec4e51692fd2610bb7e63367d68a7a0f Mon Sep 17 00:00:00 2001
From: atravita-mods <94934860+atravita-mods@users.noreply.github.com>
Date: Tue, 20 Jun 2023 22:07:57 -0400
Subject: [PATCH 13/19] adds validation for missing image sources on tilesheets

---
 src/SMAPI/Framework/ContentManagers/ModContentManager.cs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/SMAPI/Framework/ContentManagers/ModContentManager.cs b/src/SMAPI/Framework/ContentManagers/ModContentManager.cs
index 2c068784..c8a01b70 100644
--- a/src/SMAPI/Framework/ContentManagers/ModContentManager.cs
+++ b/src/SMAPI/Framework/ContentManagers/ModContentManager.cs
@@ -432,6 +432,12 @@ namespace StardewModdingAPI.Framework.ContentManagers
             this.Monitor.VerboseLog($"Fixing tilesheet paths for map '{relativeMapPath}' from mod '{this.ModName}'...");
             foreach (TileSheet tilesheet in map.TileSheets)
             {
+                // validate image source
+                if (string.IsNullOrWhiteSpace(tilesheet.ImageSource))
+                {
+                    throw new SContentLoadException(ContentLoadErrorType.InvalidData, $"Could not load tilesheet '{tilesheet.Id}' for mod {this.ModName} - no image source found.");
+                }
+
                 // get image source
                 tilesheet.ImageSource = this.NormalizePathSeparators(tilesheet.ImageSource);
                 string imageSource = tilesheet.ImageSource;

From ae36b9b166c25f173869a3d28d350dd5ebeda113 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 12:43:44 -0400
Subject: [PATCH 14/19] tweak new validation error text

---
 .../Framework/ContentManagers/ModContentManager.cs     | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/SMAPI/Framework/ContentManagers/ModContentManager.cs b/src/SMAPI/Framework/ContentManagers/ModContentManager.cs
index c8a01b70..8cdb65eb 100644
--- a/src/SMAPI/Framework/ContentManagers/ModContentManager.cs
+++ b/src/SMAPI/Framework/ContentManagers/ModContentManager.cs
@@ -432,16 +432,14 @@ namespace StardewModdingAPI.Framework.ContentManagers
             this.Monitor.VerboseLog($"Fixing tilesheet paths for map '{relativeMapPath}' from mod '{this.ModName}'...");
             foreach (TileSheet tilesheet in map.TileSheets)
             {
-                // validate image source
-                if (string.IsNullOrWhiteSpace(tilesheet.ImageSource))
-                {
-                    throw new SContentLoadException(ContentLoadErrorType.InvalidData, $"Could not load tilesheet '{tilesheet.Id}' for mod {this.ModName} - no image source found.");
-                }
-
                 // get image source
                 tilesheet.ImageSource = this.NormalizePathSeparators(tilesheet.ImageSource);
                 string imageSource = tilesheet.ImageSource;
 
+                // validate image source
+                if (string.IsNullOrWhiteSpace(imageSource))
+                    throw new SContentLoadException(ContentLoadErrorType.InvalidData, $"{this.ModName} loaded map '{relativeMapPath}' with invalid tilesheet '{tilesheet.Id}'. This tilesheet has no image source.");
+
                 // reverse incorrect eager tilesheet path prefixing
                 if (fixEagerPathPrefixes && relativeMapFolder.Length > 0 && imageSource.StartsWith(relativeMapFolder))
                     imageSource = imageSource[(relativeMapFolder.Length + 1)..];

From ebdb17bf81f2586aa0a88227171008ea793495b2 Mon Sep 17 00:00:00 2001
From: nea <nea@nea.moe>
Date: Thu, 22 Jun 2023 01:41:16 +0200
Subject: [PATCH 15/19] Add wezterm terminal support for linux

---
 src/SMAPI.Installer/assets/unix-launcher.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/SMAPI.Installer/assets/unix-launcher.sh b/src/SMAPI.Installer/assets/unix-launcher.sh
index 778663d7..751e219e 100644
--- a/src/SMAPI.Installer/assets/unix-launcher.sh
+++ b/src/SMAPI.Installer/assets/unix-launcher.sh
@@ -93,7 +93,7 @@ else
     # run in terminal
     if [ "$USE_CURRENT_SHELL" == "false" ]; then
         # select terminal (prefer xterm for best compatibility, then known supported terminals)
-        for terminal in xterm gnome-terminal kitty terminator xfce4-terminal konsole terminal termite alacritty mate-terminal x-terminal-emulator; do
+        for terminal in xterm gnome-terminal kitty terminator xfce4-terminal konsole terminal termite alacritty mate-terminal x-terminal-emulator wezterm; do
             if command -v "$terminal" 2>/dev/null; then
                 export TERMINAL_NAME=$terminal
                 break;
@@ -132,6 +132,11 @@ else
                     exec "$TERMINAL_NAME" -- env TERM=xterm $LAUNCH_FILE "$@"
                     ;;
 
+                wezterm)
+                    # consumes all arguments after start --. does not copy working directory automatically, needs --cwd for that.
+                    exec "$TERMINAL_NAME" start --cwd "$(pwd)" -- env TERM=xterm $LAUNCH_FILE "$@"
+                    ;;
+
                 kitty)
                     # consumes all trailing arguments
                     exec "$TERMINAL_NAME" env TERM=xterm $LAUNCH_FILE "$@"

From db33481dffa68373b7497ce5a5cda4cb997c69ad Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 12:57:12 -0400
Subject: [PATCH 16/19] update release notes

---
 docs/release-notes.md | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index 449e3791..6674f8bd 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -10,10 +10,13 @@
 ## Upcoming release
 * For players:
   * In multiplayer, the game/SMAPI window titles now show whether you're the main player or a farmhand.
+  * Fixed wezterm terminal support on Linux/macoS (thanks to romangraef!).
   * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
   * Fixed install error if a game folder has an invalid symlink.
 
 * For mod authors:
+  * Added `--no-prompt` command-line argument for the installer, to better support running it automatically (thanks to NyCodeGHG!).
+  * Added clearer error message when a map tilesheet has no image source (thanks to atravita!).
   * Fixed `Context.HasRemotePlayers` being true when there's no farmhands connected.
   * Fixed error loading a mod if it sets `"MinimumApiVersion": null` explicitly.
   * Updated Newtonsoft.Json 13.0.2 &rarr; 13.0.3 (see [changes](https://github.com/JamesNK/Newtonsoft.Json/releases/tag/13.0.3)) and Pintail 2.2.2 &rarr; 2.3.0 (see [changes](https://github.com/Nanoray-pl/Pintail/blob/master/docs/release-notes.md#230)).
@@ -21,6 +24,9 @@
 * For SMAPI toolkit users:
   * Fixed `ModFolder` not being JSON-serializable.
 
+* For the web API:
+  * Fixed manifest schema format for the `examples` field (thanks to boneskull!).
+
 ## 3.18.3
 Released 09 April 2023 for Stardew Valley 1.5.6 or later.
 

From 7d96f29afff2dda7293eca428717c6025fc7418f Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 14:20:37 -0400
Subject: [PATCH 17/19] remove test_input time limit

---
 docs/release-notes.md                         |  1 +
 .../Commands/Other/TestInputCommand.cs        | 29 +++++--------------
 2 files changed, 9 insertions(+), 21 deletions(-)

diff --git a/docs/release-notes.md b/docs/release-notes.md
index 6674f8bd..3aca6f9b 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -10,6 +10,7 @@
 ## Upcoming release
 * For players:
   * In multiplayer, the game/SMAPI window titles now show whether you're the main player or a farmhand.
+  * The `test_input` console command now logs player input until the command is run again, instead of only 30 seconds.
   * Fixed wezterm terminal support on Linux/macoS (thanks to romangraef!).
   * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
   * Fixed install error if a game folder has an invalid symlink.
diff --git a/src/SMAPI.Mods.ConsoleCommands/Framework/Commands/Other/TestInputCommand.cs b/src/SMAPI.Mods.ConsoleCommands/Framework/Commands/Other/TestInputCommand.cs
index 8bf9f5db..67325c7c 100644
--- a/src/SMAPI.Mods.ConsoleCommands/Framework/Commands/Other/TestInputCommand.cs
+++ b/src/SMAPI.Mods.ConsoleCommands/Framework/Commands/Other/TestInputCommand.cs
@@ -1,4 +1,3 @@
-using System;
 using System.Diagnostics.CodeAnalysis;
 
 namespace StardewModdingAPI.Mods.ConsoleCommands.Framework.Commands.Other
@@ -10,11 +9,8 @@ namespace StardewModdingAPI.Mods.ConsoleCommands.Framework.Commands.Other
         /*********
         ** Fields
         *********/
-        /// <summary>The number of seconds for which to log input.</summary>
-        private readonly int LogSeconds = 30;
-
-        /// <summary>When the command should stop printing input, or <c>null</c> if currently disabled.</summary>
-        private long? ExpiryTicks;
+        /// <summary>Whether the command should print input.</summary>
+        private bool Enabled;
 
 
         /*********
@@ -30,21 +26,12 @@ namespace StardewModdingAPI.Mods.ConsoleCommands.Framework.Commands.Other
         /// <param name="args">The command arguments.</param>
         public override void Handle(IMonitor monitor, string command, ArgumentParser args)
         {
-            this.ExpiryTicks = DateTime.UtcNow.Add(TimeSpan.FromSeconds(this.LogSeconds)).Ticks;
-            monitor.Log($"OK, logging all player input for {this.LogSeconds} seconds.", LogLevel.Info);
-        }
+            this.Enabled = !this.Enabled;
 
-        /// <summary>Perform any logic needed on update tick.</summary>
-        /// <param name="monitor">Writes messages to the console and log file.</param>
-        public override void OnUpdated(IMonitor monitor)
-        {
-            // handle expiry
-            if (this.ExpiryTicks != null && this.ExpiryTicks <= DateTime.UtcNow.Ticks)
-            {
-                monitor.Log("No longer logging input.", LogLevel.Info);
-                this.ExpiryTicks = null;
-                return;
-            }
+            monitor.Log(
+                this.Enabled ? "OK, logging all player input until you run this command again." : "OK, no longer logging player input.",
+                LogLevel.Info
+            );
         }
 
         /// <summary>Perform any logic when input is received.</summary>
@@ -52,7 +39,7 @@ namespace StardewModdingAPI.Mods.ConsoleCommands.Framework.Commands.Other
         /// <param name="button">The button that was pressed.</param>
         public override void OnButtonPressed(IMonitor monitor, SButton button)
         {
-            if (this.ExpiryTicks != null)
+            if (this.Enabled)
                 monitor.Log($"Pressed {button}", LogLevel.Info);
         }
     }

From eeb4e12f750e449f7ed466f1ee27709fb34a6e3b Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 15:48:21 -0400
Subject: [PATCH 18/19] fix Linux/macOS build error

---
 src/SMAPI.Installer/InteractiveInstaller.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/SMAPI.Installer/InteractiveInstaller.cs b/src/SMAPI.Installer/InteractiveInstaller.cs
index c21ccdf5..c256be42 100644
--- a/src/SMAPI.Installer/InteractiveInstaller.cs
+++ b/src/SMAPI.Installer/InteractiveInstaller.cs
@@ -178,7 +178,7 @@ namespace StardewModdingApi.Installer
             if (context.IsWindows)
             {
                 this.PrintError($"This is the installer for Linux/macOS. Run the 'install on Windows.exe' file instead.");
-                this.AwaitConfirmation();
+                this.AwaitConfirmation(allowUserInput);
                 return;
             }
 #endif

From 4e27841fb21b1f665142986ab87e443b5ad8ba85 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 16:53:13 -0400
Subject: [PATCH 19/19] prepare for release

---
 build/common.targets                          |  2 +-
 docs/release-notes.md                         | 14 +++++-----
 docs/technical/mod-package.md                 | 26 ++++++++++---------
 .../SMAPI.ModBuildConfig.csproj               |  2 +-
 src/SMAPI.Mods.ConsoleCommands/manifest.json  |  4 +--
 src/SMAPI.Mods.ErrorHandler/manifest.json     |  4 +--
 src/SMAPI.Mods.SaveBackup/manifest.json       |  4 +--
 src/SMAPI/Constants.cs                        |  2 +-
 8 files changed, 31 insertions(+), 27 deletions(-)

diff --git a/build/common.targets b/build/common.targets
index bb13a26a..961da53a 100644
--- a/build/common.targets
+++ b/build/common.targets
@@ -7,7 +7,7 @@ repo. It imports the other MSBuild files as needed.
 <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <!--set general build properties -->
-    <Version>3.18.3</Version>
+    <Version>3.18.4</Version>
     <Product>SMAPI</Product>
     <LangVersion>latest</LangVersion>
     <AssemblySearchPaths>$(AssemblySearchPaths);{GAC}</AssemblySearchPaths>
diff --git a/docs/release-notes.md b/docs/release-notes.md
index 3aca6f9b..40392ce5 100644
--- a/docs/release-notes.md
+++ b/docs/release-notes.md
@@ -7,20 +7,22 @@
   _If needed, you can update to SMAPI 3.16.0 first and then install the latest version._
 -->
 
-## Upcoming release
+## 3.18.4
+Released 24 June 2023 for Stardew Valley 1.5.6 or later.
+
 * For players:
   * In multiplayer, the game/SMAPI window titles now show whether you're the main player or a farmhand.
-  * The `test_input` console command now logs player input until the command is run again, instead of only 30 seconds.
-  * Fixed wezterm terminal support on Linux/macoS (thanks to romangraef!).
+  * The `test_input` console command now logs input until the command is run again (instead of for 30 seconds).
   * Fixed logged SMAPI errors not having line numbers on Linux/macOS.
+  * Fixed wezterm terminal support on Linux/macoS (thanks to romangraef!).
   * Fixed install error if a game folder has an invalid symlink.
 
 * For mod authors:
-  * Added `--no-prompt` command-line argument for the installer, to better support running it automatically (thanks to NyCodeGHG!).
+  * Added `--no-prompt` installer command-line argument for automated tools (thanks to NyCodeGHG!).
   * Added clearer error message when a map tilesheet has no image source (thanks to atravita!).
   * Fixed `Context.HasRemotePlayers` being true when there's no farmhands connected.
-  * Fixed error loading a mod if it sets `"MinimumApiVersion": null` explicitly.
-  * Updated Newtonsoft.Json 13.0.2 &rarr; 13.0.3 (see [changes](https://github.com/JamesNK/Newtonsoft.Json/releases/tag/13.0.3)) and Pintail 2.2.2 &rarr; 2.3.0 (see [changes](https://github.com/Nanoray-pl/Pintail/blob/master/docs/release-notes.md#230)).
+  * Fixed error loading a mod if it explicitly sets `"MinimumApiVersion": null`.
+  * Updated Newtonsoft.Json 13.0.2 → 13.0.3 (see [changes](https://github.com/JamesNK/Newtonsoft.Json/releases/tag/13.0.3)) and Pintail 2.2.2 → 2.3.0 (see [changes](https://github.com/Nanoray-pl/Pintail/blob/master/docs/release-notes.md#230)).
 
 * For SMAPI toolkit users:
   * Fixed `ModFolder` not being JSON-serializable.
diff --git a/docs/technical/mod-package.md b/docs/technical/mod-package.md
index 023ef070..20e8c834 100644
--- a/docs/technical/mod-package.md
+++ b/docs/technical/mod-package.md
@@ -416,31 +416,33 @@ The NuGet package is generated automatically in `StardewModdingAPI.ModBuildConfi
 when you compile it.
 
 ## Release notes
-## Upcoming release
-* Replaced `.pdb` files with embedded symbols by default. This fixes logged SMAPI errors not having line numbers on Linux/macOS.
+## 4.1.1
+Released 24 June 2023 for SMAPI 3.13.0 or later.
+
+* Replaced `.pdb` files with embedded symbols by default. This fixes logged errors not having line numbers on Linux/macOS.
 
 ### 4.1.0
-Released 08 January 2023.
+Released 08 January 2023 for SMAPI 3.13.0 or later.
 
 * Added `manifest.json` format validation on build (thanks to tylergibbs2!).
 * Fixed game DLLs not excluded from the release zip when they're referenced explicitly but `BundleExtraAssemblies` isn't set.
 
 ### 4.0.2
-Released 09 October 2022.
+Released 09 October 2022 for SMAPI 3.13.0 or later.
 
 * Switched to the newer crossplatform `portable` debug symbols (thanks to lanturnalis!).
 * Fixed `BundleExtraAssemblies` option being partly case-sensitive.
 * Fixed `BundleExtraAssemblies` not applying `All` value to game assemblies.
 
 ### 4.0.1
-Released 14 April 2022.
+Released 14 April 2022 for SMAPI 3.13.0 or later.
 
 * Added detection for Xbox app game folders.
 * Fixed "_conflicts between different versions of Microsoft.Win32.Registry_" warnings in recent SMAPI versions.
 * Internal refactoring.
 
 ### 4.0.0
-Released 30 November 2021.
+Released 30 November 2021 for SMAPI 3.13.0 or later.
 
 * Updated for Stardew Valley 1.5.5 and SMAPI 3.13.0. (Older versions are no longer supported.)
 * Added `IgnoreModFilePaths` option to ignore literal paths.
@@ -462,7 +464,7 @@ Released 30 November 2021.
      documentation](#configure).
 
 ### 3.3.0
-Released 30 March 2021.
+Released 30 March 2021 for SMAPI 3.0.0 or later.
 
 * Added a build warning when the mod isn't compiled for `Any CPU`.
 * Added a `GameFramework` build property set to `MonoGame` or `Xna` based on the platform. This can
@@ -471,32 +473,32 @@ Released 30 March 2021.
 * The package now suppresses the misleading 'processor architecture mismatch' warnings.
 
 ### 3.2.2
-Released 23 September 2020.
+Released 23 September 2020 for SMAPI 3.0.0 or later.
 
 * Reworked and streamlined how the package is compiled.
 * Added [SMAPI-ModTranslationClassBuilder](https://github.com/Pathoschild/SMAPI-ModTranslationClassBuilder)
   files to the ignore list.
 
 ### 3.2.1
-Released 11 September 2020.
+Released 11 September 2020 for SMAPI 3.0.0 or later.
 
 * Added more detailed logging.
 * Fixed _path's format is not supported_ error when using default `Mods` path in 3.2.
 
 ### 3.2.0
-Released 07 September 2020.
+Released 07 September 2020 for SMAPI 3.0.0 or later.
 
 * Added option to change `Mods` folder path.
 * Rewrote documentation to make it easier to read.
 
 ### 3.1.0
-Released 01 February 2020.
+Released 01 February 2020 for SMAPI 3.0.0 or later.
 
 * Added support for semantic versioning 2.0.
 * `0Harmony.dll` is now ignored if the mod references Harmony directly (it's bundled with SMAPI).
 
 ### 3.0.0
-Released 26 November 2019.
+Released 26 November 2019 for SMAPI 3.0.0 or later.
 
 * Updated for SMAPI 3.0 and Stardew Valley 1.4.
 * Added automatic support for `assets` folders.
diff --git a/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj b/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj
index 6d9a0d9e..2e97d53f 100644
--- a/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj
+++ b/src/SMAPI.ModBuildConfig/SMAPI.ModBuildConfig.csproj
@@ -10,7 +10,7 @@
     <!--NuGet package-->
     <PackageId>Pathoschild.Stardew.ModBuildConfig</PackageId>
     <Title>Build package for SMAPI mods</Title>
-    <Version>4.1.0</Version>
+    <Version>4.1.1</Version>
     <Authors>Pathoschild</Authors>
     <Description>Automates the build configuration for crossplatform Stardew Valley SMAPI mods. For SMAPI 3.13.0 or later.</Description>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
diff --git a/src/SMAPI.Mods.ConsoleCommands/manifest.json b/src/SMAPI.Mods.ConsoleCommands/manifest.json
index 2447c5c3..9e70936f 100644
--- a/src/SMAPI.Mods.ConsoleCommands/manifest.json
+++ b/src/SMAPI.Mods.ConsoleCommands/manifest.json
@@ -1,9 +1,9 @@
 {
     "Name": "Console Commands",
     "Author": "SMAPI",
-    "Version": "3.18.3",
+    "Version": "3.18.4",
     "Description": "Adds SMAPI console commands that let you manipulate the game.",
     "UniqueID": "SMAPI.ConsoleCommands",
     "EntryDll": "ConsoleCommands.dll",
-    "MinimumApiVersion": "3.18.3"
+    "MinimumApiVersion": "3.18.4"
 }
diff --git a/src/SMAPI.Mods.ErrorHandler/manifest.json b/src/SMAPI.Mods.ErrorHandler/manifest.json
index 306c92fc..b007b672 100644
--- a/src/SMAPI.Mods.ErrorHandler/manifest.json
+++ b/src/SMAPI.Mods.ErrorHandler/manifest.json
@@ -1,9 +1,9 @@
 {
     "Name": "Error Handler",
     "Author": "SMAPI",
-    "Version": "3.18.3",
+    "Version": "3.18.4",
     "Description": "Handles some common vanilla errors to log more useful info or avoid breaking the game.",
     "UniqueID": "SMAPI.ErrorHandler",
     "EntryDll": "ErrorHandler.dll",
-    "MinimumApiVersion": "3.18.3"
+    "MinimumApiVersion": "3.18.4"
 }
diff --git a/src/SMAPI.Mods.SaveBackup/manifest.json b/src/SMAPI.Mods.SaveBackup/manifest.json
index c5075c57..7b819ec6 100644
--- a/src/SMAPI.Mods.SaveBackup/manifest.json
+++ b/src/SMAPI.Mods.SaveBackup/manifest.json
@@ -1,9 +1,9 @@
 {
     "Name": "Save Backup",
     "Author": "SMAPI",
-    "Version": "3.18.3",
+    "Version": "3.18.4",
     "Description": "Automatically backs up all your saves once per day into its folder.",
     "UniqueID": "SMAPI.SaveBackup",
     "EntryDll": "SaveBackup.dll",
-    "MinimumApiVersion": "3.18.3"
+    "MinimumApiVersion": "3.18.4"
 }
diff --git a/src/SMAPI/Constants.cs b/src/SMAPI/Constants.cs
index 77a19964..416e1ec7 100644
--- a/src/SMAPI/Constants.cs
+++ b/src/SMAPI/Constants.cs
@@ -52,7 +52,7 @@ namespace StardewModdingAPI
         internal static int? LogScreenId { get; set; }
 
         /// <summary>SMAPI's current raw semantic version.</summary>
-        internal static string RawApiVersion = "3.18.3";
+        internal static string RawApiVersion = "3.18.4";
     }
 
     /// <summary>Contains SMAPI's constants and assumptions.</summary>