From 445370b75b71ae27a974a6bc746db707653aee8c Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <Pathoschild@users.noreply.github.com>
Date: Sat, 24 Jun 2023 11:50:05 -0400
Subject: [PATCH] embed debug symbols for Linux/macOS compatibility in mod
 build package

---
 docs/technical/mod-package.md                | 3 +++
 src/SMAPI.ModBuildConfig/build/smapi.targets | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/docs/technical/mod-package.md b/docs/technical/mod-package.md
index ab8a2c95..023ef070 100644
--- a/docs/technical/mod-package.md
+++ b/docs/technical/mod-package.md
@@ -416,6 +416,9 @@ The NuGet package is generated automatically in `StardewModdingAPI.ModBuildConfi
 when you compile it.
 
 ## Release notes
+## Upcoming release
+* Replaced `.pdb` files with embedded symbols by default. This fixes logged SMAPI errors not having line numbers on Linux/macOS.
+
 ### 4.1.0
 Released 08 January 2023.
 
diff --git a/src/SMAPI.ModBuildConfig/build/smapi.targets b/src/SMAPI.ModBuildConfig/build/smapi.targets
index b4fd312e..41b5bc86 100644
--- a/src/SMAPI.ModBuildConfig/build/smapi.targets
+++ b/src/SMAPI.ModBuildConfig/build/smapi.targets
@@ -8,8 +8,9 @@
   ** Set build options
   **********************************************-->
   <PropertyGroup>
-    <!-- enable line numbers in stack traces -->
+    <!-- enable line numbers in stack traces (needs to embedded for Linux/macOS: https://github.com/dotnet/runtime/issues/39987) -->
     <DebugSymbols>true</DebugSymbols>
+    <DebugType>embedded</DebugType>
 
     <!-- don't create the 'refs' folder (which isn't useful for mods) -->
     <ProduceReferenceAssembly>false</ProduceReferenceAssembly>