StardewValley
/
SMAPI
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix RewriteMods option ignored when rewriting mod for OS

This commit is contained in:
Jesse Plamondon-Willard 2021-03-04 21:59:49 -05:00
parent 699a07ecf7
commit 5a2258f419
No known key found for this signature in database
GPG Key ID: CF8B1456B3E29F49
2 changed files with 31 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes.md
View File

@ -13,6 +13,7 @@
* For mod authors: * For mod authors:
* Added three stages to the `LoadStageChanged` event: `CreatedInitialLocations`/`SaveAddedLocations` (raised immediately after the game adds locations but before they're initialized), and `ReturningToTitle` (raised before exiting to the title screen). * Added three stages to the `LoadStageChanged` event: `CreatedInitialLocations`/`SaveAddedLocations` (raised immediately after the game adds locations but before they're initialized), and `ReturningToTitle` (raised before exiting to the title screen).
* Fixed `RewriteMods` option in `smapi-internal/config.json` ignored when rewriting mod for OS compatibility.
* Fixed edge case when playing as a farmhand in non-English where translatable assets loaded via `IAssetLoader` weren't reapplied immediately when the server disconnects. * Fixed edge case when playing as a farmhand in non-English where translatable assets loaded via `IAssetLoader` weren't reapplied immediately when the server disconnects.
## 3.9.2 ## 3.9.2

3
src/SMAPI/Framework/ModLoading/AssemblyLoader.cs
View File

@ -276,6 +276,8 @@ namespace StardewModdingAPI.Framework.ModLoading
// swap assembly references if needed (e.g. XNA => MonoGame) // swap assembly references if needed (e.g. XNA => MonoGame)
bool platformChanged = false; bool platformChanged = false;
if (this.RewriteMods)
{
for (int i = 0; i < module.AssemblyReferences.Count; i++) for (int i = 0; i < module.AssemblyReferences.Count; i++)
{ {
// remove old assembly reference // remove old assembly reference
@ -311,6 +313,7 @@ namespace StardewModdingAPI.Framework.ModLoading
} }
} }
} }
}
// find or rewrite code // find or rewrite code
IInstructionHandler[] handlers = new InstructionMetadata().GetHandlers(this.ParanoidMode, platformChanged, this.RewriteMods).ToArray(); IInstructionHandler[] handlers = new InstructionMetadata().GetHandlers(this.ParanoidMode, platformChanged, this.RewriteMods).ToArray();