enable nullable annotations in SMAPI where no changes are needed (#837)

src/SMAPI/Context.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using StardewModdingAPI.Enums;
 using StardewModdingAPI.Events;

src/SMAPI/Events/AssetReadyEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/AssetsInvalidatedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;

src/SMAPI/Events/BuildingListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/ButtonPressedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Framework.Input;
 

src/SMAPI/Events/ButtonReleasedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Framework.Input;
 

src/SMAPI/Events/ButtonsChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/ChestInventoryChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using StardewValley;

src/SMAPI/Events/CursorMovedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/DebrisListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/FurnitureListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/IContentEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/IDisplayEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewValley;
 

src/SMAPI/Events/IGameLoopEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/IInputEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/IModEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Events
 {
     /// <summary>Manages access to events raised by SMAPI.</summary>

src/SMAPI/Events/IMultiplayerEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/IPlayerEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/ISpecialisedEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/IWorldEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/InventoryChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using StardewValley;

src/SMAPI/Events/ItemStackSizeChange.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using StardewValley;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/LargeTerrainFeatureListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/LevelChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Enums;
 using StardewValley;

src/SMAPI/Events/LocaleChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using LanguageCode = StardewValley.LocalizedContentManager.LanguageCode;
 

src/SMAPI/Events/LocationListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/NpcListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/ObjectListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/PeerConnectedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/PeerContextReceivedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/PeerDisconnectedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Events

src/SMAPI/Events/RenderedActiveMenuEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/RenderedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/RenderedHudEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/RenderedWorldEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/RenderingActiveMenuEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/RenderingEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/RenderingHudEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/RenderingWorldEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework.Graphics;
 using StardewValley;

src/SMAPI/Events/TerrainFeatureListChangedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Events/WarpedEventArgs.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewValley;
 

src/SMAPI/Framework/Commands/IInternalCommand.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework.Commands
 {
     /// <summary>A core SMAPI console command.</summary>

src/SMAPI/Framework/Commands/ReloadI18nCommand.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Framework.Commands

src/SMAPI/Framework/Content/AssetOperationGroup.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework.Content
 {
     /// <summary>A set of operations to apply to an asset for a given <see cref="IAssetEditor"/> or <see cref="IAssetLoader"/> implementation.</summary>

src/SMAPI/Framework/Content/TilesheetReference.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using xTile.Dimensions;
 
 namespace StardewModdingAPI.Framework.Content

src/SMAPI/Framework/DeprecationWarning.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework
 {
     /// <summary>A deprecation warning for a mod.</summary>

src/SMAPI/Framework/Events/EventManager.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using StardewModdingAPI.Events;
 
 namespace StardewModdingAPI.Framework.Events

src/SMAPI/Framework/Events/IManagedEvent.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework.Events
 {
     /// <summary>Metadata for an event raised by SMAPI.</summary>

src/SMAPI/Framework/Events/ModContentEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Events/ModDisplayEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Events/ModEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using StardewModdingAPI.Events;
 
 namespace StardewModdingAPI.Framework.Events

src/SMAPI/Framework/Events/ModEventsBase.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework.Events
 {
     /// <summary>An internal base class for event API classes.</summary>

src/SMAPI/Framework/Events/ModGameLoopEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Events/ModInputEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Events/ModMultiplayerEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Events/ModPlayerEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Events/ModSpecialisedEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Events/ModWorldEvents.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Events;
 

src/SMAPI/Framework/Exceptions/SAssemblyLoadFailedException.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Framework.Exceptions

src/SMAPI/Framework/Input/IInputStateBuilder.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 
 namespace StardewModdingAPI.Framework.Input

src/SMAPI/Framework/Input/KeyboardStateBuilder.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.Xna.Framework.Input;
@@ -29,7 +27,7 @@ namespace StardewModdingAPI.Framework.Input
             this.State = state;
 
             this.PressedButtons.Clear();
-            foreach (var button in state.GetPressedKeys())
+            foreach (Keys button in state.GetPressedKeys())
                 this.PressedButtons.Add(button);
         }
 

src/SMAPI/Framework/Input/MouseStateBuilder.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using Microsoft.Xna.Framework.Input;
 

src/SMAPI/Framework/ModHelpers/BaseHelper.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework.ModHelpers
 {
     /// <summary>The common base class for mod helpers.</summary>

src/SMAPI/Framework/ModHelpers/ContentPackHelper.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.IO;

src/SMAPI/Framework/ModHelpers/InputHelper.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewModdingAPI.Framework.Input;
 using StardewModdingAPI.Utilities;

src/SMAPI/Framework/ModHelpers/ModHelper.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.IO;
 using StardewModdingAPI.Events;

src/SMAPI/Framework/ModHelpers/TranslationHelper.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using StardewValley;
 

src/SMAPI/Framework/ModLinked.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework
 {
     /// <summary>A generic tuple which links something to a mod.</summary>

src/SMAPI/Framework/ModLoading/AssemblyLoadStatus.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework.ModLoading
 {
     /// <summary>Indicates the result of an assembly load.</summary>

src/SMAPI/Framework/ModLoading/IInstructionHandler.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using Mono.Cecil;

src/SMAPI/Framework/ModLoading/IncompatibleInstructionException.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Framework.ModLoading

src/SMAPI/Framework/ModLoading/PlatformAssemblyMap.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Framework/ModLoading/RewriteFacades/SpriteBatchFacade.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.Xna.Framework;
 using Microsoft.Xna.Framework.Graphics;
@@ -20,7 +18,8 @@ namespace StardewModdingAPI.Framework.ModLoading.RewriteFacades
         ** Public methods
         *********/
         /// <summary>Construct an instance.</summary>
-        public SpriteBatchFacade(GraphicsDevice graphicsDevice) : base(graphicsDevice) { }
+        public SpriteBatchFacade(GraphicsDevice graphicsDevice)
+            : base(graphicsDevice) { }
 
 
         /****

src/SMAPI/Framework/ModLoading/Rewriters/ArchitectureAssemblyRewriter.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using Mono.Cecil;
 using StardewModdingAPI.Framework.ModLoading.Framework;
 

src/SMAPI/Framework/ModLoading/Symbols/SymbolReader.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.IO;
 using Mono.Cecil;
 using Mono.Cecil.Cil;

src/SMAPI/Framework/ModLoading/Symbols/SymbolWriterProvider.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.IO;
 using Mono.Cecil;
 using Mono.Cecil.Cil;

src/SMAPI/Framework/Monitor.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SMAPI/Framework/Networking/SGalaxyNetClient.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Galaxy.Api;
 using StardewValley.Network;

src/SMAPI/Framework/Networking/SGalaxyNetServer.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Diagnostics.CodeAnalysis;
 using System.IO;

src/SMAPI/Framework/Networking/SLidgrenClient.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using StardewValley.Network;
 

src/SMAPI/Framework/Networking/SLidgrenServer.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Diagnostics.CodeAnalysis;
 using System.IO;

src/SMAPI/Framework/Reflection/InterfaceProxyFactory.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Reflection;
 using System.Reflection.Emit;
 using Nanoray.Pintail;

src/SMAPI/Framework/SChatBox.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using StardewValley;
 using StardewValley.Menus;
 

src/SMAPI/Framework/SGameRunner.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -150,7 +148,7 @@ namespace StardewModdingAPI.Framework
         /// <summary>Update metadata when a split screen is added or removed.</summary>
         private void UpdateForSplitScreenChanges()
         {
-            HashSet<int> oldScreenIds = new HashSet<int>(Context.ActiveScreenIds);
+            HashSet<int> oldScreenIds = new(Context.ActiveScreenIds);
 
             // track active screens
             Context.ActiveScreenIds.Clear();

src/SMAPI/Framework/Singleton.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework
 {
     /// <summary>Provides singleton instances of a given type.</summary>

src/SMAPI/Framework/StateTracking/FieldWatchers/BaseDisposableWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Framework.StateTracking.FieldWatchers

src/SMAPI/Framework/StateTracking/FieldWatchers/ComparableListWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using System.Linq;
 

src/SMAPI/Framework/StateTracking/FieldWatchers/ImmutableCollectionWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 

src/SMAPI/Framework/StateTracking/FieldWatchers/NetCollectionWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using Netcode;
 

src/SMAPI/Framework/StateTracking/FieldWatchers/NetListWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 using Netcode;
 using StardewModdingAPI.Framework.StateTracking.Comparers;

src/SMAPI/Framework/StateTracking/FieldWatchers/NetValueWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using Netcode;
 
 namespace StardewModdingAPI.Framework.StateTracking.FieldWatchers

src/SMAPI/Framework/StateTracking/ICollectionWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 
 namespace StardewModdingAPI.Framework.StateTracking

src/SMAPI/Framework/StateTracking/IDictionaryWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 
 namespace StardewModdingAPI.Framework.StateTracking

src/SMAPI/Framework/StateTracking/IValueWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 namespace StardewModdingAPI.Framework.StateTracking
 {
     /// <summary>A watcher which tracks changes to a value.</summary>

src/SMAPI/Framework/StateTracking/IWatcher.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 
 namespace StardewModdingAPI.Framework.StateTracking

src/SMAPI/Framework/Utilities/ContextHash.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using System.Collections.Generic;
 

src/SMAPI/GamePlatform.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using StardewModdingAPI.Toolkit.Utilities;
 
 namespace StardewModdingAPI

src/SMAPI/IAssetDataForDictionary.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System.Collections.Generic;
 
 namespace StardewModdingAPI

src/SMAPI/IAssetDataForImage.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using System;
 using Microsoft.Xna.Framework;
 using Microsoft.Xna.Framework.Graphics;

src/SMAPI/IAssetDataForMap.cs

@@ -1,5 +1,3 @@
-#nullable disable
-
 using Microsoft.Xna.Framework;
 using xTile;