StardewValley
/
SMAPI
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tweak message output and unit tests (#471)

This commit is contained in:
Jesse Plamondon-Willard 2018-04-09 23:25:10 -04:00
parent 416e1c3c1b
commit c8db771e11
2 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/SMAPI.ModBuildConfig.Analyzer.Tests/UnitTests.cs
View File

@ -34,7 +34,9 @@ namespace SMAPI.ModBuildConfig.Analyzer.Tests
{
class Item
{
public NetInt category { get; } = new NetInt { Value = 42 };
public NetInt category { get; } = new NetInt { Value = 42 }; // SMAPI002: use Category instead
public NetInt type { get; } = new NetInt { Value = 42 };
public NetRef refField { get; } = null;
}
}
@ -44,15 +46,13 @@ namespace SMAPI.ModBuildConfig.Analyzer.Tests
{
public void Entry()
{
NetInt intField = new NetInt { Value = 42 };
NetRef refField = new NetRef { Value = null };
Item item = null;
// this line should raise diagnostics
{{test-code}} // line 36
// these lines should not
if ((int)intField != 42);
if (item.type.Value != 42);
}
}
}
@ -85,14 +85,14 @@ namespace SMAPI.ModBuildConfig.Analyzer.Tests
/// <param name="expression">The expression which should be reported.</param>
/// <param name="fromType">The source type name which should be reported.</param>
/// <param name="toType">The target type name which should be reported.</param>
[TestCase("if (intField < 42);", 4, "intField", "NetInt", "Int32")]
[TestCase("if (intField <= 42);", 4, "intField", "NetInt", "Int32")]
[TestCase("if (intField > 42);", 4, "intField", "NetInt", "Int32")]
[TestCase("if (intField >= 42);", 4, "intField", "NetInt", "Int32")]
[TestCase("if (intField == 42);", 4, "intField", "NetInt", "Int32")]
[TestCase("if (intField != 42);", 4, "intField", "NetInt", "Int32")]
[TestCase("if (refField != null);", 4, "refField", "NetRef", "Object")]
[TestCase("if (item?.category != 42);", 4, "item?.category", "NetInt", "Int32")]
[TestCase("if (item.type < 42);", 4, "item.type", "NetInt", "int")]
[TestCase("if (item.type <= 42);", 4, "item.type", "NetInt", "int")]
[TestCase("if (item.type > 42);", 4, "item.type", "NetInt", "int")]
[TestCase("if (item.type >= 42);", 4, "item.type", "NetInt", "int")]
[TestCase("if (item.type == 42);", 4, "item.type", "NetInt", "int")]
[TestCase("if (item.type != 42);", 4, "item.type", "NetInt", "int")]
[TestCase("if (item.refField != null);", 4, "item.refField", "NetRef", "object")]
[TestCase("if (item?.type != 42);", 4, "item?.type", "NetInt", "int")]
public void AvoidImplicitNetFieldComparisons_RaisesDiagnostic(string codeText, int column, string expression, string fromType, string toType)
{
// arrange

4
src/SMAPI.ModBuildConfig.Analyzer/NetFieldAnalyzer.cs
View File

@ -246,9 +246,7 @@ namespace StardewModdingAPI.ModBuildConfig.Analyzer
TypeInfo operandType = context.SemanticModel.GetTypeInfo(operand);
if (this.IsNetType(operandType.Type) && !this.IsNetType(operandType.ConvertedType))
{
string fromTypeName = operandType.Type.Name;
string toTypeName = operandType.ConvertedType.Name;
context.ReportDiagnostic(Diagnostic.Create(this.Rules["SMAPI001"], context.Node.GetLocation(), operand, fromTypeName, toTypeName));
context.ReportDiagnostic(Diagnostic.Create(this.Rules["SMAPI001"], context.Node.GetLocation(), operand, operandType.Type.Name, operandType.ConvertedType));
return true;
}