StardewValley
/
SMAPI
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix assembly definition resolver not disposing loaded definitions

This commit is contained in:
Jesse Plamondon-Willard 2018-07-01 13:02:08 -04:00
parent 34c43f9f66
commit e548a4ea9b
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/SMAPI/Framework/ModLoading/AssemblyDefinitionResolver.cs
View File

@ -10,7 +10,7 @@ namespace StardewModdingAPI.Framework.ModLoading
** Properties ** Properties
*********/ *********/
/// <summary>The known assemblies.</summary> /// <summary>The known assemblies.</summary>
private readonly IDictionary<string, AssemblyDefinition> Loaded = new Dictionary<string, AssemblyDefinition>(); private readonly IDictionary<string, AssemblyDefinition> Lookup = new Dictionary<string, AssemblyDefinition>();
/********* /*********
@ -22,8 +22,9 @@ namespace StardewModdingAPI.Framework.ModLoading
{ {
foreach (AssemblyDefinition assembly in assemblies) foreach (AssemblyDefinition assembly in assemblies)
{ {
this.Loaded[assembly.Name.Name] = assembly; this.RegisterAssembly(assembly);
this.Loaded[assembly.Name.FullName] = assembly; this.Lookup[assembly.Name.Name] = assembly;
this.Lookup[assembly.Name.FullName] = assembly;
} }
} }
@ -44,8 +45,8 @@ namespace StardewModdingAPI.Framework.ModLoading
/// <param name="name">The assembly's short or full name.</param> /// <param name="name">The assembly's short or full name.</param>
private AssemblyDefinition ResolveName(string name) private AssemblyDefinition ResolveName(string name)
{ {
return this.Loaded.ContainsKey(name) return this.Lookup.TryGetValue(name, out AssemblyDefinition match)
? this.Loaded[name] ? match
: null; : null;
} }
} }