From f03b300b3fc4bcc9844e77e810dcf352a34b9232 Mon Sep 17 00:00:00 2001
From: Jesse Plamondon-Willard <github@jplamondonw.com>
Date: Sat, 13 May 2017 21:38:04 -0400
Subject: [PATCH] pass SMAPI version into metadata validation to simplify unit
 tests (#285)

---
 src/StardewModdingAPI/Framework/ModLoading/ModResolver.cs | 7 ++++---
 src/StardewModdingAPI/Program.cs                          | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/StardewModdingAPI/Framework/ModLoading/ModResolver.cs b/src/StardewModdingAPI/Framework/ModLoading/ModResolver.cs
index a3d4ce3e..e3f4fc12 100644
--- a/src/StardewModdingAPI/Framework/ModLoading/ModResolver.cs
+++ b/src/StardewModdingAPI/Framework/ModLoading/ModResolver.cs
@@ -75,7 +75,8 @@ namespace StardewModdingAPI.Framework.ModLoading
 
         /// <summary>Validate manifest metadata.</summary>
         /// <param name="mods">The mod manifests to validate.</param>
-        public void ValidateManifests(IEnumerable<IModMetadata> mods)
+        /// <param name="apiVersion">The current SMAPI version.</param>
+        public void ValidateManifests(IEnumerable<IModMetadata> mods, ISemanticVersion apiVersion)
         {
             foreach (IModMetadata mod in mods)
             {
@@ -108,10 +109,10 @@ namespace StardewModdingAPI.Framework.ModLoading
                 {
                     if (!SemanticVersion.TryParse(mod.Manifest.MinimumApiVersion, out ISemanticVersion minVersion))
                     {
-                        mod.SetStatus(ModMetadataStatus.Failed, $"it has an invalid minimum SMAPI version '{mod.Manifest.MinimumApiVersion}'. This should be a semantic version number like {Constants.ApiVersion}.");
+                        mod.SetStatus(ModMetadataStatus.Failed, $"it has an invalid minimum SMAPI version '{mod.Manifest.MinimumApiVersion}'. This should be a semantic version number like {apiVersion}.");
                         continue;
                     }
-                    if (minVersion.IsNewerThan(Constants.ApiVersion))
+                    if (minVersion.IsNewerThan(apiVersion))
                     {
                         mod.SetStatus(ModMetadataStatus.Failed, $"it needs SMAPI {minVersion} or later. Please update SMAPI to the latest version to use this mod.");
                         continue;
diff --git a/src/StardewModdingAPI/Program.cs b/src/StardewModdingAPI/Program.cs
index 9ccb4ddc..743de050 100644
--- a/src/StardewModdingAPI/Program.cs
+++ b/src/StardewModdingAPI/Program.cs
@@ -318,7 +318,7 @@ namespace StardewModdingAPI
 
                 // load manifests
                 IModMetadata[] mods = resolver.ReadManifests(Constants.ModPath, new JsonHelper(), this.Settings.ModCompatibility).ToArray();
-                resolver.ValidateManifests(mods);
+                resolver.ValidateManifests(mods, Constants.ApiVersion);
 
                 // check for deprecated metadata
                 IList<Action> deprecationWarnings = new List<Action>();