StardewValley
/
jsoneditor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a regression in `setValue`

This commit is contained in:
jos 2020-03-18 10:37:44 +01:00
parent 2316c87a46
commit 3363c2df8a
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/js/Node.js
View File

@ -414,7 +414,7 @@ export class Node {
* 'array', 'object', or 'string'
*/
setValue (value, type) {
let childValue, child, visible
let childValue, child
let i, j
const updateDom = false
const previousChilds = this.childs
@ -453,7 +453,7 @@ export class Node {
child = new Node(this.editor, {
value: childValue
})
visible = i < this.getMaxVisibleChilds()
const visible = i < this.getMaxVisibleChilds()
this.appendChild(child, visible, updateDom)
}
}
@ -493,7 +493,7 @@ export class Node {
// change the index of the property such that it matches the index of the updated JSON
if (childIndex !== i) {
this.moveBefore(child, this.childs[i])
this.moveBefore(child, this.childs[i], updateDom)
}
} else {
// create a new child
@ -501,7 +501,14 @@ export class Node {
field: childField,
value: childValue
})
this.insertBefore(child, this.childs[i], updateDom)
const beforeNode = this.childs[i]
if (beforeNode) {
this.insertBefore(child, this.childs[i], updateDom)
} else {
const visible = i < this.getMaxVisibleChilds()
this.appendChild(child, visible, updateDom)
}
}
}
i++