Gulp4 (#608)

* update for gulp 4.0.0

* added gulp 4.0.0

gulpfile.js

@@ -40,11 +40,9 @@ var compiler = webpack({
     path: DIST,
     filename: NAME + '.js'
   },
-  plugins: [ bannerPlugin ],
+  plugins: [bannerPlugin],
   module: {
-    loaders: [
-      { test: /\.json$/, loader: "json" }
-    ]
+    loaders: [{ test: /\.json$/, loader: 'json' }]
   },
   cache: true
 });
@@ -77,7 +75,7 @@ function minify(name) {
   });
 
   if (result.error) {
-    throw result.error
+    throw result.error;
   }
 
   var fileMin = DIST + '/' + name + '.min.js';
@@ -91,17 +89,20 @@ function minify(name) {
 }
 
 // make dist folder structure
-gulp.task('mkdir', function () {
+gulp.task('mkdir', function(done) {
   mkdirp.sync(DIST);
   mkdirp.sync(DIST + '/img');
+  done();
 });
 
 // bundle javascript
-gulp.task('bundle', ['mkdir'], function (done) {
+gulp.task(
+  'bundle',
+  gulp.series(gulp.parallel('mkdir'), function(done) {
     // update the banner contents (has a date in it which should stay up to date)
     bannerPlugin.banner = createBanner();
 
-  compiler.run(function (err, stats) {
+    compiler.run(function(err, stats) {
       if (err) {
         gutil.log(err);
       }
@@ -110,14 +111,17 @@ gulp.task('bundle', ['mkdir'], function (done) {
 
       done();
     });
-});
+  })
+);
 
 // bundle minimalist version of javascript
-gulp.task('bundle-minimalist', ['mkdir'], function (done) {
+gulp.task(
+  'bundle-minimalist',
+  gulp.series(gulp.parallel('mkdir'), function(done) {
     // update the banner contents (has a date in it which should stay up to date)
     bannerPlugin.banner = createBanner();
 
-  compilerMinimalist.run(function (err, stats) {
+    compilerMinimalist.run(function(err, stats) {
       if (err) {
         gutil.log(err);
       }
@@ -126,11 +130,15 @@ gulp.task('bundle-minimalist', ['mkdir'], function (done) {
 
       done();
     });
-});
+  })
+);
 
 // bundle css
-gulp.task('bundle-css', ['mkdir'], function () {
-  gulp.src([
+gulp.task(
+  'bundle-css',
+  gulp.series(gulp.parallel('mkdir'), function(done) {
+    gulp
+      .src([
         'src/css/reset.css',
         'src/css/jsoneditor.css',
         'src/css/contextmenu.css',
@@ -150,45 +158,73 @@ gulp.task('bundle-css', ['mkdir'], function () {
 
     gutil.log('bundled ' + DIST + '/' + NAME + '.css');
     gutil.log('bundled ' + DIST + '/' + NAME + '.min.css');
-});
+    done();
+  })
+);
 
 // create a folder img and copy the icons
-gulp.task('copy-img', ['mkdir'], function () {
-  gulp.src(IMAGE)
-      .pipe(gulp.dest(DIST + '/img'));
+gulp.task(
+  'copy-img',
+  gulp.series(gulp.parallel('mkdir'), function(done) {
+    gulp.src(IMAGE).pipe(gulp.dest(DIST + '/img'));
     gutil.log('Copied images');
-});
+    done();
+  })
+);
 
 // create a folder img and copy the icons
-gulp.task('copy-docs', ['mkdir'], function () {
-  gulp.src(DOCS)
-      .pipe(gulp.dest(DIST));
+gulp.task(
+  'copy-docs',
+  gulp.series(gulp.parallel('mkdir'), function(done) {
+    gulp.src(DOCS).pipe(gulp.dest(DIST));
     gutil.log('Copied doc');
-});
+    done();
+  })
+);
 
-gulp.task('minify', ['bundle'], function () {
-  minify(NAME)
-});
+gulp.task(
+  'minify',
+  gulp.series(gulp.parallel('bundle'), function(done) {
+    minify(NAME);
+    done();
+  })
+);
 
-gulp.task('minify-minimalist', ['bundle-minimalist'], function () {
-  minify(NAME_MINIMALIST)
-});
+gulp.task(
+  'minify-minimalist',
+  gulp.series(gulp.parallel('bundle-minimalist'), function(done) {
+    minify(NAME_MINIMALIST);
+    done();
+  })
+);
 
 // TODO: zip file using archiver
 var pkg = 'jsoneditor-' + require('./package.json').version + '.zip';
-gulp.task('zip', shell.task([
-      'zip ' + pkg + ' ' + 'README.md NOTICE LICENSE HISTORY.md index.html src dist docs examples -r '
-]));
+gulp.task(
+  'zip',
+  shell.task([
+    'zip ' +
+      pkg +
+      ' ' +
+      'README.md NOTICE LICENSE HISTORY.md index.html src dist docs examples -r '
+  ])
+);
 
 // The watch task (to automatically rebuild when the source code changes)
 // Does only generate jsoneditor.js and jsoneditor.css, and copy the image
 // Does NOT minify the code and does NOT generate the minimalist version
-gulp.task('watch', ['bundle', 'bundle-css', 'copy-img'], function () {
-  gulp.watch(['src/**/*'], ['bundle', 'bundle-css', 'copy-img']);
-});
+gulp.task(
+  'watch',
+  gulp.series(gulp.parallel('bundle', 'bundle-css', 'copy-img'), function() {
+    gulp.watch(['src/**/*'], gulp.series('bundle', 'bundle-css', 'copy-img'));
+  })
+);
 
 // The default task (called when you run `gulp`)
-gulp.task('default', [
+gulp.task(
+  'default',
+  gulp.series(
+    gulp.parallel(
       'bundle',
       'bundle-minimalist',
       'bundle-css',
@@ -196,4 +232,6 @@ gulp.task('default', [
       'copy-docs',
       'minify',
       'minify-minimalist'
-]);
+    )
+  )
+);

package.json

@@ -33,7 +33,7 @@
     "vanilla-picker": "2.4.2"
   },
   "devDependencies": {
-    "gulp": "3.9.1",
+    "gulp": "4.0.0",
     "gulp-clean-css": "3.4.2",
     "gulp-concat-css": "2.3.0",
     "gulp-shell": "0.6.3",