Merge pull request #510 from crispthinking/parent-error-cache

cache parent errors

src/js/treemode.js

@@ -435,28 +435,35 @@ treemode.validate = function () {
     }
   }
 
-  // display the error in the nodes with a problem
+  var errorNodes = duplicateErrors.concat(schemaErrors);
-  this.errorNodes = duplicateErrors
+  var parentPairs = errorNodes
-      .concat(schemaErrors)
+      .reduce(function (all, entry) {
-      .reduce(function expandParents (all, entry) {
-        // expand parents, then merge such that parents come first and
-        // original entries last
           return entry.node
               .findParents()
+              .filter(function (parent) {
+                  return !all.some(function (pair) {
+                    return pair[0] === parent;
+                  });
+              })
               .map(function (parent) {
+                  return [parent, entry.node];
+              })
+              .concat(all);
+      }, []);
+
+  this.errorNodes = parentPairs
+      .map(function (pair) {
           return {
-                node: parent,
+            node: pair[0],
-                child: entry.node,
+            child: pair[1],
             error: {
-                  message: parent.type === 'object'
+              message: pair[0].type === 'object'
                   ? 'Contains invalid properties' // object
                   : 'Contains invalid items'      // array
             }
           };
       })
-            .concat(all, [entry]);
+      .concat(errorNodes)
-      }, [])
-      // TODO: dedupe the parent nodes
       .map(function setError (entry) {
         entry.node.setError(entry.error, entry.child);
         return entry.node;