Revert reckoning with the order of object properties when updating an object. See #917

HISTORY.md

@@ -6,6 +6,8 @@ https://github.com/josdejong/jsoneditor
 
 - Fix #921: `sortObjectKeys` emits `onChange` events.
 - Fix #946: `language` not working in modes `text`, `code`, and `preview`.
+- Revert reckoning with the order of object properties when updating an
+  object (introduced in `v8.6.2`). See #917. 
 - Implement support for repairing line separate JSON. 
 
 

src/js/Node.js

@@ -483,32 +483,19 @@ export class Node {
         if (hasOwnProperty(value, childField)) {
           childValue = value[childField]
           if (childValue !== undefined && !(childValue instanceof Function)) {
-            const childIndex = this.childs.findIndex(child => child.field === childField)
+            const child = this.findChildByProperty(childField)
-            child = this.childs[childIndex]
-
             if (child) {
               // reuse existing child, keep its state
               child.setField(childField, true)
               child.setValue(childValue)
-
-              // change the index of the property such that it matches the index of the updated JSON
-              if (childIndex !== i) {
-                this.moveBefore(child, this.childs[i], updateDom)
-              }
             } else {
-              // create a new child
+              // create a new child, append to the end
-              child = new Node(this.editor, {
+              const newChild = new Node(this.editor, {
                 field: childField,
                 value: childValue
               })
-
+              const visible = i < this.getMaxVisibleChilds()
-              const beforeNode = this.childs[i]
+              this.appendChild(newChild, visible, updateDom)
-              if (beforeNode) {
-                this.insertBefore(child, this.childs[i], updateDom)
-              } else {
-                const visible = i < this.getMaxVisibleChilds()
-                this.appendChild(child, visible, updateDom)
-              }
             }
           }
           i++