From 243c780a6a22e1af7aa3a23ee4a3964effed485f Mon Sep 17 00:00:00 2001
From: Isaac Connor <isaac@zoneminder.com>
Date: Wed, 16 Feb 2022 14:16:25 -0500
Subject: [PATCH] cleanup and add fallback to read/write if no sendfile
 support.

---
 src/zm_sendfile.h | 51 +++++++++++++++++++++++++++--------------------
 1 file changed, 29 insertions(+), 22 deletions(-)

diff --git a/src/zm_sendfile.h b/src/zm_sendfile.h
index 3568e2fea..4edabccab 100644
--- a/src/zm_sendfile.h
+++ b/src/zm_sendfile.h
@@ -3,37 +3,44 @@
 
 #ifdef HAVE_SENDFILE4_SUPPORT
 #include <sys/sendfile.h>
-ssize_t zm_sendfile(int out_fd, int in_fd, off_t *offset, size_t size) {
-  size_t remaining = size;
-  while (remaining) {
-    ssize_t err = sendfile(out_fd, in_fd, offset, remaining);
-    if (err < 0) {
-      return -errno;
-    }
-    remaining -= err;
-    offset += err;
-  }
-
-  return size-remaining;
-}
 #elif HAVE_SENDFILE7_SUPPORT
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/uio.h>
-ssize_t zm_sendfile(int out_fd, int in_fd, off_t *offset, off_t size) {
+#else
+#include <unistd.h>
+#endif
+
+/* Function to send the contents of a file. Will use sendfile or fall back to reading/writing */
+
+ssize_t zm_sendfile(int out_fd, int in_fd, off_t *offset, size_t size) {
+#ifdef HAVE_SENDFILE4_SUPPORT
+  ssize_t err = sendfile(out_fd, in_fd, offset, size);
+  if (err < 0) {
+    return -errno;
+  }
+  return err;
+
+#elif HAVE_SENDFILE7_SUPPORT
   ssize_t err = sendfile(in_fd, out_fd, *offset, size, nullptr, &size, 0);
   if (err && errno != EAGAIN)
     return -errno;
-
-  if (size) {
-    *offset += size;
-    return size;
+  return size;
+#else
+  uint8_t buffer[size];
+  ssize_t err = read(in_fd, buffer, size);
+  if (err < 0) {
+    Error("Unable to read %zu bytes: %s", size, strerror(errno));
+    return -errno;
   }
 
-  return -EAGAIN;
-}
-#else
-#error "Your platform does not support sendfile. Sorry."
+  err = fwrite(out_fd, buffer, size);
+  if (err < 0) {
+    Error("Unable to write %zu bytes: %s", size, strerror(errno));
+    return -errno;
+  }
+  return err;
 #endif
+}
 
 #endif // ZM_SENDFILE_H