diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9fa993e97..559ad2bdc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -66,12 +66,23 @@ set(CMAKE_CXX_FLAGS_DEBUG "-Wall -D__STDC_CONSTANT_MACROS -g")
set(CMAKE_INCLUDE_CURRENT_DIR ON)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/Modules/")
-IF(${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm")
-add_definitions (-mfpu=neon)
-ELSE(${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm")
-
-ENDIF(${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm")
-
+# GCC below 6.0 doesn't support __target__("fpu=neon") attribute, required for compiling ARM Neon code, otherwise compilation fails.
+# Must use -mfpu=neon compiler flag instead, but only do that for processors that support neon, otherwise strip the neon code alltogether,
+# because passing -fmpu=neon is unsafe to processors that don't support neon
+IF(CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" AND CMAKE_SYSTEM_NAME MATCHES "Linux")
+ IF(CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 6.0)
+ EXEC_PROGRAM(grep ARGS " neon " "/proc/cpuinfo" OUTPUT_VARIABLE neonoutput RETURN_VALUE neonresult)
+ IF(neonresult EQUAL 0)
+ set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -mfpu=neon")
+ set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -mfpu=neon")
+ set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -mfpu=neon")
+ set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -mfpu=neon")
+ ELSE(neonresult EQUAL 0)
+ add_definitions(-DZM_STRIP_NEON=1)
+ message(STATUS "ARM Neon is not available on this processor. Neon functions will be absent")
+ ENDIF(neonresult EQUAL 0)
+ ENDIF(CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 6.0)
+ENDIF(CMAKE_SYSTEM_PROCESSOR MATCHES "^arm" AND CMAKE_SYSTEM_NAME MATCHES "Linux")
# Modules that we need:
include (GNUInstallDirs)
diff --git a/distros/redhat/systemd/zoneminder.tmpfiles.in b/distros/redhat/systemd/zoneminder.tmpfiles.in
index f3acd0af7..910c360f1 100644
--- a/distros/redhat/systemd/zoneminder.tmpfiles.in
+++ b/distros/redhat/systemd/zoneminder.tmpfiles.in
@@ -1,2 +1,7 @@
D @ZM_TMPDIR@ 0755 @WEB_USER@ @WEB_GROUP@
+D @ZM_TMPDIR@/logs 0755 @WEB_USER@ @WEB_GROUP@
+D @ZM_TMPDIR@/cache 0755 @WEB_USER@ @WEB_GROUP@
+D @ZM_TMPDIR@/cache/models 0755 @WEB_USER@ @WEB_GROUP@
+D @ZM_TMPDIR@/cache/persistent 0755 @WEB_USER@ @WEB_GROUP@
+D @ZM_TMPDIR@/cache/views 0755 @WEB_USER@ @WEB_GROUP@
D @ZM_SOCKDIR@ 0755 @WEB_USER@ @WEB_GROUP@
diff --git a/distros/redhat/zoneminder.spec b/distros/redhat/zoneminder.spec
index f562b1159..0ed6323f0 100644
--- a/distros/redhat/zoneminder.spec
+++ b/distros/redhat/zoneminder.spec
@@ -29,7 +29,7 @@
Name: zoneminder
Version: 1.30.2
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: A camera monitoring and analysis tool
Group: System Environment/Daemons
# jscalendar is LGPL (any version): http://www.dynarch.com/projects/calendar/
@@ -39,7 +39,7 @@ Group: System Environment/Daemons
License: GPLv2+ and LGPLv2+ and MIT
URL: http://www.zoneminder.com/
-Source0: https://github.com/ZoneMinder/ZoneMinder/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
+Source0: https://github.com/ZoneMinder/ZoneMinder/archive/%{version}.tar.gz#/zoneminder-%{version}.tar.gz
Source1: https://github.com/FriendsOfCake/crud/archive/v%{crud_version}.tar.gz#/crud-%{crud_version}.tar.gz
%{?with_init_systemd:BuildRequires: systemd-devel}
@@ -130,8 +130,8 @@ designed to support as many cameras as you can attach to your computer without
too much degradation of performance.
%prep
-%autosetup
-%autosetup -a 1
+%autosetup -n ZoneMinder-%{version}
+%autosetup -a 1 -n ZoneMinder-%{version}
rmdir ./web/api/app/Plugin/Crud
mv -f crud-%{crud_version} ./web/api/app/Plugin/Crud
@@ -336,8 +336,11 @@ rm -rf %{_docdir}/%{name}-%{version}
%dir %attr(755,%{zmuid_final},%{zmgid_final}) %ghost %{_localstatedir}/run/zoneminder
%changelog
+* Thu Mar 30 2017 Andrew Bauer - 1.30.2-2
+- 1.30.2 release
+
* Wed Feb 08 2017 Andrew Bauer - 1.30.2-1
-- Bump version for 1.30.2 release
+- Bump version for 1.30.2 release candidate 1
* Wed Dec 28 2016 Andrew Bauer - 1.30.1-2
- Changes from rpmfusion #4393
diff --git a/distros/ubuntu1604/control b/distros/ubuntu1604/control
index bc8061a60..2c4fd3b95 100644
--- a/distros/ubuntu1604/control
+++ b/distros/ubuntu1604/control
@@ -37,7 +37,7 @@ Package: zoneminder
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, ${perl:Depends}
,javascript-common
- ,libmp4v2-2, libx264-142|libx264-148, libswscale-ffmpeg3|libswscale4
+ ,libmp4v2-2, libx264-142|libx264-148, libswscale-ffmpeg3|libswscale4|libswscale3
,ffmpeg | libav-tools
,libdate-manip-perl, libmime-lite-perl, libmime-tools-perl
,libdbd-mysql-perl
diff --git a/distros/ubuntu1604/zoneminder.links b/distros/ubuntu1604/zoneminder.links
index 4299f392a..14a8aee91 100644
--- a/distros/ubuntu1604/zoneminder.links
+++ b/distros/ubuntu1604/zoneminder.links
@@ -1,3 +1,4 @@
/var/cache/zoneminder/events /usr/share/zoneminder/www/events
/var/cache/zoneminder/images /usr/share/zoneminder/www/images
/var/cache/zoneminder/temp /usr/share/zoneminder/www/temp
+/var/tmp /usr/share/zoneminder/www/api/app/tmp
diff --git a/distros/ubuntu1604/zoneminder.tmpfile b/distros/ubuntu1604/zoneminder.tmpfile
index d307c6640..a7333ec19 100644
--- a/distros/ubuntu1604/zoneminder.tmpfile
+++ b/distros/ubuntu1604/zoneminder.tmpfile
@@ -1,2 +1,6 @@
-d /var/run/zm 0755 www-data www-data
-d /tmp/zm 0755 www-data www-data
+d /var/run/zm 0755 www-data www-data
+d /tmp/zm 0755 www-data www-data
+d /var/tmp/zm 0755 www-data www-data
+d /var/tmp/cache 0755 www-data www-data
+d /var/tmp/cache/models 0755 www-data www-data
+d /var/tmp/cache/persistent 0755 www-data www-data
diff --git a/misc/zoneminder.service.in b/misc/zoneminder.service.in
index d15c479c2..d1cfb36a0 100644
--- a/misc/zoneminder.service.in
+++ b/misc/zoneminder.service.in
@@ -12,7 +12,7 @@ Type=forking
ExecStart=@BINDIR@/zmpkg.pl start
ExecReload=@BINDIR@/zmpkg.pl restart
ExecStop=@BINDIR@/zmpkg.pl stop
-PIDFile="@ZM_RUNDIR@/zm.pid"
+PIDFile=@ZM_RUNDIR@/zm.pid
Environment=TZ=:/etc/localtime
[Install]
diff --git a/scripts/ZoneMinder/lib/ZoneMinder/ConfigData.pm.in b/scripts/ZoneMinder/lib/ZoneMinder/ConfigData.pm.in
index 4dd136657..d6ff8b2d9 100644
--- a/scripts/ZoneMinder/lib/ZoneMinder/ConfigData.pm.in
+++ b/scripts/ZoneMinder/lib/ZoneMinder/ConfigData.pm.in
@@ -354,6 +354,26 @@ our @options = (
type => $types{boolean},
category => 'system',
},
+ {
+ name => 'ZM_ENABLE_CSRF_MAGIC',
+ default => 'no',
+ description => 'Enable csrf-magic library',
+ help => q`
+ CSRF stands for Cross-Site Request Forgery which, under specific
+ circumstances, can allow an attacker to perform any task your
+ ZoneMinder user account has permission to perform. To accomplish
+ this, the attacker must write a very specific web page and get
+ you to navigate to it, while you are logged into the ZoneMinder
+ web console at the same time. Enabling ZM_ENABLE_CSRF_MAGIC will
+ help mitigate these kinds of attackes. Be warned this feature
+ is experimental and may cause problems, particularly with the API.
+ If you find a false positive and can document how to reproduce it,
+ then please report it. This feature defaults to OFF currently due to
+ its experimental nature.
+ `,
+ type => $types{boolean},
+ category => 'system',
+ },
{
name => 'ZM_OPT_USE_API',
default => 'yes',
diff --git a/scripts/ZoneMinder/lib/ZoneMinder/Event.pm b/scripts/ZoneMinder/lib/ZoneMinder/Event.pm
index 4a0b4f427..9d984adf3 100644
--- a/scripts/ZoneMinder/lib/ZoneMinder/Event.pm
+++ b/scripts/ZoneMinder/lib/ZoneMinder/Event.pm
@@ -241,6 +241,7 @@ sub GenerateVideo {
sub delete {
my $event = $_[0];
Info( "Deleting event $event->{Id} from Monitor $event->{MonitorId} $event->{StartTime}\n" );
+ $ZoneMinder::Database::dbh->ping();
# Do it individually to avoid locking up the table for new events
my $sql = 'delete from Events where Id = ?';
my $sth = $ZoneMinder::Database::dbh->prepare_cached( $sql )
@@ -331,12 +332,15 @@ sub delete_files {
sub Storage {
return new ZoneMinder::Storage( $_[0]{StorageId} );
}
+
sub check_for_in_filesystem {
my $path = $_[0]->Path();
if ( $path ) {
my @files = glob( $path . '/*' );
+Debug("Checking for files for event $_[0]{Id} at $path using glob $path/* found " . scalar @files . " files");
return 1 if @files;
}
+Debug("Checking for files for event $_[0]{Id} at $path using glob $path/* found no files");
return 0;
}
diff --git a/scripts/ZoneMinder/lib/ZoneMinder/Filter.pm b/scripts/ZoneMinder/lib/ZoneMinder/Filter.pm
index 49636ebe7..1f4259c6b 100644
--- a/scripts/ZoneMinder/lib/ZoneMinder/Filter.pm
+++ b/scripts/ZoneMinder/lib/ZoneMinder/Filter.pm
@@ -254,14 +254,14 @@ sub Sql {
} # end if terms
if ( $self->{Sql} ) {
- if ( $self->{AutoMessage} ) {
+ #if ( $self->{AutoMessage} ) {
# Include all events, including events that are still ongoing
# and have no EndTime yet
$sql .= " and ( ".$self->{Sql}." )";
- } else {
+ #} else {
# Only include closed events (events with valid EndTime)
- $sql .= " where not isnull(E.EndTime) and ( ".$self->{Sql}." )";
- }
+ #$sql .= " where not isnull(E.EndTime) and ( ".$self->{Sql}." )";
+ #}
}
my @auto_terms;
if ( $self->{AutoArchive} ) {
diff --git a/scripts/ZoneMinder/lib/ZoneMinder/General.pm b/scripts/ZoneMinder/lib/ZoneMinder/General.pm
index 8cb4428e6..743cc67e4 100644
--- a/scripts/ZoneMinder/lib/ZoneMinder/General.pm
+++ b/scripts/ZoneMinder/lib/ZoneMinder/General.pm
@@ -179,7 +179,7 @@ sub runCommand {
sub getEventPath {
my $event = shift;
- my $Storage = new ZoneMinder::Storage( $$event{Id} );
+ my $Storage = new ZoneMinder::Storage( $$event{StorageId} );
my $event_path = join( '/',
$Storage->Path(),
$event->{MonitorId},
diff --git a/scripts/ZoneMinder/lib/ZoneMinder/ONVIF.pm.in b/scripts/ZoneMinder/lib/ZoneMinder/ONVIF.pm.in
new file mode 100644
index 000000000..3b295c45f
--- /dev/null
+++ b/scripts/ZoneMinder/lib/ZoneMinder/ONVIF.pm.in
@@ -0,0 +1,358 @@
+# ==========================================================================
+#
+# ZoneMinder ONVIF Module, $Date$, $Revision$
+# Copyright (C) 2001-2008 Philip Coombes
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# ==========================================================================
+#
+# This module contains the common definitions and functions used by the rest
+# of the ZoneMinder scripts
+#
+package ZoneMinder::ONVIF;
+
+use 5.006;
+use strict;
+use warnings;
+
+require Exporter;
+require ZoneMinder::Base;
+
+our @ISA = qw(Exporter);
+
+our %EXPORT_TAGS = (
+ functions => [ qw(
+ ) ]
+ );
+push( @{$EXPORT_TAGS{all}}, @{$EXPORT_TAGS{$_}} ) foreach keys %EXPORT_TAGS;
+
+our @EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
+
+our @EXPORT = qw();
+
+our $VERSION = $ZoneMinder::Base::VERSION;
+
+use Getopt::Std;
+use Data::UUID;
+
+require ONVIF::Client;
+
+require WSDiscovery10::Interfaces::WSDiscovery::WSDiscoveryPort;
+require WSDiscovery10::Elements::Header;
+require WSDiscovery10::Elements::Types;
+require WSDiscovery10::Elements::Scopes;
+
+require WSDiscovery::TransportUDP;
+
+sub deserialize_message {
+ my ($wsdl_client, $response) = @_;
+
+# copied and adapted from SOAP::WSDL::Client
+
+# get deserializer
+ my $deserializer = $wsdl_client->get_deserializer();
+
+ if(! $deserializer) {
+ $deserializer = SOAP::WSDL::Factory::Deserializer->get_deserializer({
+ soap_version => $wsdl_client->get_soap_version(),
+ %{ $wsdl_client->get_deserializer_args() },
+ });
+ }
+# set class resolver if serializer supports it
+ $deserializer->set_class_resolver( $wsdl_client->get_class_resolver() )
+ if ( $deserializer->can('set_class_resolver') );
+
+# Try deserializing response - there may be some,
+# even if transport did not succeed (got a 500 response)
+ if ( $response ) {
+# as our faults are false, returning a success marker is the only
+# reliable way of determining whether the deserializer succeeded.
+# Custom deserializers may return an empty list, or undef,
+# and $@ is not guaranteed to be undefined.
+ my ($success, $result_body, $result_header) = eval {
+ (1, $deserializer->deserialize( $response ));
+ };
+ if (defined $success) {
+ return wantarray
+ ? ($result_body, $result_header)
+ : $result_body;
+ }
+ elsif (blessed $@) { #}&& $@->isa('SOAP::WSDL::SOAP::Typelib::Fault11')) {
+ return $@;
+ }
+ else {
+ return $deserializer->generate_fault({
+ code => 'soap:Server',
+ role => 'urn:localhost',
+ message => "Error deserializing message: $@. \n"
+ . "Message was: \n$response"
+ });
+ }
+ };
+}
+ub interpret_messages {
+ my ($svc_discover, $services, @responses ) = @_;
+
+ my @results;
+ foreach my $response ( @responses ) {
+
+ if($verbose) {
+ print "Received message:\n" . $response . "\n";
+ }
+
+ my $result = deserialize_message($svc_discover, $response);
+ if(not $result) {
+ print "Error deserializing message. No message returned from deserializer.\n" if $verbose;
+ next;
+ }
+
+ my $xaddr;
+ foreach my $l_xaddr (split ' ', $result->get_ProbeMatch()->get_XAddrs()) {
+# find IPv4 address
+ print "l_xaddr = $l_xaddr\n" if $verbose;
+ if($l_xaddr =~ m|//[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+[:/]|) {
+ $xaddr = $l_xaddr;
+ last;
+ } else {
+ print STDERR "Unable to find IPv4 address from xaddr $l_xaddr\n";
+ }
+ }
+
+# No usable address found
+ next if not $xaddr;
+
+# ignore multiple responses from one service
+ next if defined $services->{$xaddr};
+ $services->{$xaddr} = 1;
+
+ print "$xaddr, " . $svc_discover->get_soap_version() . ", ";
+
+ print "(";
+ my $scopes = $result->get_ProbeMatch()->get_Scopes();
+ my $count = 0;
+ my %scopes;
+ foreach my $scope(split ' ', $scopes) {
+ if($scope =~ m|onvif://www\.onvif\.org/(.+)/(.*)|) {
+ my ($attr, $value) = ($1,$2);
+ if( 0 < $count ++) {
+ print ", ";
+ }
+ print $attr . "=\'" . $value . "\'";
+ $scopes{$attr} = $value;
+ }
+ }
+ print ")\n";
+ push @results, { xaddr=>$xaddr,
+ soap_version => $svc_discover->get_soap_version(),
+ scopes => \%scopes,
+ };
+
+ }
+ return @results;
+} # end sub interpret_messages
+
+# functions
+
+sub discover {
+ my @results;
+
+## collect all responses
+ my @responses = ();
+
+ no warnings 'redefine';
+
+ *WSDiscovery::TransportUDP::_notify_response = sub {
+ my ($transport, $response) = @_;
+ push @responses, $response;
+ };
+
+## try both soap versions
+ my %services;
+
+ my $uuid_gen = Data::UUID->new();
+
+ if ( ( ! $soap_version ) or ( $soap_version eq '1.1' ) ) {
+
+ if($verbose) {
+ print "Probing for SOAP 1.1\n"
+ }
+ my $svc_discover = WSDiscovery10::Interfaces::WSDiscovery::WSDiscoveryPort->new({
+# no_dispatch => '1',
+ });
+ $svc_discover->set_soap_version('1.1');
+
+ my $uuid = $uuid_gen->create_str();
+
+ my $result = $svc_discover->ProbeOp(
+ { # WSDiscovery::Types::ProbeType
+ Types => 'http://www.onvif.org/ver10/network/wsdl:NetworkVideoTransmitter http://www.onvif.org/ver10/device/wsdl:Device', # QNameListType
+ Scopes => { value => '' },
+ },
+ WSDiscovery10::Elements::Header->new({
+ Action => { value => 'http://schemas.xmlsoap.org/ws/2005/04/discovery/Probe' },
+ MessageID => { value => "urn:uuid:$uuid" },
+ To => { value => 'urn:schemas-xmlsoap-org:ws:2005:04:discovery' },
+ })
+ );
+ print $result . "\n" if $verbose;
+
+ push @results, interpret_messages($svc_discover, \%services, @responses);
+ @responses = ();
+ } # end if doing soap 1.1
+
+ if ( ( ! $soap_version ) or ( $soap_version eq '1.2' ) ) {
+ if($verbose) {
+ print "Probing for SOAP 1.2\n"
+ }
+ my $svc_discover = WSDiscovery10::Interfaces::WSDiscovery::WSDiscoveryPort->new({
+# no_dispatch => '1',
+ });
+ $svc_discover->set_soap_version('1.2');
+
+# copies of the same Probe message must have the same MessageID.
+# This is not a copy. So we generate a new uuid.
+ my $uuid = $uuid_gen->create_str();
+
+# Everyone else, like the nodejs onvif code and odm only ask for NetworkVideoTransmitter
+ my $result = $svc_discover->ProbeOp(
+ { # WSDiscovery::Types::ProbeType
+ xmlattr => { 'xmlns:dn' => 'http://www.onvif.org/ver10/network/wsdl', },
+ Types => 'dn:NetworkVideoTransmitter', # QNameListType
+ Scopes => { value => '' },
+ },
+ WSDiscovery10::Elements::Header->new({
+ Action => { value => 'http://schemas.xmlsoap.org/ws/2005/04/discovery/Probe' },
+ MessageID => { value => "urn:uuid:$uuid" },
+ To => { value => 'urn:schemas-xmlsoap-org:ws:2005:04:discovery' },
+ })
+ );
+ print $result . "\n" if $verbose;
+ push @results, interpret_messages($svc_discover, \%services, @responses);
+ } # end if doing soap 1.2
+ return @results;
+}
+
+sub profiles {
+ my $result = $client->get_endpoint('media')->GetProfiles( { } ,, );
+ die $result if not $result;
+ if($verbose) {
+ print "Received message:\n" . $result . "\n";
+ }
+
+ my $profiles = $result->get_Profiles();
+
+ foreach my $profile ( @{ $profiles } ) {
+
+ my $token = $profile->attr()->get_token() ;
+ print $token . ", " .
+ $profile->get_Name() . ", " .
+ $profile->get_VideoEncoderConfiguration()->get_Encoding() . ", " .
+ $profile->get_VideoEncoderConfiguration()->get_Resolution()->get_Width() . ", " .
+ $profile->get_VideoEncoderConfiguration()->get_Resolution()->get_Height() . ", " .
+ $profile->get_VideoEncoderConfiguration()->get_RateControl()->get_FrameRateLimit() .
+ ", ";
+
+# Specification gives conflicting values for unicast stream types, try both.
+# http://www.onvif.org/onvif/ver10/media/wsdl/media.wsdl#op.GetStreamUri
+ foreach my $streamtype ( 'RTP_unicast', 'RTP-Unicast' ) {
+ $result = $client->get_endpoint('media')->GetStreamUri( {
+ StreamSetup => { # ONVIF::Media::Types::StreamSetup
+ Stream => $streamtype, # StreamType
+ Transport => { # ONVIF::Media::Types::Transport
+ Protocol => 'RTSP', # TransportProtocol
+ },
+ },
+ ProfileToken => $token, # ReferenceToken
+ } ,, );
+ last if $result;
+ }
+ die $result if not $result;
+# print $result . "\n";
+
+ print $result->get_MediaUri()->get_Uri() .
+ "\n";
+ } # end foreach profile
+
+#
+# use message parser without schema validation ???
+#
+
+}
+
+sub move {
+ my ($dir) = @_;
+
+ my $result = $client->get_endpoint('ptz')->GetNodes( { } ,, );
+
+ die $result if not $result;
+ print $result . "\n";
+} # end sub move
+
+sub metadata {
+ my $result = $client->get_endpoint('media')->GetMetadataConfigurations( { } ,, );
+ die $result if not $result;
+ print $result . "\n";
+
+ $result = $client->get_endpoint('media')->GetVideoAnalyticsConfigurations( { } ,, );
+ die $result if not $result;
+ print $result . "\n";
+
+# $result = $client->get_endpoint('analytics')->GetServiceCapabilities( { } ,, );
+# die $result if not $result;
+# print $result . "\n";
+
+}
+
+
+
+1;
+__END__
+
+=head1 NAME
+
+ZoneMinder::ONVIF - perl module to access onvif functions for ZoneMinder
+
+=head1 SYNOPSIS
+
+use ZoneMinder::ONVIF;
+
+=head1 DESCRIPTION
+
+This is a module to contain useful functions and import all the other modules
+required for ONVIF to work.
+
+=head2 EXPORT
+
+None by default.
+
+=head1 SEE ALSO
+
+http://www.zoneminder.com
+
+=head1 AUTHOR
+
+Philip Coombes, Ephilip.coombes@zoneminder.comE
+
+=head1 COPYRIGHT AND LICENSE
+
+Copyright (C) 2001-2008 Philip Coombes
+
+This library is free software; you can redistribute it and/or modify
+it under the same terms as Perl itself, either Perl version 5.8.3 or,
+at your option, any later version of Perl 5 you may have available.
+
+
+=cut
diff --git a/scripts/ZoneMinder/lib/ZoneMinder/Object.pm b/scripts/ZoneMinder/lib/ZoneMinder/Object.pm
index d79465e86..ef9ee9714 100644
--- a/scripts/ZoneMinder/lib/ZoneMinder/Object.pm
+++ b/scripts/ZoneMinder/lib/ZoneMinder/Object.pm
@@ -45,70 +45,69 @@ use ZoneMinder::Database qw(:all);
use vars qw/ $AUTOLOAD /;
sub new {
- my ( $parent, $id, $data ) = @_;
+ my ( $parent, $id, $data ) = @_;
- my $self = {};
- bless $self, $parent;
- no strict 'refs';
- my $primary_key = ${$parent.'::primary_key'};
- if ( ! $primary_key ) {
- Error( 'NO primary_key for type ' . $parent );
- return;
- } # end if
- if ( ( $$self{$primary_key} = $id ) or $data ) {
+ my $self = {};
+ bless $self, $parent;
+ no strict 'refs';
+ my $primary_key = ${$parent.'::primary_key'};
+ if ( ! $primary_key ) {
+ Error( 'NO primary_key for type ' . $parent );
+ return;
+ } # end if
+ if ( ( $$self{$primary_key} = $id ) or $data ) {
#$log->debug("loading $parent $id") if $debug or DEBUG_ALL;
- $self->load( $data );
- }
- return $self;
+ $self->load( $data );
+ }
+ return $self;
} # end sub new
sub load {
- my ( $self, $data ) = @_;
- my $type = ref $self;
- if ( ! $data ) {
- no strict 'refs';
- my $table = ${$type.'::table'};
- if ( ! $table ) {
- Error( 'NO table for type ' . $type );
- return;
- } # end if
- my $primary_key = ${$type.'::primary_key'};
- if ( ! $primary_key ) {
- Error( 'NO primary_key for type ' . $type );
- return;
- } # end if
+ my ( $self, $data ) = @_;
+ my $type = ref $self;
+ if ( ! $data ) {
+ no strict 'refs';
+ my $table = ${$type.'::table'};
+ if ( ! $table ) {
+ Error( 'NO table for type ' . $type );
+ return;
+ } # end if
+ my $primary_key = ${$type.'::primary_key'};
+ if ( ! $primary_key ) {
+ Error( 'NO primary_key for type ' . $type );
+ return;
+ } # end if
- if ( ! $$self{$primary_key} ) {
- my ( $caller, undef, $line ) = caller;
- Error( (ref $self) . "::load called without $primary_key from $caller:$line");
- } else {
- #$log->debug("Object::load Loading from db $type");
- Debug("Loading $type from $table WHERE $primary_key = $$self{$primary_key}");
- $data = $ZoneMinder::Database::dbh->selectrow_hashref( "SELECT * FROM $table WHERE $primary_key=?", {}, $$self{$primary_key} );
- if ( ! $data ) {
- if ( $ZoneMinder::Database::dbh->errstr ) {
- Error( "Failure to load Object record for $$self{$primary_key}: Reason: " . $ZoneMinder::Database::dbh->errstr );
- } else {
- Debug("No Results Loading $type from $table WHERE $primary_key = $$self{$primary_key}");
-
- } # end if
- } # end if
- } # end if
- } # end if ! $data
- if ( $data and %$data ) {
- @$self{keys %$data} = values %$data;
- } # end if
+ if ( ! $$self{$primary_key} ) {
+ my ( $caller, undef, $line ) = caller;
+ Error( (ref $self) . "::load called without $primary_key from $caller:$line");
+ } else {
+#$log->debug("Object::load Loading from db $type");
+ Debug("Loading $type from $table WHERE $primary_key = $$self{$primary_key}");
+ $data = $ZoneMinder::Database::dbh->selectrow_hashref( "SELECT * FROM $table WHERE $primary_key=?", {}, $$self{$primary_key} );
+ if ( ! $data ) {
+ if ( $ZoneMinder::Database::dbh->errstr ) {
+ Error( "Failure to load Object record for $$self{$primary_key}: Reason: " . $ZoneMinder::Database::dbh->errstr );
+ } else {
+ Debug("No Results Loading $type from $table WHERE $primary_key = $$self{$primary_key}");
+ } # end if
+ } # end if
+ } # end if
+ } # end if ! $data
+ if ( $data and %$data ) {
+ @$self{keys %$data} = values %$data;
+ } # end if
} # end sub load
sub AUTOLOAD {
- my ( $self, $newvalue ) = @_;
- my $type = ref($_[0]);
- my $name = $AUTOLOAD;
- $name =~ s/.*://;
- if ( @_ > 1 ) {
- return $_[0]{$name} = $_[1];
- }
-return $_[0]{$name};
+ my ( $self, $newvalue ) = @_;
+ my $type = ref($_[0]);
+ my $name = $AUTOLOAD;
+ $name =~ s/.*://;
+ if ( @_ > 1 ) {
+ return $_[0]{$name} = $_[1];
+ }
+ return $_[0]{$name};
}
diff --git a/scripts/zmaudit.pl.in b/scripts/zmaudit.pl.in
index d8a1021cb..cee574975 100644
--- a/scripts/zmaudit.pl.in
+++ b/scripts/zmaudit.pl.in
@@ -271,7 +271,7 @@ MAIN: while( $loop ) {
} # if USE_DEEP_STORAGE
Debug( 'Got '.int(keys(%$fs_events))." events for monitor $monitor_dir\n" );
- delete_empty_directories( $monitor_dir );
+ #delete_empty_directories( $monitor_dir );
} # end foreach monitor
redo MAIN if ( $cleaned );
@@ -338,7 +338,10 @@ MAIN: while( $loop ) {
my $deleteStatsSth = $dbh->prepare_cached( $deleteStatsSql )
or Fatal( "Can't prepare '$deleteStatsSql': ".$dbh->errstr() );
+ # Foreach database monitor and it's list of events.
while ( my ( $db_monitor, $db_events ) = each(%$db_monitors) ) {
+
+ # If we found the monitor in the file system
if ( my $fs_events = $fs_monitors->{$db_monitor} ) {
next if ! $db_events;
@@ -355,7 +358,7 @@ Debug("Event $db_event is not in fs.");
next;
}
if ( $Event->check_for_in_filesystem() ) {
- Debug('Database events apparent exists at ' . $Event->Path() );
+ Debug('Database events apparently exists at ' . $Event->Path() );
} else {
if ( $age > $Config{ZM_AUDIT_MIN_AGE} ) {
aud_print( "Database event '$db_monitor/$db_event' does not exist at " . $Event->Path().' in filesystem' );
@@ -657,6 +660,7 @@ sub deleteSwapImage {
sub delete_empty_directories {
my $DIR;
+ Debug("delete_empty_directories $_[0]");
if ( ! opendir( $DIR, $_[0] ) ) {
Error( "delete_empty_directories: Can't open directory '".getcwd()."/$_[0]': $!" );
return;
diff --git a/scripts/zmdc.pl.in b/scripts/zmdc.pl.in
index b966ac536..39680a7ed 100644
--- a/scripts/zmdc.pl.in
+++ b/scripts/zmdc.pl.in
@@ -209,6 +209,7 @@ use ZoneMinder;
use POSIX;
use Socket;
use IO::Handle;
+use Time::HiRes qw(usleep);
#use Data::Dumper;
our %cmd_hash;
@@ -456,20 +457,25 @@ sub send_stop {
} # end sub send_stop
sub kill_until_dead {
- my ( $process ) = @_;
- # Now check it has actually gone away, if not kill -9 it
- my $count = 0;
- while( $process and $$process{pid} and kill( 0, $$process{pid} ) ) {
- if ( $count++ > 5 ) {
- dPrint( ZoneMinder::Logger::WARNING, "'$$process{command}' has not stopped at "
- .strftime( '%y/%m/%d %H:%M:%S', localtime() )
- .". Sending KILL to pid $$process{pid}\n"
- );
- kill( 'KILL', $$process{pid} );
- }
-
- sleep( 1 );
+ my ( $process ) = @_;
+# Now check it has actually gone away, if not kill -9 it
+ my $count = 0;
+ my $sigset = POSIX::SigSet->new;
+ my $blockset = POSIX::SigSet->new(SIGCHLD);
+ sigprocmask(SIG_BLOCK, $blockset, $sigset ) or die "dying at block...\n";
+ while( $process and $$process{pid} and kill( 0, $$process{pid} ) ) {
+ if ( $count++ > 50 ) {
+ dPrint( ZoneMinder::Logger::WARNING, "'$$process{command}' has not stopped at "
+ .strftime( '%y/%m/%d %H:%M:%S', localtime() )
+ .". Sending KILL to pid $$process{pid}\n"
+ );
+ kill( 'KILL', $$process{pid} );
}
+
+ sigprocmask(SIG_UNBLOCK, $blockset) or die "dying at unblock...\n";
+ usleep( 100 );
+ sigprocmask(SIG_BLOCK, $blockset, $sigset ) or die "dying at block...\n";
+ }
}
sub _stop {
diff --git a/src/zm_ffmpeg_camera.cpp b/src/zm_ffmpeg_camera.cpp
index 799d59b70..cb322f335 100644
--- a/src/zm_ffmpeg_camera.cpp
+++ b/src/zm_ffmpeg_camera.cpp
@@ -42,8 +42,7 @@ FfmpegCamera::FfmpegCamera( int p_id, const std::string &p_path, const std::stri
mMethod( p_method ),
mOptions( p_options )
{
- if ( capture )
- {
+ if ( capture ) {
Initialise();
}
@@ -83,20 +82,19 @@ FfmpegCamera::FfmpegCamera( int p_id, const std::string &p_path, const std::stri
}
-FfmpegCamera::~FfmpegCamera()
-{
-
+FfmpegCamera::~FfmpegCamera() {
+ if ( videoStore ) {
+ delete videoStore;
+ }
CloseFfmpeg();
- if ( capture )
- {
+ if ( capture ) {
Terminate();
}
}
-void FfmpegCamera::Initialise()
-{
+void FfmpegCamera::Initialise() {
if ( logDebugging() )
av_log_set_level( AV_LOG_DEBUG );
else
@@ -106,12 +104,10 @@ void FfmpegCamera::Initialise()
avformat_network_init();
}
-void FfmpegCamera::Terminate()
-{
+void FfmpegCamera::Terminate() {
}
-int FfmpegCamera::PrimeCapture()
-{
+int FfmpegCamera::PrimeCapture() {
mVideoStreamId = -1;
mAudioStreamId = -1;
Info( "Priming capture from %s", mPath.c_str() );
@@ -434,6 +430,10 @@ int FfmpegCamera::OpenFfmpeg() {
Fatal( "You must compile ffmpeg with the --enable-swscale option to use ffmpeg cameras" );
#endif // HAVE_LIBSWSCALE
+ if ( mVideoCodecContext->width != width || mVideoCodecContext->height != height ) {
+ Warning( "Monitor dimensions are %dx%d but camera is sending %dx%d", width, height, mVideoCodecContext->width, mVideoCodecContext->height );
+ }
+
mCanCapture = true;
return 0;
@@ -675,16 +675,22 @@ Debug(5, "After av_read_frame (%d)", ret );
videoStore = NULL;
}
- //Buffer video packets, since we are not recording. All audio packets are keyframes, so only if it's a video keyframe
+ // Buffer video packets, since we are not recording.
+ // All audio packets are keyframes, so only if it's a video keyframe
if ( packet.stream_index == mVideoStreamId) {
if ( key_frame ) {
Debug(3, "Clearing queue");
packetqueue.clearQueue();
- }
- if ( packet.pts && video_last_pts > packet.pts ) {
- Warning( "Clearing queue due to out of order pts");
+ }
+#if 0
+// Not sure this is valid. While a camera will PROBABLY always have an increasing pts... it doesn't have to.
+// Also, I think there are integer wrap-around issues.
+
+else if ( packet.pts && video_last_pts > packet.pts ) {
+ Warning( "Clearing queue due to out of order pts packet.pts(%d) < video_last_pts(%d)");
packetqueue.clearQueue();
}
+#endif
}
if (
diff --git a/src/zm_image.cpp b/src/zm_image.cpp
index a6a6e7d95..250ed1b45 100644
--- a/src/zm_image.cpp
+++ b/src/zm_image.cpp
@@ -45,7 +45,6 @@ static short *r_v_table;
static short *g_v_table;
static short *g_u_table;
static short *b_u_table;
-__attribute__((aligned(16))) static const uint8_t movemask[16] = {0,4,8,12,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF};
jpeg_compress_struct *Image::writejpg_ccinfo[101] = { 0 };
jpeg_compress_struct *Image::encodejpg_ccinfo[101] = { 0 };
@@ -278,24 +277,20 @@ void Image::Initialise()
fptr_delta8_gray8 = &std_delta8_gray8;
Debug(4,"Delta: CPU extensions disabled, using standard delta functions");
}
+
+ /*
+ SSSE3 deinterlacing functions were removed because they were usually equal
+ or slower than the standard code (compiled with -O2 or better)
+ The function is too complicated to be vectorized efficiently
+ */
+ fptr_deinterlace_4field_rgba = &std_deinterlace_4field_rgba;
+ fptr_deinterlace_4field_bgra = &std_deinterlace_4field_bgra;
+ fptr_deinterlace_4field_argb = &std_deinterlace_4field_argb;
+ fptr_deinterlace_4field_abgr = &std_deinterlace_4field_abgr;
+ fptr_deinterlace_4field_gray8 = &std_deinterlace_4field_gray8;
+ Debug(4,"Deinterlace: Using standard functions");
- /* Use SSSE3 deinterlace functions? */
- if(config.cpu_extensions && sseversion >= 35) {
- fptr_deinterlace_4field_rgba = &ssse3_deinterlace_4field_rgba;
- fptr_deinterlace_4field_bgra = &ssse3_deinterlace_4field_bgra;
- fptr_deinterlace_4field_argb = &ssse3_deinterlace_4field_argb;
- fptr_deinterlace_4field_abgr = &ssse3_deinterlace_4field_abgr;
- fptr_deinterlace_4field_gray8 = &ssse3_deinterlace_4field_gray8;
- Debug(4,"Deinterlace: Using SSSE3 delta functions");
- } else {
- fptr_deinterlace_4field_rgba = &std_deinterlace_4field_rgba;
- fptr_deinterlace_4field_bgra = &std_deinterlace_4field_bgra;
- fptr_deinterlace_4field_argb = &std_deinterlace_4field_argb;
- fptr_deinterlace_4field_abgr = &std_deinterlace_4field_abgr;
- fptr_deinterlace_4field_gray8 = &std_deinterlace_4field_gray8;
- Debug(4,"Deinterlace: Using standard delta functions");
- }
-
+#if defined(__i386__) && !defined(__x86_64__)
/* Use SSE2 aligned memory copy? */
if(config.cpu_extensions && sseversion >= 20) {
fptr_imgbufcpy = &sse2_aligned_memcpy;
@@ -304,6 +299,10 @@ void Image::Initialise()
fptr_imgbufcpy = &memcpy;
Debug(4,"Image buffer copy: Using standard memcpy");
}
+#else
+ fptr_imgbufcpy = &memcpy;
+ Debug(4,"Image buffer copy: Using standard memcpy");
+#endif
/* Code below relocated from zm_local_camera */
Debug( 3, "Setting up static colour tables" );
@@ -2092,35 +2091,54 @@ void Image::DeColourise()
subpixelorder = ZM_SUBPIX_ORDER_NONE;
size = width * height;
- if ( colours == ZM_COLOUR_RGB32 )
- {
+ if(colours == ZM_COLOUR_RGB32 && config.cpu_extensions && sseversion >= 35) {
+ /* Use SSSE3 functions */
switch(subpixelorder) {
case ZM_SUBPIX_ORDER_BGRA:
- std_convert_bgra_gray8(buffer,buffer,pixels);
+ ssse3_convert_bgra_gray8(buffer,buffer,pixels);
break;
case ZM_SUBPIX_ORDER_ARGB:
- std_convert_argb_gray8(buffer,buffer,pixels);
+ ssse3_convert_argb_gray8(buffer,buffer,pixels);
break;
case ZM_SUBPIX_ORDER_ABGR:
- std_convert_abgr_gray8(buffer,buffer,pixels);
+ ssse3_convert_abgr_gray8(buffer,buffer,pixels);
break;
case ZM_SUBPIX_ORDER_RGBA:
default:
- std_convert_rgba_gray8(buffer,buffer,pixels);
+ ssse3_convert_rgba_gray8(buffer,buffer,pixels);
break;
}
} else {
- /* Assume RGB24 */
- switch(subpixelorder) {
- case ZM_SUBPIX_ORDER_BGR:
- std_convert_bgr_gray8(buffer,buffer,pixels);
- break;
- case ZM_SUBPIX_ORDER_RGB:
- default:
- std_convert_rgb_gray8(buffer,buffer,pixels);
- break;
- }
-
+ /* Use standard functions */
+ if ( colours == ZM_COLOUR_RGB32 )
+ {
+ switch(subpixelorder) {
+ case ZM_SUBPIX_ORDER_BGRA:
+ std_convert_bgra_gray8(buffer,buffer,pixels);
+ break;
+ case ZM_SUBPIX_ORDER_ARGB:
+ std_convert_argb_gray8(buffer,buffer,pixels);
+ break;
+ case ZM_SUBPIX_ORDER_ABGR:
+ std_convert_abgr_gray8(buffer,buffer,pixels);
+ break;
+ case ZM_SUBPIX_ORDER_RGBA:
+ default:
+ std_convert_rgba_gray8(buffer,buffer,pixels);
+ break;
+ }
+ } else {
+ /* Assume RGB24 */
+ switch(subpixelorder) {
+ case ZM_SUBPIX_ORDER_BGR:
+ std_convert_bgr_gray8(buffer,buffer,pixels);
+ break;
+ case ZM_SUBPIX_ORDER_RGB:
+ default:
+ std_convert_rgb_gray8(buffer,buffer,pixels);
+ break;
+ }
+ }
}
}
@@ -3291,11 +3309,11 @@ __attribute__((noinline)) void std_fastblend(const uint8_t* col1, const uint8_t*
}
/* FastBlend Neon for AArch32 */
-#if defined(__arm__)
+#if (defined(__arm__) && !defined(ZM_STRIP_NEON))
__attribute__((noinline,__target__("fpu=neon")))
#endif
void neon32_armv7_fastblend(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count, double blendpercent) {
-#if defined(__arm__)
+#if (defined(__arm__) && !defined(ZM_STRIP_NEON))
static int8_t divider = 0;
static double current_blendpercent = 0.0;
@@ -3348,7 +3366,7 @@ void neon32_armv7_fastblend(const uint8_t* col1, const uint8_t* col2, uint8_t* r
: "%r12", "%q0", "%q1", "%q2", "%q3", "cc", "memory"
);
#else
- Panic("Neon function called on a non ARM platform");
+ Panic("Neon function called on a non-ARM platform or Neon code is absent");
#endif
}
@@ -3575,11 +3593,11 @@ __attribute__((noinline)) void std_delta8_abgr(const uint8_t* col1, const uint8_
}
/* Grayscale Neon for AArch32 */
-#if defined(__arm__)
+#if (defined(__arm__) && !defined(ZM_STRIP_NEON))
__attribute__((noinline,__target__("fpu=neon")))
#endif
void neon32_armv7_delta8_gray8(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count) {
-#if defined(__arm__)
+#if (defined(__arm__) && !defined(ZM_STRIP_NEON))
/* Q0(D0,D1) = col1 */
/* Q1(D2,D3) = col2 */
@@ -3597,16 +3615,16 @@ void neon32_armv7_delta8_gray8(const uint8_t* col1, const uint8_t* col2, uint8_t
: "%q0", "%q1", "cc", "memory"
);
#else
- Panic("Neon function called on a non ARM platform");
+ Panic("Neon function called on a non-ARM platform or Neon code is absent");
#endif
}
/* RGB32 Neon for AArch32 */
-#if defined(__arm__)
+#if (defined(__arm__) && !defined(ZM_STRIP_NEON))
__attribute__((noinline,__target__("fpu=neon")))
#endif
void neon32_armv7_delta8_rgb32(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count, uint32_t multiplier) {
-#if defined(__arm__)
+#if (defined(__arm__) && !defined(ZM_STRIP_NEON))
/* Q0(D0,D1) = col1 */
/* Q1(D2,D3) = col2 */
@@ -3632,7 +3650,7 @@ void neon32_armv7_delta8_rgb32(const uint8_t* col1, const uint8_t* col2, uint8_t
: "%r12", "%q0", "%q1", "%q2", "cc", "memory"
);
#else
- Panic("Neon function called on a non ARM platform");
+ Panic("Neon function called on a non-ARM platform or Neon code is absent");
#endif
}
@@ -3921,25 +3939,31 @@ void sse2_delta8_abgr(const uint8_t* col1, const uint8_t* col2, uint8_t* result,
#endif
}
-/* RGB32: RGBA SSSE3 */
+/* RGB32 SSSE3 */
#if defined(__i386__) || defined(__x86_64__)
__attribute__((noinline,__target__("ssse3")))
#endif
-void ssse3_delta8_rgba(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count) {
+void ssse3_delta8_rgb32(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count, uint32_t multiplier) {
#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
-
+
+ /* XMM0 - zero */
+ /* XMM1 - col1 */
+ /* XMM2 - col2 */
+ /* XMM3 - multiplier */
+ /* XMM4 - divide mask */
+
__asm__ __volatile__ (
"mov $0x1F1F1F1F, %%eax\n\t"
"movd %%eax, %%xmm4\n\t"
"pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "mov $0xff, %%eax\n\t"
- "movd %%eax, %%xmm0\n\t"
- "pshufd $0x0, %%xmm0, %%xmm0\n\t"
- "movdqa %4, %%xmm5\n\t"
+ "mov %4, %%eax\n\t"
+ "movd %%eax, %%xmm3\n\t"
+ "pshufd $0x0, %%xmm3, %%xmm3\n\t"
+ "pxor %%xmm0, %%xmm0\n\t"
"sub $0x10, %0\n\t"
"sub $0x10, %1\n\t"
"sub $0x4, %2\n\t"
- "ssse3_delta8_rgba_iter:\n\t"
+ "ssse3_delta8_rgb32_iter:\n\t"
"movdqa (%0,%3,4), %%xmm1\n\t"
"movdqa (%1,%3,4), %%xmm2\n\t"
"psrlq $0x3, %%xmm1\n\t"
@@ -3947,200 +3971,41 @@ void ssse3_delta8_rgba(const uint8_t* col1, const uint8_t* col2, uint8_t* result
"pand %%xmm4, %%xmm1\n\t"
"pand %%xmm4, %%xmm2\n\t"
"psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm3\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x8, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "pslld $0x2, %%xmm2\n\t"
- "paddd %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm3, %%xmm1\n\t"
- "pand %%xmm0, %%xmm1\n\t"
- "paddd %%xmm1, %%xmm1\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x10, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "pshufb %%xmm5, %%xmm1\n\t"
+ "pabsb %%xmm1, %%xmm1\n\t"
+ "pmaddubsw %%xmm3, %%xmm1\n\t"
+ "phaddw %%xmm0, %%xmm1\n\t"
+ "packuswb %%xmm1, %%xmm1\n\t"
"movd %%xmm1, %%eax\n\t"
"movnti %%eax, (%2,%3)\n\t"
"sub $0x4, %3\n\t"
- "jnz ssse3_delta8_rgba_iter\n\t"
+ "jnz ssse3_delta8_rgb32_iter\n\t"
:
- : "r" (col1), "r" (col2), "r" (result), "r" (count), "m" (*movemask)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "cc", "memory"
+ : "r" (col1), "r" (col2), "r" (result), "r" (count), "g" (multiplier)
+ : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "cc", "memory"
);
#else
Panic("SSE function called on a non x86\\x86-64 platform");
#endif
}
+/* RGB32: RGBA SSSE3 */
+void ssse3_delta8_rgba(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count) {
+ ssse3_delta8_rgb32(col1, col2, result, count, 0x00010502);
+}
+
/* RGB32: BGRA SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
void ssse3_delta8_bgra(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count) {
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
-
- __asm__ __volatile__ (
- "mov $0x1F1F1F1F, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "mov $0xff, %%eax\n\t"
- "movd %%eax, %%xmm0\n\t"
- "pshufd $0x0, %%xmm0, %%xmm0\n\t"
- "movdqa %4, %%xmm5\n\t"
- "sub $0x10, %0\n\t"
- "sub $0x10, %1\n\t"
- "sub $0x4, %2\n\t"
- "ssse3_delta8_bgra_iter:\n\t"
- "movdqa (%0,%3,4), %%xmm1\n\t"
- "movdqa (%1,%3,4), %%xmm2\n\t"
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm3\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x8, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "pslld $0x2, %%xmm2\n\t"
- "paddd %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm3, %%xmm1\n\t"
- "pand %%xmm0, %%xmm1\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x10, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "paddd %%xmm2, %%xmm2\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "pshufb %%xmm5, %%xmm1\n\t"
- "movd %%xmm1, %%eax\n\t"
- "movnti %%eax, (%2,%3)\n\t"
- "sub $0x4, %3\n\t"
- "jnz ssse3_delta8_bgra_iter\n\t"
- :
- : "r" (col1), "r" (col2), "r" (result), "r" (count), "m" (*movemask)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "cc", "memory"
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
+ ssse3_delta8_rgb32(col1, col2, result, count, 0x00020501);
}
/* RGB32: ARGB SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
void ssse3_delta8_argb(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count) {
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
-
- __asm__ __volatile__ (
- "mov $0x1F1F1F1F, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "mov $0xff, %%eax\n\t"
- "movd %%eax, %%xmm0\n\t"
- "pshufd $0x0, %%xmm0, %%xmm0\n\t"
- "movdqa %4, %%xmm5\n\t"
- "sub $0x10, %0\n\t"
- "sub $0x10, %1\n\t"
- "sub $0x4, %2\n\t"
- "ssse3_delta8_argb_iter:\n\t"
- "movdqa (%0,%3,4), %%xmm1\n\t"
- "movdqa (%1,%3,4), %%xmm2\n\t"
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm3\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x10, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "pslld $0x2, %%xmm2\n\t"
- "paddd %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm3, %%xmm1\n\t"
- "psrld $0x8, %%xmm1\n\t"
- "pand %%xmm0, %%xmm1\n\t"
- "paddd %%xmm1, %%xmm1\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x18, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "pshufb %%xmm5, %%xmm1\n\t"
- "movd %%xmm1, %%eax\n\t"
- "movnti %%eax, (%2,%3)\n\t"
- "sub $0x4, %3\n\t"
- "jnz ssse3_delta8_argb_iter\n\t"
- :
- : "r" (col1), "r" (col2), "r" (result), "r" (count), "m" (*movemask)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "cc", "memory"
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
+ ssse3_delta8_rgb32(col1, col2, result, count, 0x01050200);
}
/* RGB32: ABGR SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
void ssse3_delta8_abgr(const uint8_t* col1, const uint8_t* col2, uint8_t* result, unsigned long count) {
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
-
- __asm__ __volatile__ (
- "mov $0x1F1F1F1F, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "mov $0xff, %%eax\n\t"
- "movd %%eax, %%xmm0\n\t"
- "pshufd $0x0, %%xmm0, %%xmm0\n\t"
- "movdqa %4, %%xmm5\n\t"
- "sub $0x10, %0\n\t"
- "sub $0x10, %1\n\t"
- "sub $0x4, %2\n\t"
- "ssse3_delta8_abgr_iter:\n\t"
- "movdqa (%0,%3,4), %%xmm1\n\t"
- "movdqa (%1,%3,4), %%xmm2\n\t"
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm3\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x10, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "pslld $0x2, %%xmm2\n\t"
- "paddd %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm3, %%xmm1\n\t"
- "psrld $0x8, %%xmm1\n\t"
- "pand %%xmm0, %%xmm1\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x18, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "paddd %%xmm2, %%xmm2\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "pshufb %%xmm5, %%xmm1\n\t"
- "movd %%xmm1, %%eax\n\t"
- "movnti %%eax, (%2,%3)\n\t"
- "sub $0x4, %3\n\t"
- "jnz ssse3_delta8_abgr_iter\n\t"
- :
- : "r" (col1), "r" (col2), "r" (result), "r" (count), "m" (*movemask)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "cc", "memory"
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
+ ssse3_delta8_rgb32(col1, col2, result, count, 0x02050100);
}
@@ -4342,55 +4207,68 @@ __attribute__((noinline)) void std_convert_yuyv_gray8(const uint8_t* col1, uint8
}
}
-/* RGBA to grayscale SSSE3 */
+/* RGB32 to grayscale SSSE3 */
#if defined(__i386__) || defined(__x86_64__)
__attribute__((noinline,__target__("ssse3")))
#endif
-void ssse3_convert_rgba_gray8(const uint8_t* col1, uint8_t* result, unsigned long count) {
+void ssse3_convert_rgb32_gray8(const uint8_t* col1, uint8_t* result, unsigned long count, uint32_t multiplier) {
#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
+ /* XMM0 - zero */
+ /* XMM1 - col1 */
+ /* XMM3 - multiplier */
+ /* XMM4 - divide mask */
+
__asm__ __volatile__ (
"mov $0x1F1F1F1F, %%eax\n\t"
"movd %%eax, %%xmm4\n\t"
"pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "mov $0xff, %%eax\n\t"
- "movd %%eax, %%xmm0\n\t"
- "pshufd $0x0, %%xmm0, %%xmm0\n\t"
- "movdqa %3, %%xmm5\n\t"
+ "mov %3, %%eax\n\t"
+ "movd %%eax, %%xmm3\n\t"
+ "pshufd $0x0, %%xmm3, %%xmm3\n\t"
+ "pxor %%xmm0, %%xmm0\n\t"
"sub $0x10, %0\n\t"
"sub $0x4, %1\n\t"
- "ssse3_convert_rgba_gray8_iter:\n\t"
- "movdqa (%0,%2,4), %%xmm3\n\t"
- "psrlq $0x3, %%xmm3\n\t"
- "pand %%xmm4, %%xmm3\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x8, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "pslld $0x2, %%xmm2\n\t"
- "paddd %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm3, %%xmm1\n\t"
- "pand %%xmm0, %%xmm1\n\t"
- "paddd %%xmm1, %%xmm1\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm3, %%xmm2\n\t"
- "psrld $0x10, %%xmm2\n\t"
- "pand %%xmm0, %%xmm2\n\t"
- "paddd %%xmm2, %%xmm1\n\t"
- "pshufb %%xmm5, %%xmm1\n\t"
+ "ssse3_convert_rgb32_gray8_iter:\n\t"
+ "movdqa (%0,%2,4), %%xmm1\n\t"
+ "psrlq $0x3, %%xmm1\n\t"
+ "pand %%xmm4, %%xmm1\n\t"
+ "pmaddubsw %%xmm3, %%xmm1\n\t"
+ "phaddw %%xmm0, %%xmm1\n\t"
+ "packuswb %%xmm1, %%xmm1\n\t"
"movd %%xmm1, %%eax\n\t"
"movnti %%eax, (%1,%2)\n\t"
"sub $0x4, %2\n\t"
- "jnz ssse3_convert_rgba_gray8_iter\n\t"
+ "jnz ssse3_convert_rgb32_gray8_iter\n\t"
:
- : "r" (col1), "r" (result), "r" (count), "m" (*movemask)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "cc", "memory"
+ : "r" (col1), "r" (result), "r" (count), "g" (multiplier)
+ : "%eax", "%xmm0", "%xmm1", "%xmm3", "%xmm4", "cc", "memory"
);
#else
Panic("SSE function called on a non x86\\x86-64 platform");
#endif
}
+/* RGBA to grayscale SSSE3 */
+void ssse3_convert_rgba_gray8(const uint8_t* col1, uint8_t* result, unsigned long count) {
+ ssse3_convert_rgb32_gray8(col1, result, count, 0x00010502);
+}
+
+/* BGRA to grayscale SSSE3 */
+void ssse3_convert_bgra_gray8(const uint8_t* col1, uint8_t* result, unsigned long count) {
+ ssse3_convert_rgb32_gray8(col1, result, count, 0x00020501);
+}
+
+/* ARGB to grayscale SSSE3 */
+void ssse3_convert_argb_gray8(const uint8_t* col1, uint8_t* result, unsigned long count) {
+ ssse3_convert_rgb32_gray8(col1, result, count, 0x01050200);
+}
+
+/* ABGR to grayscale SSSE3 */
+void ssse3_convert_abgr_gray8(const uint8_t* col1, uint8_t* result, unsigned long count) {
+ ssse3_convert_rgb32_gray8(col1, result, count, 0x02050100);
+}
+
/* Converts a YUYV image into grayscale by extracting the Y channel */
#if defined(__i386__) || defined(__x86_64__)
__attribute__((noinline,__target__("ssse3")))
@@ -5010,871 +4888,3 @@ __attribute__((noinline)) void std_deinterlace_4field_abgr(uint8_t* col1, uint8_
pncurrent += 4;
}
}
-
-/* Grayscale SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
-void ssse3_deinterlace_4field_gray8(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height) {
-
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
- union {
- uint32_t int32;
- uint8_t int8a[4];
- } threshold_mask;
- threshold_mask.int8a[0] = threshold;
- threshold_mask.int8a[1] = 0;
- threshold_mask.int8a[2] = threshold;
- threshold_mask.int8a[3] = 0;
-
- unsigned long row_width = width;
- uint8_t* max_ptr = col1 + (row_width * (height-2));
- uint8_t* max_ptr2 = col1 + row_width;
-
- __asm__ __volatile__ (
- /* Load the threshold */
- "mov %5, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- /* Zero the temporary register */
- "pxor %%xmm0, %%xmm0\n\t"
-
- "algo_ssse3_deinterlace_4field_gray8:\n\t"
-
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "pmaxub %%xmm2, %%xmm1\n\t"
- "pminub %%xmm5, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "pmaxub %%xmm2, %%xmm1\n\t"
- "pminub %%xmm6, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
- "movdqa %%xmm1, %%xmm2\n\t"
-
- /* Do the comparison on words instead of bytes because we don't have unsigned comparison */
- "punpcklbw %%xmm0, %%xmm1\n\t" // Expand pixels 0-7 into words into xmm1
- "punpckhbw %%xmm0, %%xmm2\n\t" // Expand pixels 8-15 into words into xmm2
- "pcmpgtw %%xmm4, %%xmm1\n\t" // Compare average delta with threshold for pixels 0-7
- "pcmpgtw %%xmm4, %%xmm2\n\t" // Compare average delta with threshold for pixels 8-15
- "packsswb %%xmm2, %%xmm1\n\t" // Pack the comparison results into xmm1
-
- "movdqa (%0,%4), %%xmm2\n\t" // Load pbelow
- "pavgb %%xmm5, %%xmm2\n\t" // Average pabove and pbelow
- "pand %%xmm1, %%xmm2\n\t" // Filter out pixels in avg that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm2, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
-
- "sub %4, %0\n\t" // Restore pcurrent to pabove
- "sub %4, %1\n\t" // Restore pncurrent to pnabove
-
- /* Next pixels */
- "add $0x10, %0\n\t" // Add 16 to pcurrent
- "add $0x10, %1\n\t" // Add 16 to pncurrent
-
- /* Check if we reached the row end */
- "cmp %2, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_gray8\n\t" // Go for another iteration
-
- /* Next row */
- "add %4, %0\n\t" // Add width to pcurrent
- "add %4, %1\n\t" // Add width to pncurrent
- "mov %0, %2\n\t"
- "add %4, %2\n\t" // Add width to max_ptr2
-
- /* Check if we reached the end */
- "cmp %3, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_gray8\n\t" // Go for another iteration
-
- /* Special case for the last line */
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "pmaxub %%xmm2, %%xmm1\n\t"
- "pminub %%xmm5, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "pmaxub %%xmm2, %%xmm1\n\t"
- "pminub %%xmm6, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
- "movdqa %%xmm1, %%xmm2\n\t"
-
- /* Do the comparison on words instead of bytes because we don't have unsigned comparison */
- "punpcklbw %%xmm0, %%xmm1\n\t" // Expand pixels 0-7 into words into xmm1
- "punpckhbw %%xmm0, %%xmm2\n\t" // Expand pixels 8-15 into words into xmm2
- "pcmpgtw %%xmm4, %%xmm1\n\t" // Compare average delta with threshold for pixels 0-7
- "pcmpgtw %%xmm4, %%xmm2\n\t" // Compare average delta with threshold for pixels 8-15
- "packsswb %%xmm2, %%xmm1\n\t" // Pack the comparison results into xmm1
-
- "pand %%xmm1, %%xmm5\n\t" // Filter out pixels in pabove that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm5, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
- :
- : "r" (col1), "r" (col2), "r" (max_ptr2), "r" (max_ptr), "r" (row_width), "m" (threshold_mask.int32)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "cc", "memory"
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
-}
-
-/* RGBA SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
-void ssse3_deinterlace_4field_rgba(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height) {
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
- __attribute__((aligned(16))) static const uint8_t movemask2[16] = {1,1,1,1,1,0,0,2,9,9,9,9,9,8,8,10};
-
- const uint32_t threshold_val = threshold;
-
- unsigned long row_width = width*4;
- uint8_t* max_ptr = col1 + (row_width * (height-2));
- uint8_t* max_ptr2 = col1 + row_width;
-
- __asm__ __volatile__ (
- "mov $0x1F1F1F1F, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "movdqa %6, %%xmm3\n\t"
- "mov %5, %%eax\n\t"
-#if defined(__x86_64__)
- "movd %%eax, %%xmm8\n\t"
- "pshufd $0x0, %%xmm8, %%xmm8\n\t"
-#endif
- /* Zero the temporary register */
- "pxor %%xmm0, %%xmm0\n\t"
-
- "algo_ssse3_deinterlace_4field_rgba:\n\t"
-
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "movdqa (%0,%4), %%xmm2\n\t" // Load pbelow
- "pavgb %%xmm5, %%xmm2\n\t" // Average pabove and pbelow
- "pand %%xmm1, %%xmm2\n\t" // Filter out pixels in avg that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm2, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
-
- "sub %4, %0\n\t" // Restore pcurrent to pabove
- "sub %4, %1\n\t" // Restore pncurrent to pnabove
-
- /* Next pixels */
- "add $0x10, %0\n\t" // Add 16 to pcurrent
- "add $0x10, %1\n\t" // Add 16 to pncurrent
-
- /* Check if we reached the row end */
- "cmp %2, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_rgba\n\t" // Go for another iteration
-
- /* Next row */
- "add %4, %0\n\t" // Add width to pcurrent
- "add %4, %1\n\t" // Add width to pncurrent
- "mov %0, %2\n\t"
- "add %4, %2\n\t" // Add width to max_ptr2
-
- /* Check if we reached the end */
- "cmp %3, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_rgba\n\t" // Go for another iteration
-
- /* Special case for the last line */
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "pand %%xmm1, %%xmm5\n\t" // Filter out pixels in pabove that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm5, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
- :
- : "r" (col1), "r" (col2), "r" (max_ptr2), "r" (max_ptr), "r" (row_width), "m" (threshold_val), "m" (*movemask2)
-#if defined(__x86_64__)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "%xmm8", "cc", "memory"
-#else
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "cc", "memory"
-#endif
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
-}
-
-/* BGRA SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
-void ssse3_deinterlace_4field_bgra(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height) {
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
- __attribute__((aligned(16))) static const uint8_t movemask2[16] = {1,1,1,1,1,2,2,0,9,9,9,9,9,10,10,8};
-
- const uint32_t threshold_val = threshold;
-
- unsigned long row_width = width*4;
- uint8_t* max_ptr = col1 + (row_width * (height-2));
- uint8_t* max_ptr2 = col1 + row_width;
-
- __asm__ __volatile__ (
- "mov $0x1F1F1F1F, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "movdqa %6, %%xmm3\n\t"
- "mov %5, %%eax\n\t"
-#if defined(__x86_64__)
- "movd %%eax, %%xmm8\n\t"
- "pshufd $0x0, %%xmm8, %%xmm8\n\t"
-#endif
- /* Zero the temporary register */
- "pxor %%xmm0, %%xmm0\n\t"
-
- "algo_ssse3_deinterlace_4field_bgra:\n\t"
-
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "movdqa (%0,%4), %%xmm2\n\t" // Load pbelow
- "pavgb %%xmm5, %%xmm2\n\t" // Average pabove and pbelow
- "pand %%xmm1, %%xmm2\n\t" // Filter out pixels in avg that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm2, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
-
- "sub %4, %0\n\t" // Restore pcurrent to pabove
- "sub %4, %1\n\t" // Restore pncurrent to pnabove
-
- /* Next pixels */
- "add $0x10, %0\n\t" // Add 16 to pcurrent
- "add $0x10, %1\n\t" // Add 16 to pncurrent
-
- /* Check if we reached the row end */
- "cmp %2, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_bgra\n\t" // Go for another iteration
-
- /* Next row */
- "add %4, %0\n\t" // Add width to pcurrent
- "add %4, %1\n\t" // Add width to pncurrent
- "mov %0, %2\n\t"
- "add %4, %2\n\t" // Add width to max_ptr2
-
- /* Check if we reached the end */
- "cmp %3, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_bgra\n\t" // Go for another iteration
-
- /* Special case for the last line */
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "pand %%xmm1, %%xmm5\n\t" // Filter out pixels in pabove that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm5, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
- :
- : "r" (col1), "r" (col2), "r" (max_ptr2), "r" (max_ptr), "r" (row_width), "m" (threshold_val), "m" (*movemask2)
-#if defined(__x86_64__)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "%xmm8", "cc", "memory"
-#else
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "cc", "memory"
-#endif
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
-}
-
-/* ARGB SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
-void ssse3_deinterlace_4field_argb(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height) {
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
- __attribute__((aligned(16))) static const uint8_t movemask2[16] = {2,2,2,2,2,1,1,3,10,10,10,10,10,9,9,11};
-
- const uint32_t threshold_val = threshold;
-
- unsigned long row_width = width*4;
- uint8_t* max_ptr = col1 + (row_width * (height-2));
- uint8_t* max_ptr2 = col1 + row_width;
-
- __asm__ __volatile__ (
- "mov $0x1F1F1F1F, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "movdqa %6, %%xmm3\n\t"
- "mov %5, %%eax\n\t"
-#if defined(__x86_64__)
- "movd %%eax, %%xmm8\n\t"
- "pshufd $0x0, %%xmm8, %%xmm8\n\t"
-#endif
- /* Zero the temporary register */
- "pxor %%xmm0, %%xmm0\n\t"
-
- "algo_ssse3_deinterlace_4field_argb:\n\t"
-
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "movdqa (%0,%4), %%xmm2\n\t" // Load pbelow
- "pavgb %%xmm5, %%xmm2\n\t" // Average pabove and pbelow
- "pand %%xmm1, %%xmm2\n\t" // Filter out pixels in avg that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm2, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
-
- "sub %4, %0\n\t" // Restore pcurrent to pabove
- "sub %4, %1\n\t" // Restore pncurrent to pnabove
-
- /* Next pixels */
- "add $0x10, %0\n\t" // Add 16 to pcurrent
- "add $0x10, %1\n\t" // Add 16 to pncurrent
-
- /* Check if we reached the row end */
- "cmp %2, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_argb\n\t" // Go for another iteration
-
- /* Next row */
- "add %4, %0\n\t" // Add width to pcurrent
- "add %4, %1\n\t" // Add width to pncurrent
- "mov %0, %2\n\t"
- "add %4, %2\n\t" // Add width to max_ptr2
-
- /* Check if we reached the end */
- "cmp %3, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_argb\n\t" // Go for another iteration
-
- /* Special case for the last line */
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "pand %%xmm1, %%xmm5\n\t" // Filter out pixels in pabove that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm5, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
- :
- : "r" (col1), "r" (col2), "r" (max_ptr2), "r" (max_ptr), "r" (row_width), "m" (threshold_val), "m" (*movemask2)
-#if defined(__x86_64__)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "%xmm8", "cc", "memory"
-#else
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "cc", "memory"
-#endif
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
-}
-
-/* ABGR SSSE3 */
-#if defined(__i386__) || defined(__x86_64__)
-__attribute__((noinline,__target__("ssse3")))
-#endif
-void ssse3_deinterlace_4field_abgr(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height) {
-#if ((defined(__i386__) || defined(__x86_64__) || defined(ZM_KEEP_SSE)) && !defined(ZM_STRIP_SSE))
- __attribute__((aligned(16))) static const uint8_t movemask2[16] = {2,2,2,2,2,3,3,1,10,10,10,10,10,11,11,9};
-
- const uint32_t threshold_val = threshold;
-
- unsigned long row_width = width*4;
- uint8_t* max_ptr = col1 + (row_width * (height-2));
- uint8_t* max_ptr2 = col1 + row_width;
-
- __asm__ __volatile__ (
- "mov $0x1F1F1F1F, %%eax\n\t"
- "movd %%eax, %%xmm4\n\t"
- "pshufd $0x0, %%xmm4, %%xmm4\n\t"
- "movdqa %6, %%xmm3\n\t"
- "mov %5, %%eax\n\t"
-#if defined(__x86_64__)
- "movd %%eax, %%xmm8\n\t"
- "pshufd $0x0, %%xmm8, %%xmm8\n\t"
-#endif
- /* Zero the temporary register */
- "pxor %%xmm0, %%xmm0\n\t"
-
- "algo_ssse3_deinterlace_4field_abgr:\n\t"
-
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "movdqa (%0,%4), %%xmm2\n\t" // Load pbelow
- "pavgb %%xmm5, %%xmm2\n\t" // Average pabove and pbelow
- "pand %%xmm1, %%xmm2\n\t" // Filter out pixels in avg that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm2, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
-
- "sub %4, %0\n\t" // Restore pcurrent to pabove
- "sub %4, %1\n\t" // Restore pncurrent to pnabove
-
- /* Next pixels */
- "add $0x10, %0\n\t" // Add 16 to pcurrent
- "add $0x10, %1\n\t" // Add 16 to pncurrent
-
- /* Check if we reached the row end */
- "cmp %2, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_abgr\n\t" // Go for another iteration
-
- /* Next row */
- "add %4, %0\n\t" // Add width to pcurrent
- "add %4, %1\n\t" // Add width to pncurrent
- "mov %0, %2\n\t"
- "add %4, %2\n\t" // Add width to max_ptr2
-
- /* Check if we reached the end */
- "cmp %3, %0\n\t"
- "jb algo_ssse3_deinterlace_4field_abgr\n\t" // Go for another iteration
-
- /* Special case for the last line */
- /* Load pabove into xmm1 and pnabove into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm5\n\t" /* Keep backup of pabove in xmm5 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
- "movdqa %%xmm1, %%xmm7\n\t" /* Backup of delta2 in xmm7 for now */
-
- /* Next row */
- "add %4, %0\n\t"
- "add %4, %1\n\t"
-
- /* Load pcurrent into xmm1 and pncurrent into xmm2 */
- "movdqa (%0), %%xmm1\n\t"
- "movdqa (%1), %%xmm2\n\t"
- "movdqa %%xmm1, %%xmm6\n\t" /* Keep backup of pcurrent in xmm6 */
- "psrlq $0x3, %%xmm1\n\t"
- "psrlq $0x3, %%xmm2\n\t"
- "pand %%xmm4, %%xmm1\n\t"
- "pand %%xmm4, %%xmm2\n\t"
- "psubb %%xmm2, %%xmm1\n\t"
- "pabsb %%xmm1, %%xmm2\n\t"
- "movdqa %%xmm2, %%xmm1\n\t"
- "punpckldq %%xmm1, %%xmm1\n\t"
- "pshufb %%xmm3, %%xmm1\n\t"
- "psadbw %%xmm0, %%xmm1\n\t"
- "punpckhdq %%xmm2, %%xmm2\n\t"
- "pshufb %%xmm3, %%xmm2\n\t"
- "psadbw %%xmm0, %%xmm2\n\t"
- "packuswb %%xmm2, %%xmm1\n\t"
-
- "pavgb %%xmm7, %%xmm1\n\t" // Average the two deltas together
-
-#if defined(__x86_64__)
- "pcmpgtd %%xmm8, %%xmm1\n\t" // Compare average delta with the threshold
-#else
- "movd %%eax, %%xmm7\n\t" // Setup the threshold
- "pshufd $0x0, %%xmm7, %%xmm7\n\t"
-
- "pcmpgtd %%xmm7, %%xmm1\n\t" // Compare average delta with the threshold
-#endif
- "pand %%xmm1, %%xmm5\n\t" // Filter out pixels in pabove that shouldn't be copied
- "pandn %%xmm6, %%xmm1\n\t" // Filter out pixels in pcurrent that should be replaced
-
- "por %%xmm5, %%xmm1\n\t" // Put the new values in pcurrent
- "movntdq %%xmm1, (%0)\n\t" // Write pcurrent
- :
- : "r" (col1), "r" (col2), "r" (max_ptr2), "r" (max_ptr), "r" (row_width), "m" (threshold_val), "m" (*movemask2)
-#if defined(__x86_64__)
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "%xmm8", "cc", "memory"
-#else
- : "%eax", "%xmm0", "%xmm1", "%xmm2", "%xmm3", "%xmm4", "%xmm5", "%xmm6", "%xmm7", "cc", "memory"
-#endif
- );
-#else
- Panic("SSE function called on a non x86\\x86-64 platform");
-#endif
-}
diff --git a/src/zm_image.h b/src/zm_image.h
index 3e8b3969a..0a90c5c23 100644
--- a/src/zm_image.h
+++ b/src/zm_image.h
@@ -299,6 +299,9 @@ void std_convert_argb_gray8(const uint8_t* col1, uint8_t* result, unsigned long
void std_convert_abgr_gray8(const uint8_t* col1, uint8_t* result, unsigned long count);
void std_convert_yuyv_gray8(const uint8_t* col1, uint8_t* result, unsigned long count);
void ssse3_convert_rgba_gray8(const uint8_t* col1, uint8_t* result, unsigned long count);
+void ssse3_convert_bgra_gray8(const uint8_t* col1, uint8_t* result, unsigned long count);
+void ssse3_convert_argb_gray8(const uint8_t* col1, uint8_t* result, unsigned long count);
+void ssse3_convert_abgr_gray8(const uint8_t* col1, uint8_t* result, unsigned long count);
void ssse3_convert_yuyv_gray8(const uint8_t* col1, uint8_t* result, unsigned long count);
void zm_convert_yuyv_rgb(const uint8_t* col1, uint8_t* result, unsigned long count);
void zm_convert_yuyv_rgba(const uint8_t* col1, uint8_t* result, unsigned long count);
@@ -315,8 +318,3 @@ void std_deinterlace_4field_rgba(uint8_t* col1, uint8_t* col2, unsigned int thre
void std_deinterlace_4field_bgra(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
void std_deinterlace_4field_argb(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
void std_deinterlace_4field_abgr(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
-void ssse3_deinterlace_4field_gray8(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
-void ssse3_deinterlace_4field_rgba(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
-void ssse3_deinterlace_4field_bgra(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
-void ssse3_deinterlace_4field_argb(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
-void ssse3_deinterlace_4field_abgr(uint8_t* col1, uint8_t* col2, unsigned int threshold, unsigned int width, unsigned int height);
diff --git a/src/zm_monitor.cpp b/src/zm_monitor.cpp
index 3decdf69f..eebad7291 100644
--- a/src/zm_monitor.cpp
+++ b/src/zm_monitor.cpp
@@ -638,6 +638,7 @@ Monitor::~Monitor() {
close( map_fd );
if ( purpose == CAPTURE ) {
+ // How about we store this in the object on instantiation so that we don't have to do this again.
char mmap_path[PATH_MAX] = "";
snprintf( mmap_path, sizeof(mmap_path), "%s/zm.mmap.%d", config.path_map, id );
@@ -1379,7 +1380,8 @@ bool Monitor::Analyse() {
}
}
} // end if section_length
- if ( !event ) {
+
+ if ( ! event ) {
// Create event
event = new Event( this, *timestamp, "Continuous", noteSetMap, videoRecording );
@@ -1442,7 +1444,7 @@ bool Monitor::Analyse() {
}
event->AddFrames( pre_event_images, images, timestamps );
}
- }
+ } // end if false or config.overlap_timed_events
} // end if ! event
}
if ( score ) {
@@ -1618,7 +1620,8 @@ bool Monitor::Analyse() {
}
shared_data->state = state = IDLE;
last_section_mod = 0;
- }
+ } // end if ( trigger_data->trigger_state != TRIGGER_OFF )
+
if ( (!signal_change && signal) && (function == MODECT || function == MOCORD) ) {
if ( state == ALARM ) {
ref_image.Blend( *snap_image, alarm_ref_blend_perc );
@@ -1627,9 +1630,9 @@ bool Monitor::Analyse() {
}
}
last_signal = signal;
- }
+ } // end if Enabled()
- shared_data->last_read_index = index%image_buffer_count;
+ shared_data->last_read_index = index % image_buffer_count;
//shared_data->last_read_time = image_buffer[index].timestamp->tv_sec;
shared_data->last_read_time = now.tv_sec;
@@ -3584,7 +3587,7 @@ bool MonitorStream::sendFrame( const char *filepath, struct timeval *timestamp )
fprintf( stdout, "Content-Length: %d\r\n", img_buffer_size );
fprintf( stdout, "Content-Type: image/jpeg\r\n\r\n" );
if ( fwrite( img_buffer, img_buffer_size, 1, stdout ) != 1 ) {
- if ( !zm_terminate )
+ if ( ! zm_terminate )
Error( "Unable to send stream frame: %s", strerror(errno) );
return( false );
}
@@ -3678,7 +3681,7 @@ bool MonitorStream::sendFrame( Image *image, struct timeval *timestamp ) {
}
last_frame_sent = TV_2_FLOAT( now );
return( true );
-}
+} // end bool MonitorStream::sendFrame( Image *image, struct timeval *timestamp )
void MonitorStream::runStream() {
if ( type == STREAM_SINGLE ) {
@@ -3804,7 +3807,7 @@ void MonitorStream::runStream() {
if ( temp_index%frame_mod == 0 ) {
Debug( 2, "Sending delayed frame %d", temp_index );
// Send the next frame
- if ( !sendFrame( temp_image_buffer[temp_index].file_name, &temp_image_buffer[temp_index].timestamp ) )
+ if ( ! sendFrame( temp_image_buffer[temp_index].file_name, &temp_image_buffer[temp_index].timestamp ) )
zm_terminate = true;
memcpy( &last_frame_timestamp, &(swap_image->timestamp), sizeof(last_frame_timestamp) );
//frame_sent = true;
diff --git a/src/zm_remote_camera_http.cpp b/src/zm_remote_camera_http.cpp
index f1e6228a2..95c8ae507 100644
--- a/src/zm_remote_camera_http.cpp
+++ b/src/zm_remote_camera_http.cpp
@@ -267,7 +267,7 @@ int RemoteCameraHttp::ReadData( Buffer &buffer, unsigned int bytes_expected ) {
Debug( 2, "Socket closed" );
//Disconnect(); // Disconnect is done outside of ReadData now.
return( -1 );
- } else if ( bytes_read < total_bytes_to_read ) {
+ } else if ( (unsigned int)bytes_read < total_bytes_to_read ) {
Error( "Incomplete read, expected %d, got %d", total_bytes_to_read, bytes_read );
return( -1 );
}
diff --git a/src/zm_utils.cpp b/src/zm_utils.cpp
index ffd239c65..988a5c9ea 100644
--- a/src/zm_utils.cpp
+++ b/src/zm_utils.cpp
@@ -250,30 +250,50 @@ void hwcaps_detect() {
/* x86 or x86-64 processor */
uint32_t r_edx, r_ecx, r_ebx;
+#ifdef __x86_64__
__asm__ __volatile__(
+ "push %%rbx\n\t"
"mov $0x0,%%ecx\n\t"
"mov $0x7,%%eax\n\t"
"cpuid\n\t"
-#ifdef __x86_64__
"push %%rbx\n\t"
-#else
- "push %%ebx\n\t"
-#endif
"mov $0x1,%%eax\n\t"
"cpuid\n\t"
-#ifdef __x86_64__
+ "pop %%rax\n\t"
"pop %%rbx\n\t"
-#else
- "pop %%ebx\n\t"
-#endif
- : "=d" (r_edx), "=c" (r_ecx), "=b" (r_ebx)
+ : "=d" (r_edx), "=c" (r_ecx), "=a" (r_ebx)
+ :
:
- : "%eax"
);
-
+#else
+ __asm__ __volatile__(
+ "push %%ebx\n\t"
+ "mov $0x0,%%ecx\n\t"
+ "mov $0x7,%%eax\n\t"
+ "cpuid\n\t"
+ "push %%ebx\n\t"
+ "mov $0x1,%%eax\n\t"
+ "cpuid\n\t"
+ "pop %%eax\n\t"
+ "pop %%ebx\n\t"
+ : "=d" (r_edx), "=c" (r_ecx), "=a" (r_ebx)
+ :
+ :
+ );
+#endif
+
if (r_ebx & 0x00000020) {
sseversion = 52; /* AVX2 */
Debug(1,"Detected a x86\\x86-64 processor with AVX2");
+ } else if (r_ecx & 0x10000000) {
+ sseversion = 51; /* AVX */
+ Debug(1,"Detected a x86\\x86-64 processor with AVX");
+ } else if (r_ecx & 0x00100000) {
+ sseversion = 42; /* SSE4.2 */
+ Debug(1,"Detected a x86\\x86-64 processor with SSE4.2");
+ } else if (r_ecx & 0x00080000) {
+ sseversion = 41; /* SSE4.1 */
+ Debug(1,"Detected a x86\\x86-64 processor with SSE4.1");
} else if (r_ecx & 0x00000200) {
sseversion = 35; /* SSSE3 */
Debug(1,"Detected a x86\\x86-64 processor with SSSE3");
diff --git a/src/zm_videostore.cpp b/src/zm_videostore.cpp
index 586b9165a..b4d2ef741 100644
--- a/src/zm_videostore.cpp
+++ b/src/zm_videostore.cpp
@@ -444,11 +444,12 @@ if ( audio_output_stream ) {
av_make_error_string(ret).c_str());
}
- prevDts = 0;
- video_start_pts = 0;
- video_start_dts = 0;
- audio_start_pts = 0;
- audio_start_dts = 0;
+ video_last_pts = 0;
+ video_last_dts = 0;
+ audio_last_pts = 0;
+ audio_last_dts = 0;
+ previous_pts = 0;
+ previous_dts = 0;
filter_in_rescale_delta_last = AV_NOPTS_VALUE;
@@ -551,45 +552,63 @@ void VideoStore::dumpPacket( AVPacket *pkt ){
}
int VideoStore::writeVideoFramePacket( AVPacket *ipkt ) {
-
-
- Debug(4, "writeVideoFrame init_packet");
av_init_packet(&opkt);
-if ( 1 ) {
//Scale the PTS of the outgoing packet to be the correct time base
if (ipkt->pts != AV_NOPTS_VALUE) {
- if ( (!video_start_pts) || (video_start_pts > ipkt->pts) ) {
- Debug(1, "Resetting video_start_pts from (%d) to (%d)", video_start_pts, ipkt->pts );
- //never gets set, so the first packet can set it.
- video_start_pts = ipkt->pts;
+
+ if ( ! video_last_pts ) {
+ // This is the first packet.
+ opkt.pts = 0;
+ Debug(2, "Starting video video_last_pts will become (%d)", ipkt->pts );
+ } else {
+ if ( ipkt->pts < video_last_pts ) {
+ Debug(1, "Resetting video_last_pts from (%d) to (%d)", video_last_pts, ipkt->pts );
+ // wrap around, need to figure out the distance FIXME having this wrong should cause a jump, but then play ok?
+ opkt.pts = previous_pts + av_rescale_q( ipkt->pts, video_input_stream->time_base, video_output_stream->time_base);
+ } else {
+ opkt.pts = previous_pts + av_rescale_q( ipkt->pts - video_last_pts, video_input_stream->time_base, video_output_stream->time_base);
+ }
}
- opkt.pts = av_rescale_q(ipkt->pts - video_start_pts, video_input_stream->time_base, video_output_stream->time_base);
- //- ost_tb_start_time;
- Debug(3, "opkt.pts = %d from ipkt->pts(%d) - startPts(%d)", opkt.pts, ipkt->pts, video_start_pts );
+ Debug(3, "opkt.pts = %d from ipkt->pts(%d) - last_pts(%d)", opkt.pts, ipkt->pts, video_last_pts );
+ video_last_pts = ipkt->pts;
} else {
Debug(3, "opkt.pts = undef");
opkt.pts = AV_NOPTS_VALUE;
}
//Scale the DTS of the outgoing packet to be the correct time base
- if(ipkt->dts == AV_NOPTS_VALUE) {
- // why are we using cur_dts instead of packet.dts?
- if ( (!video_start_dts) || (video_start_dts > video_input_stream->cur_dts) ) {
- Debug(1, "Resetting video_start_dts from (%d) to (%d) p.dts was (%d)", video_start_dts, video_input_stream->cur_dts, ipkt->dts );
- video_start_dts = video_input_stream->cur_dts;
- }
- opkt.dts = av_rescale_q(video_input_stream->cur_dts - video_start_dts, AV_TIME_BASE_Q, video_output_stream->time_base);
- Debug(3, "opkt.dts = %d from video_input_stream->cur_dts(%d) - startDts(%d)",
- opkt.dts, video_input_stream->cur_dts, video_start_dts
- );
+
+ // Just because the input stream wraps, doesn't mean the output needs to. Really, if we are limiting ourselves to 10min segments I can't imagine every wrapping in the output. So need to handle input wrap, without causing output wrap.
+ if ( ! video_last_dts ) {
+ // This is the first packet.
+ opkt.dts = 0;
+ Debug(1, "Starting video video_last_pts will become (%d)", ipkt->dts );
} else {
- if ( (!video_start_dts) || (video_start_dts > ipkt->dts) ) {
- Debug(1, "Resetting video_start_dts from (%d) to (%d)", video_start_dts, ipkt->dts );
- video_start_dts = ipkt->dts;
+ if ( ipkt->dts == AV_NOPTS_VALUE ) {
+ // why are we using cur_dts instead of packet.dts? I think cur_dts is in AV_TIME_BASE_Q, but ipkt.dts is in video_input_stream->time_base
+ if ( video_input_stream->cur_dts < video_last_dts ) {
+ Debug(1, "Resetting video_last_dts from (%d) to (%d) p.dts was (%d)", video_last_dts, video_input_stream->cur_dts, ipkt->dts );
+ opkt.dts = previous_dts + av_rescale_q(video_input_stream->cur_dts, AV_TIME_BASE_Q, video_output_stream->time_base);
+ } else {
+ opkt.dts = previous_dts + av_rescale_q(video_input_stream->cur_dts - video_last_dts, AV_TIME_BASE_Q, video_output_stream->time_base);
+ }
+ Debug(3, "opkt.dts = %d from video_input_stream->cur_dts(%d) - previus_dts(%d)",
+ opkt.dts, video_input_stream->cur_dts, video_last_dts
+ );
+ video_last_dts = video_input_stream->cur_dts;
+ } else {
+ if ( ipkt->dts < video_last_dts ) {
+ Debug(1, "Resetting video_last_dts from (%d) to (%d)", video_last_dts, ipkt->dts );
+ opkt.dts = previous_dts + av_rescale_q( ipkt->dts, video_input_stream->time_base, video_output_stream->time_base);
+ } else {
+ opkt.dts = previous_dts + av_rescale_q( ipkt->dts - video_last_dts, video_input_stream->time_base, video_output_stream->time_base);
+ }
+ Debug(3, "opkt.dts = %d from ipkt.dts(%d) - previus_dts(%d)",
+ opkt.dts, ipkt->dts, video_last_dts
+ );
+ video_last_dts = ipkt->dts;
}
- opkt.dts = av_rescale_q(ipkt->dts - video_start_dts, video_input_stream->time_base, video_output_stream->time_base);
- Debug(3, "opkt.dts = %d from ipkt->dts(%d) - startDts(%d)", opkt.dts, ipkt->dts, video_start_dts );
}
if ( opkt.dts > opkt.pts ) {
Debug( 1, "opkt.dts(%d) must be <= opkt.pts(%d). Decompression must happen before presentation.", opkt.dts, opkt.pts );
@@ -597,20 +616,6 @@ if ( 1 ) {
}
opkt.duration = av_rescale_q(ipkt->duration, video_input_stream->time_base, video_output_stream->time_base);
-} else {
- // Using this results in super fast video output, might be because it should be using the codec time base instead of stream tb
- //av_packet_rescale_ts( &opkt, video_input_stream->time_base, video_output_stream->time_base );
-}
-
-if ( opkt.dts != AV_NOPTS_VALUE ) {
- int64_t max = video_output_stream->cur_dts + !(oc->oformat->flags & AVFMT_TS_NONSTRICT);
- if ( video_output_stream->cur_dts && ( video_output_stream->cur_dts != AV_NOPTS_VALUE ) && ( max > opkt.dts ) ) {
- Warning("st:%d PTS: %" PRId64 " DTS: %" PRId64 " < %" PRId64 " invalid, clipping", opkt.stream_index, opkt.pts, opkt.dts, max);
- if( opkt.pts >= opkt.dts)
- opkt.pts = FFMAX(opkt.pts, max);
- opkt.dts = max;
- }
-}
opkt.flags = ipkt->flags;
opkt.pos=-1;
@@ -650,14 +655,15 @@ Debug(4, "Not video and RAWPICTURE");
dumpPacket( ipkt);
dumpPacket(&opkt);
- } else if ((prevDts > 0) && (prevDts > opkt.dts)) {
- Warning("%s:%d: DTS out of order: %lld \u226E %lld; discarding frame", __FILE__, __LINE__, prevDts, opkt.dts);
- prevDts = opkt.dts;
+ } else if ((previous_dts > 0) && (previous_dts > opkt.dts)) {
+ Warning("%s:%d: DTS out of order: %lld \u226E %lld; discarding frame", __FILE__, __LINE__, previous_dts, opkt.dts);
+ previous_dts = opkt.dts;
dumpPacket(&opkt);
} else {
- prevDts = opkt.dts; // Unsure if av_interleaved_write_frame() clobbers opkt.dts when out of order, so storing in advance
+ previous_dts = opkt.dts; // Unsure if av_interleaved_write_frame() clobbers opkt.dts when out of order, so storing in advance
+ previous_pts = opkt.pts;
ret = av_interleaved_write_frame(oc, &opkt);
if(ret<0){
// There's nothing we can really do if the frame is rejected, just drop it and get on with the next
@@ -689,34 +695,45 @@ int VideoStore::writeAudioFramePacket( AVPacket *ipkt ) {
#if 1
//Scale the PTS of the outgoing packet to be the correct time base
if ( ipkt->pts != AV_NOPTS_VALUE ) {
- if ( (!audio_start_pts) || ( audio_start_pts > ipkt->pts ) ) {
- Debug(1, "Resetting audeo_start_pts from (%d) to (%d)", audio_start_pts, ipkt->pts );
- //never gets set, so the first packet can set it.
- audio_start_pts = ipkt->pts;
+ if ( !audio_last_pts ) {
+ opkt.pts = 0;
+ } else {
+ if ( audio_last_pts > ipkt->pts ) {
+ Debug(1, "Resetting audeo_start_pts from (%d) to (%d)", audio_last_pts, ipkt->pts );
+ }
+ opkt.pts = previous_pts + av_rescale_q(ipkt->pts - audio_last_pts, audio_input_stream->time_base, audio_output_stream->time_base);
+ Debug(2, "opkt.pts = %d from ipkt->pts(%d) - last_pts(%d)", opkt.pts, ipkt->pts, audio_last_pts );
}
- opkt.pts = av_rescale_q(ipkt->pts - audio_start_pts, audio_input_stream->time_base, audio_output_stream->time_base);
- Debug(2, "opkt.pts = %d from ipkt->pts(%d) - startPts(%d)", opkt.pts, ipkt->pts, audio_start_pts );
+ audio_last_pts = ipkt->pts;
} else {
Debug(2, "opkt.pts = undef");
+ opkt.pts = AV_NOPTS_VALUE;
}
//Scale the DTS of the outgoing packet to be the correct time base
- if(ipkt->dts == AV_NOPTS_VALUE) {
- if ( (!audio_start_dts) || (audio_start_dts > audio_input_stream->cur_dts ) ) {
- Debug(1, "Resetting audio_start_pts from (%d) to cur_dts (%d)", audio_start_dts, audio_input_stream->cur_dts );
- audio_start_dts = audio_input_stream->cur_dts;
- }
- opkt.dts = av_rescale_q(audio_input_stream->cur_dts - audio_start_dts, AV_TIME_BASE_Q, audio_output_stream->time_base);
- Debug(2, "opkt.dts = %d from video_input_stream->cur_dts(%d) - startDts(%d)",
- opkt.dts, audio_input_stream->cur_dts, audio_start_dts
- );
+ if ( ! audio_last_dts ) {
+ opkt.dts = 0;
} else {
- if ( ( ! audio_start_dts ) || ( audio_start_dts > ipkt->dts ) ) {
- Debug(1, "Resetting audeo_start_dts from (%d) to (%d)", audio_start_dts, ipkt->dts );
- audio_start_dts = ipkt->dts;
+ if( ipkt->dts == AV_NOPTS_VALUE ) {
+ // So if the input has no dts assigned... still need an output dts... so we use cur_dts?
+
+ if ( audio_last_dts > audio_input_stream->cur_dts ) {
+ Debug(1, "Resetting audio_last_pts from (%d) to cur_dts (%d)", audio_last_dts, audio_input_stream->cur_dts );
+ opkt.dts = previous_dts + av_rescale_q( audio_input_stream->cur_dts, AV_TIME_BASE_Q, audio_output_stream->time_base);
+ } else {
+ opkt.dts = previous_dts + av_rescale_q( audio_input_stream->cur_dts - audio_last_dts, AV_TIME_BASE_Q, audio_output_stream->time_base);
+ }
+ audio_last_dts = audio_input_stream->cur_dts;
+ Debug(2, "opkt.dts = %d from video_input_stream->cur_dts(%d) - last_dts(%d)", opkt.dts, audio_input_stream->cur_dts, audio_last_dts );
+ } else {
+ if ( audio_last_dts > ipkt->dts ) {
+ Debug(1, "Resetting audio_last_dts from (%d) to (%d)", audio_last_dts, ipkt->dts );
+ opkt.dts = previous_dts + av_rescale_q(ipkt->dts, audio_input_stream->time_base, audio_output_stream->time_base);
+ } else {
+ opkt.dts = previous_dts + av_rescale_q(ipkt->dts - audio_last_dts, audio_input_stream->time_base, audio_output_stream->time_base);
+ }
+ Debug(2, "opkt.dts = %d from ipkt->dts(%d) - last_dts(%d)", opkt.dts, ipkt->dts, audio_last_dts );
}
- opkt.dts = av_rescale_q(ipkt->dts - audio_start_dts, audio_input_stream->time_base, audio_output_stream->time_base);
- Debug(2, "opkt.dts = %d from ipkt->dts(%d) - startDts(%d)", opkt.dts, ipkt->dts, audio_start_dts );
}
if ( opkt.dts > opkt.pts ) {
Debug(1,"opkt.dts(%d) must be <= opkt.pts(%d). Decompression must happen before presentation.", opkt.dts, opkt.pts );
@@ -725,6 +742,7 @@ int VideoStore::writeAudioFramePacket( AVPacket *ipkt ) {
//opkt.pts = AV_NOPTS_VALUE;
//opkt.dts = AV_NOPTS_VALUE;
+ // I wonder if we could just use duration instead of all the hoop jumping above?
opkt.duration = av_rescale_q(ipkt->duration, audio_input_stream->time_base, audio_output_stream->time_base);
#else
#endif
diff --git a/src/zm_videostore.h b/src/zm_videostore.h
index 2d67e8145..b9c68bd4e 100644
--- a/src/zm_videostore.h
+++ b/src/zm_videostore.h
@@ -54,15 +54,16 @@ private:
bool keyframeMessage;
int keyframeSkipNumber;
- int64_t video_start_pts;
- int64_t video_start_dts;
- int64_t audio_start_pts;
- int64_t audio_start_dts;
+ // These are for input
+ int64_t video_last_pts;
+ int64_t video_last_dts;
+ int64_t audio_last_pts;
+ int64_t audio_last_dts;
- int64_t start_pts;
- int64_t start_dts;
+ // These are for output, should start at zero. We assume they do not wrap because we just aren't going to save files that big.
+ int64_t previous_pts;
+ int64_t previous_dts;
- int64_t prevDts;
int64_t filter_in_rescale_delta_last;
public:
diff --git a/src/zmc.cpp b/src/zmc.cpp
index c47a60d59..58b60e7a9 100644
--- a/src/zmc.cpp
+++ b/src/zmc.cpp
@@ -73,8 +73,7 @@ possible, this should run at more or less constant speed.
#include "zm_signal.h"
#include "zm_monitor.h"
-void Usage()
-{
+void Usage() {
fprintf( stderr, "zmc -d or -r -H -P -p or -f or -m \n" );
fprintf( stderr, "Options:\n" );
@@ -91,8 +90,7 @@ void Usage()
exit( 0 );
}
-int main( int argc, char *argv[] )
-{
+int main( int argc, char *argv[] ) {
self = argv[0];
srand( getpid() * time( 0 ) );
@@ -110,21 +108,19 @@ int main( int argc, char *argv[] )
{"protocol", 1, 0, 'r'},
{"host", 1, 0, 'H'},
{"port", 1, 0, 'P'},
- {"path", 1, 0, 'p'},
- {"file", 1, 0, 'f'},
+ {"path", 1, 0, 'p'},
+ {"file", 1, 0, 'f'},
{"monitor", 1, 0, 'm'},
{"help", 0, 0, 'h'},
{"version", 0, 0, 'v'},
{0, 0, 0, 0}
};
- while (1)
- {
+ while (1) {
int option_index = 0;
int c = getopt_long (argc, argv, "d:H:P:p:f:m:h:v", long_options, &option_index);
- if (c == -1)
- {
+ if (c == -1) {
break;
}
@@ -161,8 +157,7 @@ int main( int argc, char *argv[] )
}
}
- if (optind < argc)
- {
+ if (optind < argc) {
fprintf( stderr, "Extraneous options, " );
while (optind < argc)
printf ("%s ", argv[optind++]);
@@ -171,37 +166,28 @@ int main( int argc, char *argv[] )
}
int modes = ( device[0]?1:0 + host[0]?1:0 + file[0]?1:0 + (monitor_id>0?1:0) );
- if ( modes > 1 )
- {
+ if ( modes > 1 ) {
fprintf( stderr, "Only one of device, host/port/path, file or monitor id allowed\n" );
Usage();
exit( 0 );
}
- if ( modes < 1 )
- {
+ if ( modes < 1 ) {
fprintf( stderr, "One of device, host/port/path, file or monitor id must be specified\n" );
Usage();
exit( 0 );
}
char log_id_string[32] = "";
- if ( device[0] )
- {
+ if ( device[0] ) {
const char *slash_ptr = strrchr( device, '/' );
snprintf( log_id_string, sizeof(log_id_string), "zmc_d%s", slash_ptr?slash_ptr+1:device );
- }
- else if ( host[0] )
- {
+ } else if ( host[0] ) {
snprintf( log_id_string, sizeof(log_id_string), "zmc_h%s", host );
- }
- else if ( file[0] )
- {
+ } else if ( file[0] ) {
const char *slash_ptr = strrchr( file, '/' );
snprintf( log_id_string, sizeof(log_id_string), "zmc_f%s", slash_ptr?slash_ptr+1:file );
- }
- else
- {
+ } else {
snprintf( log_id_string, sizeof(log_id_string), "zmc_m%d", monitor_id );
}
@@ -214,35 +200,26 @@ int main( int argc, char *argv[] )
Monitor **monitors = 0;
int n_monitors = 0;
#if ZM_HAS_V4L
- if ( device[0] )
- {
+ if ( device[0] ) {
n_monitors = Monitor::LoadLocalMonitors( device, monitors, Monitor::CAPTURE );
- }
- else
+ } else
#endif // ZM_HAS_V4L
- if ( host[0] )
- {
+ if ( host[0] ) {
if ( !port )
port = "80";
n_monitors = Monitor::LoadRemoteMonitors( protocol, host, port, path, monitors, Monitor::CAPTURE );
- }
- else if ( file[0] )
- {
+ } else if ( file[0] ) {
n_monitors = Monitor::LoadFileMonitors( file, monitors, Monitor::CAPTURE );
- }
- else
- {
+ } else {
Monitor *monitor = Monitor::Load( monitor_id, true, Monitor::CAPTURE );
- if ( monitor )
- {
+ if ( monitor ) {
monitors = new Monitor *[1];
monitors[0] = monitor;
n_monitors = 1;
}
}
- if ( !n_monitors )
- {
+ if ( !n_monitors ) {
Error( "No monitors found" );
exit ( -1 );
}
@@ -259,8 +236,7 @@ int main( int argc, char *argv[] )
sigaddset( &block_set, SIGUSR2 );
monitors[0]->setStartupTime( (time_t)time(NULL) );
- if ( monitors[0]->PrimeCapture() < 0 )
- {
+ if ( monitors[0]->PrimeCapture() < 0 ) {
Error( "Failed to prime capture of initial monitor" );
exit( -1 );
}
@@ -269,8 +245,7 @@ int main( int argc, char *argv[] )
long *alarm_capture_delays = new long[n_monitors];
long *next_delays = new long[n_monitors];
struct timeval * last_capture_times = new struct timeval[n_monitors];
- for ( int i = 0; i < n_monitors; i++ )
- {
+ for ( int i = 0; i < n_monitors; i++ ) {
last_capture_times[i].tv_sec = last_capture_times[i].tv_usec = 0;
capture_delays[i] = monitors[i]->GetCaptureDelay();
alarm_capture_delays[i] = monitors[i]->GetAlarmCaptureDelay();
@@ -279,18 +254,14 @@ int main( int argc, char *argv[] )
int result = 0;
struct timeval now;
struct DeltaTimeval delta_time;
- while( !zm_terminate )
- {
+ while( !zm_terminate ) {
sigprocmask( SIG_BLOCK, &block_set, 0 );
- for ( int i = 0; i < n_monitors; i++ )
- {
+ for ( int i = 0; i < n_monitors; i++ ) {
long min_delay = MAXINT;
gettimeofday( &now, NULL );
- for ( int j = 0; j < n_monitors; j++ )
- {
- if ( last_capture_times[j].tv_sec )
- {
+ for ( int j = 0; j < n_monitors; j++ ) {
+ if ( last_capture_times[j].tv_sec ) {
DELTA_TIMEVAL( delta_time, now, last_capture_times[j], DT_PREC_3 );
if ( monitors[i]->GetState() == Monitor::ALARM )
next_delays[j] = alarm_capture_delays[j]-delta_time.delta;
@@ -298,48 +269,39 @@ int main( int argc, char *argv[] )
next_delays[j] = capture_delays[j]-delta_time.delta;
if ( next_delays[j] < 0 )
next_delays[j] = 0;
- }
- else
- {
+ } else {
next_delays[j] = 0;
}
- if ( next_delays[j] <= min_delay )
- {
+ if ( next_delays[j] <= min_delay ) {
min_delay = next_delays[j];
}
}
- if ( next_delays[i] <= min_delay || next_delays[i] <= 0 )
- {
- if ( monitors[i]->PreCapture() < 0 )
- {
+ if ( next_delays[i] <= min_delay || next_delays[i] <= 0 ) {
+ if ( monitors[i]->PreCapture() < 0 ) {
Error( "Failed to pre-capture monitor %d %d (%d/%d)", monitors[i]->Id(), monitors[i]->Name(), i+1, n_monitors );
zm_terminate = true;
result = -1;
break;
}
- if ( monitors[i]->Capture() < 0 )
- {
+ if ( monitors[i]->Capture() < 0 ) {
Error( "Failed to capture image from monitor %d %s (%d/%d)", monitors[i]->Id(), monitors[i]->Name(), i+1, n_monitors );
zm_terminate = true;
result = -1;
break;
}
- if ( monitors[i]->PostCapture() < 0 )
- {
+ if ( monitors[i]->PostCapture() < 0 ) {
Error( "Failed to post-capture monitor %d %s (%d/%d)", monitors[i]->Id(), monitors[i]->Name(), i+1, n_monitors );
zm_terminate = true;
result = -1;
break;
}
- if ( next_delays[i] > 0 )
- {
+ if ( next_delays[i] > 0 ) {
gettimeofday( &now, NULL );
DELTA_TIMEVAL( delta_time, now, last_capture_times[i], DT_PREC_3 );
long sleep_time = next_delays[i]-delta_time.delta;
- if ( sleep_time > 0 )
- {
+ if ( sleep_time > 0 ) {
usleep( sleep_time*(DT_MAXGRAN/DT_PREC_3) );
}
}
@@ -349,8 +311,7 @@ int main( int argc, char *argv[] )
} // end foreach n_monitors
sigprocmask( SIG_UNBLOCK, &block_set, 0 );
} // end while ! zm_terminate
- for ( int i = 0; i < n_monitors; i++ )
- {
+ for ( int i = 0; i < n_monitors; i++ ) {
delete monitors[i];
}
delete [] monitors;
diff --git a/src/zms.cpp b/src/zms.cpp
index aed29af35..4deacb03b 100644
--- a/src/zms.cpp
+++ b/src/zms.cpp
@@ -161,9 +161,11 @@ int main( int argc, const char *argv[] )
{
if ( !strcmp( name, "user" ) ) {
username = UriDecode( value );
+ Debug( 1, "Have %s for username", username.c_str() );
}
if ( !strcmp( name, "pass" ) ) {
- password = UriDecode( password );
+ password = UriDecode( value );
+ Debug( 1, "Have %s for password", password.c_str() );
}
}
}
@@ -183,12 +185,16 @@ int main( int argc, const char *argv[] )
{
if ( *auth ) {
user = zmLoadAuthUser( auth, config.auth_hash_ips );
+ } else {
+ Debug( 1, "Need both username and password" );
}
}
//else if ( strcmp( config.auth_relay, "plain" ) == 0 )
{
if ( username.length() && password.length() ) {
user = zmLoadUser( username.c_str(), password.c_str() );
+ } else {
+ Debug( 1, "Need both username and password" );
}
}
} // auth is none or something else
diff --git a/web/includes/actions.php b/web/includes/actions.php
index 1f0e0ec47..d306c3bbc 100644
--- a/web/includes/actions.php
+++ b/web/includes/actions.php
@@ -103,6 +103,7 @@ if ( !empty($action) ) {
userLogin( $username, $password );
$refreshParent = true;
$view = 'console';
+ $redirect = true;
} else if ( $action == 'logout' ) {
userLogout();
$refreshParent = true;
@@ -133,37 +134,50 @@ if ( !empty($action) ) {
$filterName = $_REQUEST['newFilterName'];
}
if ( $filterName ) {
- $sql = "REPLACE INTO Filters SET Name = ".dbEscape($filterName).",";
+ # Replace will teplace any filter with the same Id
+ # Since we aren't specifying the Id , this is effectively an insert
+ $sql = 'REPLACE INTO Filters SET Name = '.dbEscape($filterName).',';
} else {
$sql = 'UPDATE Filters SET';
- $endSql = "where Id = ".$_REQUEST['Id'];
+ $endSql = 'WHERE Id = '.$_REQUEST['Id'];
}
+
+ # endSql is only set if ! filterName... so... woulnd't this always be true
if ( !empty($filterName) || $endSql ) {
$_REQUEST['filter']['sort_field'] = validStr($_REQUEST['sort_field']);
$_REQUEST['filter']['sort_asc'] = validStr($_REQUEST['sort_asc']);
$_REQUEST['filter']['limit'] = validInt($_REQUEST['limit']);
- $sql .= " Query = ".dbEscape(jsonEncode($_REQUEST['filter']));
+ $sql .= ' Query = '.dbEscape(jsonEncode($_REQUEST['filter']));
if ( !empty($_REQUEST['AutoArchive']) )
- $sql .= ", AutoArchive = ".dbEscape($_REQUEST['AutoArchive']);
+ $sql .= ', AutoArchive = '.dbEscape($_REQUEST['AutoArchive']);
if ( !empty($_REQUEST['AutoVideo']) )
- $sql .= ", AutoVideo = ".dbEscape($_REQUEST['AutoVideo']);
+ $sql .= ', AutoVideo = '.dbEscape($_REQUEST['AutoVideo']);
if ( !empty($_REQUEST['AutoUpload']) )
- $sql .= ", AutoUpload = ".dbEscape($_REQUEST['AutoUpload']);
+ $sql .= ', AutoUpload = '.dbEscape($_REQUEST['AutoUpload']);
if ( !empty($_REQUEST['AutoEmail']) )
- $sql .= ", AutoEmail = ".dbEscape($_REQUEST['AutoEmail']);
+ $sql .= ', AutoEmail = '.dbEscape($_REQUEST['AutoEmail']);
if ( !empty($_REQUEST['AutoMessage']) )
- $sql .= ", AutoMessage = ".dbEscape($_REQUEST['AutoMessage']);
+ $sql .= ', AutoMessage = '.dbEscape($_REQUEST['AutoMessage']);
if ( !empty($_REQUEST['AutoExecute']) && !empty($_REQUEST['AutoExecuteCmd']) )
- $sql .= ", AutoExecute = ".dbEscape($_REQUEST['AutoExecute']).", AutoExecuteCmd = ".dbEscape($_REQUEST['AutoExecuteCmd']);
+ $sql .= ', AutoExecute = '.dbEscape($_REQUEST['AutoExecute']).", AutoExecuteCmd = ".dbEscape($_REQUEST['AutoExecuteCmd']);
if ( !empty($_REQUEST['AutoDelete']) )
- $sql .= ", AutoDelete = ".dbEscape($_REQUEST['AutoDelete']);
+ $sql .= ', AutoDelete = '.dbEscape($_REQUEST['AutoDelete']);
if ( !empty($_REQUEST['background']) )
- $sql .= ", Background = ".dbEscape($_REQUEST['background']);
+ $sql .= ', Background = '.dbEscape($_REQUEST['background']);
if ( !empty($_REQUEST['concurrent']) )
- $sql .= ", Concurrent = ".dbEscape($_REQUEST['concurrent']);
+ $sql .= ', Concurrent = '.dbEscape($_REQUEST['concurrent']);
$sql .= $endSql;
dbQuery( $sql );
- $refreshParent = true;
+ if ( $filterName ) {
+ $filter = dbFetchOne( 'SELECT * FROM Filters WHERE Name=?', NULL, array($filterName) );
+ if ( $filter ) {
+ # This won't work yet because refreshparent refreshes the old filter. Need to do a redirect instead of a refresh.
+ $_REQUEST['Id'] = $filter['Id'];
+ } else {
+ Error("No new Id despite new name");
+ }
+ }
+ $refreshParent = '/index.php?view=filter&Id='.$_REQUEST['Id'];
}
} // end if canedit events
} // end if action == filter
@@ -512,7 +526,7 @@ if ( !empty($action) ) {
dbQuery( "update TriggersX10 set ".implode( ", ", $x10Changes )." where MonitorId=?", array($mid) );
} elseif ( !$user['MonitorIds'] ) {
if ( !$x10Monitor ) {
- dbQuery( "insert into TriggersX10 set MonitorId = ?".implode( ", ", $x10Changes ), array( $mid ) );
+ dbQuery( "insert into TriggersX10 set MonitorId = ?, ".implode( ", ", $x10Changes ), array( $mid ) );
} else {
dbQuery( "delete from TriggersX10 where MonitorId = ?", array($mid) );
}
@@ -822,12 +836,13 @@ if ( !empty($action) ) {
if ( count( $changes ) ) {
if ( !empty($_REQUEST['uid']) ) {
dbQuery( "update Users set ".implode( ", ", $changes )." where Id = ?", array($_REQUEST['uid']) );
+ # If we are updating the logged in user, then update our session user data.
+ if ( $user and ( $dbUser['Username'] == $user['Username'] ) )
+ userLogin( $dbUser['Username'], $dbUser['Password'] );
} else {
dbQuery( "insert into Users set ".implode( ", ", $changes ) );
}
$refreshParent = true;
- if ( $dbUser['Username'] == $user['Username'] )
- userLogin( $dbUser['Username'], $dbUser['Password'] );
}
$view = 'none';
} elseif ( $action == 'state' ) {
diff --git a/web/includes/csrf/LICENSE.txt b/web/includes/csrf/LICENSE.txt
new file mode 100644
index 000000000..37b07717d
--- /dev/null
+++ b/web/includes/csrf/LICENSE.txt
@@ -0,0 +1,9 @@
+Copyright (c) 2008-2013, Edward Z. Yang
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
+
+ Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
+ Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/web/includes/csrf/NEWS.txt b/web/includes/csrf/NEWS.txt
new file mode 100644
index 000000000..66d52f6da
--- /dev/null
+++ b/web/includes/csrf/NEWS.txt
@@ -0,0 +1,69 @@
+
+ [[ news ]]
+
+1.0.4 released 2013-07-17
+
+ [SECURITY FIXES]
+
+ - When secret key was not explicitly set, it was not being used
+ by the csrf_hash() function. Thanks sparticvs for reporting.
+
+ [FEATURES]
+
+ - The default 'CSRF check failed' page now offers a handy 'Try
+ again' button, which resubmits the form.
+
+ [BUG FIXES]
+
+ - The fix for 1.0.3 inadvertantly turned off XMLHttpRequest
+ overloading for all browsers; it has now been fixed to only
+ apply to IE.
+
+1.0.3 released 2012-01-31
+
+ [BUG FIXES]
+
+ - Internet Explorer 8 adds support for XMLHttpRequest.prototype,
+ but this support is broken for method overloading. We
+ explicitly disable JavaScript overloading for Internet Explorer.
+ Thanks Kelly Lu for reporting.
+
+ - A global declaration was omitted, resulting in a variable
+ not being properly introduced in PHP 5.3. Thanks Whitney Beck for
+ reporting.
+
+1.0.2 released 2009-03-08
+
+ [SECURITY FIXES]
+
+ - Due to a typo, csrf-magic accidentally treated the secret key
+ as always present. This means that there was a possible CSRF
+ attack against users without any cookies. No attacks in the
+ wild were known at the time of this release. Thanks Jakub
+ Vrána for reporting.
+
+1.0.1 released 2008-11-02
+
+ [NEW FEATURES]
+
+ - Support for composite tokens; this also fixes a bug with using
+ IP-based tokens for users with cookies disabled.
+
+ - Native support cookie tokens; use csrf_conf('cookie', $name) to
+ specify the name of a cookie that the CSRF token should be
+ placed in. This is useful if you have a Squid cache, and need
+ to configure it to ignore this token.
+
+ - Tips/tricks section in README.txt.
+
+ - There is now a two hour expiration time on all tokens. This
+ can be modified using csrf_conf('expires', $seconds).
+
+ - ClickJacking protection using an iframe breaker. Disable with
+ csrf_conf('frame-breaker', false).
+
+ [BUG FIXES]
+
+ - CsrfMagic.send() incorrectly submitted GET requests twice,
+ once without the magic token and once with the token. Reported
+ by Kelly Lu .
diff --git a/web/includes/csrf/README.txt b/web/includes/csrf/README.txt
new file mode 100644
index 000000000..98d225dba
--- /dev/null
+++ b/web/includes/csrf/README.txt
@@ -0,0 +1,160 @@
+
+ [[ csrf-magic ]]
+
+Add the following line to the top of all web-accessible PHP pages. If you have
+a common file included by everything, put it there.
+
+ include_once '/path/to/csrf-magic.php';
+
+Do it, test it, then forget about it. csrf-magic is protecting you if nothing
+bad happens. Read on if you run into problems.
+
+
+ TABLE OF CONTENTS
+ + ------------------- +
+ 1. TIPS AND TRICKS
+ 2. AJAX
+ 3. CONFIGURE
+ 4. THANKS
+ 5. FOOTNOTES
+ + ------------------- +
+
+
+1. TIPS AND TRICKS
+
+ * If your JavaScript and AJAX is persistently getting errors, check the
+ AJAX section below on how to fix.
+
+ * The CSS overlay protection makes it impossible to display your website
+ in frame/iframe elements. You can disable it with
+ csrf_conf('frame-breaker', false) in your csrf_startup() function.
+
+ * csrf-magic will start a session. To disable, use csrf_conf('auto-session',
+ false) in your csrf_startup() function.
+
+ * The default error message is a little user unfriendly. Write your own
+ function which outputs an error message and set csrf_conf('callback',
+ 'myCallbackFunction') in your csrf_startup() function.
+
+ * Make sure csrf_conf('secret', 'ABCDEFG') has something random in it. If
+ the directory csrf-magic.php is in is writable, csrf-magic will generate
+ a secret key for you in the csrf-secret.php file.
+
+ * Remember you can use auto_prepend to include csrf-magic.php on all your
+ pages. You may want to create a stub file which you can include that
+ includes csrf-magic.php as well as performs configuration.
+
+ * The default expiration time for tokens is two hours. If you expect your
+ users to need longer to fill out forms, be sure to enable double
+ submission when the token is invalid.
+
+
+2. AJAX
+
+csrf-magic has the ability to dynamically rewrite AJAX requests which use
+XMLHttpRequest. However, due to the invasiveness of this procedure, it is
+not enabled by default. You can enable it by adding this code before you
+include csrf-magic.php.
+
+ function csrf_startup() {
+ csrf_conf('rewrite-js', '/web/path/to/csrf-magic.js');
+ }
+ // include_once '/path/to/csrf-magic.php';
+
+(Be sure to place csrf-magic.js somewhere web accessible).
+
+The default method CSRF Magic uses to rewrite AJAX requests will
+only work for browsers with support for XmlHttpRequest.prototype (this excludes
+all versions of Internet Explorer). See this page for more information:
+http://stackoverflow.com/questions/664315/internet-explorer-8-prototypes-and-xmlhttprequest
+
+However, csrf-magic.js will
+automatically detect and play nice with the following JavaScript frameworks:
+
+ * jQuery
+ * Prototype
+ * MooTools
+ * Ext
+ * Dojo
+
+(Note 2013-07-16: It has been a long time since this manual support has
+been updated, and some JavaScript libraries have placed their copies of XHR
+in local variables in closures, which makes it difficult for us to monkey-patch
+it in automatically.)
+
+To rewrite your own JavaScript library to use csrf-magic.js, you should modify
+your function that generates XMLHttpRequest to have this at the end:
+
+ return new CsrfMagic(xhrObject);
+
+With whatever xhrObject may be. If you have literal instances of XMLHttpRequest
+in your code, find and replace ''new XMLHttpRequest'' with ''new CsrfMagic''
+(CsrfMagic will automatically instantiate an XMLHttpRequest object in a
+cross-platform manner as necessary).
+
+If you don't want csrf-magic monkeying around with your XMLHttpRequest object,
+you can manually rewrite your AJAX code to include the variable. The important
+information is stored in the global variables csrfMagicName and csrfMagicToken.
+CsrfMagic.process may also be of interest, as it takes one parameter, a
+querystring, and prepends the CSRF token to the value.
+
+
+3. CONFIGURE
+
+csrf-magic has some configuration options that you can set inside the
+csrf_startup() function. They are described in csrf-magic.php, and you can
+set them using the convenience function csrf_conf($name, $value).
+
+For example, this is a recommended configuration:
+
+ /**
+ * This is a function that gets called if a csrf check fails. csrf-magic will
+ * then exit afterwards.
+ */
+ function my_csrf_callback() {
+ echo "You're doing bad things young man!";
+ }
+
+ function csrf_startup() {
+
+ // While csrf-magic has a handy little heuristic for determining whether
+ // or not the content in the buffer is HTML or not, you should really
+ // give it a nudge and turn rewriting *off* when the content is
+ // not HTML. Implementation details will vary.
+ if (isset($_POST['ajax'])) csrf_conf('rewrite', false);
+
+ // This is a secret value that must be set in order to enable username
+ // and IP based checks. Don't show this to anyone. A secret id will
+ // automatically be generated for you if the directory csrf-magic.php
+ // is placed in is writable.
+ csrf_conf('secret', 'ABCDEFG123456');
+
+ // This enables JavaScript rewriting and will ensure your AJAX calls
+ // don't stop working.
+ csrf_conf('rewrite-js', '/csrf-magic.js');
+
+ // This makes csrf-magic call my_csrf_callback() before exiting when
+ // there is a bad csrf token. This lets me customize the error page.
+ csrf_conf('callback', 'my_csrf_callback');
+
+ // While this is enabled by default to boost backwards compatibility,
+ // for security purposes it should ideally be off. Some users can be
+ // NATted or have dialup addresses which rotate frequently. Cookies
+ // are much more reliable.
+ csrf_conf('allow-ip', false);
+
+ }
+
+ // Finally, include the library
+ include_once '/path/to/csrf-magic.php';
+
+Configuration gets stored in the $GLOBALS['csrf'] array.
+
+
+4. THANKS
+
+My thanks to Chris Shiflett, for unintentionally inspiring the idea, as well
+as telling me the original variant of the Bob and Mallory story,
+and the Django CSRF Middleware authors, who thought up of this before me.
+Gareth Heyes suggested using the frame-breaker option to protect against
+CSS overlay attacks.
diff --git a/web/includes/csrf/csrf-magic.js b/web/includes/csrf/csrf-magic.js
new file mode 100644
index 000000000..0989c1065
--- /dev/null
+++ b/web/includes/csrf/csrf-magic.js
@@ -0,0 +1,191 @@
+/**
+ * @file
+ *
+ * Rewrites XMLHttpRequest to automatically send CSRF token with it. In theory
+ * plays nice with other JavaScript libraries, needs testing though.
+ */
+
+// Here are the basic overloaded method definitions
+// The wrapper must be set BEFORE onreadystatechange is written to, since
+// a bug in ActiveXObject prevents us from properly testing for it.
+CsrfMagic = function(real) {
+ // try to make it ourselves, if you didn't pass it
+ if (!real) try { real = new XMLHttpRequest; } catch (e) {;}
+ if (!real) try { real = new ActiveXObject('Msxml2.XMLHTTP'); } catch (e) {;}
+ if (!real) try { real = new ActiveXObject('Microsoft.XMLHTTP'); } catch (e) {;}
+ if (!real) try { real = new ActiveXObject('Msxml2.XMLHTTP.4.0'); } catch (e) {;}
+ this.csrf = real;
+ // properties
+ var csrfMagic = this;
+ real.onreadystatechange = function() {
+ csrfMagic._updateProps();
+ return csrfMagic.onreadystatechange ? csrfMagic.onreadystatechange() : null;
+ };
+ csrfMagic._updateProps();
+}
+
+CsrfMagic.prototype = {
+
+ open: function(method, url, async, username, password) {
+ if (method == 'POST') this.csrf_isPost = true;
+ // deal with Opera bug, thanks jQuery
+ if (username) return this.csrf_open(method, url, async, username, password);
+ else return this.csrf_open(method, url, async);
+ },
+ csrf_open: function(method, url, async, username, password) {
+ if (username) return this.csrf.open(method, url, async, username, password);
+ else return this.csrf.open(method, url, async);
+ },
+
+ send: function(data) {
+ if (!this.csrf_isPost) return this.csrf_send(data);
+ prepend = csrfMagicName + '=' + csrfMagicToken + '&';
+ // XXX: Removed to eliminate 'Refused to set unsafe header "Content-length" ' errors in modern browsers
+ // if (this.csrf_purportedLength === undefined) {
+ // this.csrf_setRequestHeader("Content-length", this.csrf_purportedLength + prepend.length);
+ // delete this.csrf_purportedLength;
+ // }
+ delete this.csrf_isPost;
+ return this.csrf_send(prepend + data);
+ },
+ csrf_send: function(data) {
+ return this.csrf.send(data);
+ },
+
+ setRequestHeader: function(header, value) {
+ // We have to auto-set this at the end, since we don't know how long the
+ // nonce is when added to the data.
+ if (this.csrf_isPost && header == "Content-length") {
+ this.csrf_purportedLength = value;
+ return;
+ }
+ return this.csrf_setRequestHeader(header, value);
+ },
+ csrf_setRequestHeader: function(header, value) {
+ return this.csrf.setRequestHeader(header, value);
+ },
+
+ abort: function() {
+ return this.csrf.abort();
+ },
+ getAllResponseHeaders: function() {
+ return this.csrf.getAllResponseHeaders();
+ },
+ getResponseHeader: function(header) {
+ return this.csrf.getResponseHeader(header);
+ } // ,
+}
+
+// proprietary
+CsrfMagic.prototype._updateProps = function() {
+ this.readyState = this.csrf.readyState;
+ if (this.readyState == 4) {
+ this.responseText = this.csrf.responseText;
+ this.responseXML = this.csrf.responseXML;
+ this.status = this.csrf.status;
+ this.statusText = this.csrf.statusText;
+ }
+}
+CsrfMagic.process = function(base) {
+ if(typeof base == 'object') {
+ base[csrfMagicName] = csrfMagicToken;
+ return base;
+ }
+ var prepend = csrfMagicName + '=' + csrfMagicToken;
+ if (base) return prepend + '&' + base;
+ return prepend;
+}
+// callback function for when everything on the page has loaded
+CsrfMagic.end = function() {
+ // This rewrites forms AGAIN, so in case buffering didn't work this
+ // certainly will.
+ forms = document.getElementsByTagName('form');
+ for (var i = 0; i < forms.length; i++) {
+ form = forms[i];
+ if (form.method.toUpperCase() !== 'POST') continue;
+ if (form.elements[csrfMagicName]) continue;
+ var input = document.createElement('input');
+ input.setAttribute('name', csrfMagicName);
+ input.setAttribute('value', csrfMagicToken);
+ input.setAttribute('type', 'hidden');
+ form.appendChild(input);
+ }
+}
+
+// Sets things up for Mozilla/Opera/nice browsers
+// We very specifically match against Internet Explorer, since they haven't
+// implemented prototypes correctly yet.
+if (window.XMLHttpRequest && window.XMLHttpRequest.prototype && '\v' != 'v') {
+ var x = XMLHttpRequest.prototype;
+ var c = CsrfMagic.prototype;
+
+ // Save the original functions
+ x.csrf_open = x.open;
+ x.csrf_send = x.send;
+ x.csrf_setRequestHeader = x.setRequestHeader;
+
+ // Notice that CsrfMagic is itself an instantiatable object, but only
+ // open, send and setRequestHeader are necessary as decorators.
+ x.open = c.open;
+ x.send = c.send;
+ x.setRequestHeader = c.setRequestHeader;
+} else {
+ // The only way we can do this is by modifying a library you have been
+ // using. We support YUI, script.aculo.us, prototype, MooTools,
+ // jQuery, Ext and Dojo.
+ if (window.jQuery) {
+ // jQuery didn't implement a new XMLHttpRequest function, so we have
+ // to do this the hard way.
+ jQuery.csrf_ajax = jQuery.ajax;
+ jQuery.ajax = function( s ) {
+ if (s.type && s.type.toUpperCase() == 'POST') {
+ s = jQuery.extend(true, s, jQuery.extend(true, {}, jQuery.ajaxSettings, s));
+ if ( s.data && s.processData && typeof s.data != "string" ) {
+ s.data = jQuery.param(s.data);
+ }
+ s.data = CsrfMagic.process(s.data);
+ }
+ return jQuery.csrf_ajax( s );
+ }
+ }
+ if (window.Prototype) {
+ // This works for script.aculo.us too
+ Ajax.csrf_getTransport = Ajax.getTransport;
+ Ajax.getTransport = function() {
+ return new CsrfMagic(Ajax.csrf_getTransport());
+ }
+ }
+ if (window.MooTools) {
+ Browser.csrf_Request = Browser.Request;
+ Browser.Request = function () {
+ return new CsrfMagic(Browser.csrf_Request());
+ }
+ }
+ if (window.YAHOO) {
+ // old YUI API
+ YAHOO.util.Connect.csrf_createXhrObject = YAHOO.util.Connect.createXhrObject;
+ YAHOO.util.Connect.createXhrObject = function (transaction) {
+ obj = YAHOO.util.Connect.csrf_createXhrObject(transaction);
+ obj.conn = new CsrfMagic(obj.conn);
+ return obj;
+ }
+ }
+ if (window.Ext) {
+ // Ext can use other js libraries as loaders, so it has to come last
+ // Ext's implementation is pretty identical to Yahoo's, but we duplicate
+ // it for comprehensiveness's sake.
+ Ext.lib.Ajax.csrf_createXhrObject = Ext.lib.Ajax.createXhrObject;
+ Ext.lib.Ajax.createXhrObject = function (transaction) {
+ obj = Ext.lib.Ajax.csrf_createXhrObject(transaction);
+ obj.conn = new CsrfMagic(obj.conn);
+ return obj;
+ }
+ }
+ if (window.dojo) {
+ // NOTE: this doesn't work with latest dojo
+ dojo.csrf__xhrObj = dojo._xhrObj;
+ dojo._xhrObj = function () {
+ return new CsrfMagic(dojo.csrf__xhrObj());
+ }
+ }
+}
diff --git a/web/includes/csrf/csrf-magic.php b/web/includes/csrf/csrf-magic.php
new file mode 100644
index 000000000..153417f4e
--- /dev/null
+++ b/web/includes/csrf/csrf-magic.php
@@ -0,0 +1,405 @@
+
+ */
+$GLOBALS['csrf']['input-name'] = '__csrf_magic';
+
+/**
+ * Set this to false if your site must work inside of frame/iframe elements,
+ * but do so at your own risk: this configuration protects you against CSS
+ * overlay attacks that defeat tokens.
+ */
+$GLOBALS['csrf']['frame-breaker'] = true;
+
+/**
+ * Whether or not CSRF Magic should be allowed to start a new session in order
+ * to determine the key.
+ */
+$GLOBALS['csrf']['auto-session'] = true;
+
+/**
+ * Whether or not csrf-magic should produce XHTML style tags.
+ */
+$GLOBALS['csrf']['xhtml'] = true;
+
+// FUNCTIONS:
+
+// Don't edit this!
+$GLOBALS['csrf']['version'] = '1.0.4';
+
+/**
+ * Rewrites
+ CSRF check failed. Your form session may have expired, or you may not have
+ cookies enabled.
+
+ Debug: $tokens
', $script . '', $buffer, $count);
+ if (!$count) {
+ $buffer .= $script;
+ }
+ }
+ return $buffer;
+}
+
+/**
+ * Checks if this is a post request, and if it is, checks if the nonce is valid.
+ * @param bool $fatal Whether or not to fatally error out if there is a problem.
+ * @return True if check passes or is not necessary, false if failure.
+ */
+function csrf_check($fatal = true) {
+ if ($_SERVER['REQUEST_METHOD'] !== 'POST') return true;
+ csrf_start();
+ $name = $GLOBALS['csrf']['input-name'];
+ $ok = false;
+ $tokens = '';
+ do {
+ if (!isset($_POST[$name])) break;
+ // we don't regenerate a token and check it because some token creation
+ // schemes are volatile.
+ $tokens = $_POST[$name];
+ if (!csrf_check_tokens($tokens)) break;
+ $ok = true;
+ } while (false);
+ if ($fatal && !$ok) {
+ $callback = $GLOBALS['csrf']['callback'];
+ if (trim($tokens, 'A..Za..z0..9:;,') !== '') $tokens = 'hidden';
+ $callback($tokens);
+ exit;
+ }
+ return $ok;
+}
+
+/**
+ * Retrieves a valid token(s) for a particular context. Tokens are separated
+ * by semicolons.
+ */
+function csrf_get_tokens() {
+ $has_cookies = !empty($_COOKIE);
+
+ // $ip implements a composite key, which is sent if the user hasn't sent
+ // any cookies. It may or may not be used, depending on whether or not
+ // the cookies "stick"
+ $secret = csrf_get_secret();
+ if (!$has_cookies && $secret) {
+ // :TODO: Harden this against proxy-spoofing attacks
+ $IP_ADDRESS = (isset($_SERVER['IP_ADDRESS']) ? $_SERVER['IP_ADDRESS'] : $_SERVER['REMOTE_ADDR']);
+ $ip = ';ip:' . csrf_hash($IP_ADDRESS);
+ } else {
+ $ip = '';
+ }
+ csrf_start();
+
+ // These are "strong" algorithms that don't require per se a secret
+ if (session_id()) return 'sid:' . csrf_hash(session_id()) . $ip;
+ if ($GLOBALS['csrf']['cookie']) {
+ $val = csrf_generate_secret();
+ setcookie($GLOBALS['csrf']['cookie'], $val);
+ return 'cookie:' . csrf_hash($val) . $ip;
+ }
+ if ($GLOBALS['csrf']['key']) return 'key:' . csrf_hash($GLOBALS['csrf']['key']) . $ip;
+ // These further algorithms require a server-side secret
+ if (!$secret) return 'invalid';
+ if ($GLOBALS['csrf']['user'] !== false) {
+ return 'user:' . csrf_hash($GLOBALS['csrf']['user']);
+ }
+ if ($GLOBALS['csrf']['allow-ip']) {
+ return ltrim($ip, ';');
+ }
+ return 'invalid';
+}
+
+function csrf_flattenpost($data) {
+ $ret = array();
+ foreach($data as $n => $v) {
+ $ret = array_merge($ret, csrf_flattenpost2(1, $n, $v));
+ }
+ return $ret;
+}
+function csrf_flattenpost2($level, $key, $data) {
+ if(!is_array($data)) return array($key => $data);
+ $ret = array();
+ foreach($data as $n => $v) {
+ $nk = $level >= 1 ? $key."[$n]" : "[$n]";
+ $ret = array_merge($ret, csrf_flattenpost2($level+1, $nk, $v));
+ }
+ return $ret;
+}
+
+/**
+ * @param $tokens is safe for HTML consumption
+ */
+function csrf_callback($tokens) {
+ // (yes, $tokens is safe to echo without escaping)
+ header($_SERVER['SERVER_PROTOCOL'] . ' 403 Forbidden');
+ $data = '';
+ foreach (csrf_flattenpost($_POST) as $key => $value) {
+ if ($key == $GLOBALS['csrf']['input-name']) continue;
+ $data .= '';
+ }
+ echo "