ZaneYork
/
zoneminder
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow empty sort field.

This commit is contained in:
Isaac Connor 2021-12-13 15:00:35 -05:00
parent e2df6e5074
commit 6511dc8a4f
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
web/ajax/events.php
View File

@ -48,7 +48,7 @@ if (isset($_REQUEST['order'])) {
} else if (strtolower($_REQUEST['order']) == 'desc') { } else if (strtolower($_REQUEST['order']) == 'desc') {
$order = 'DESC'; $order = 'DESC';
} else { } else {
Warning("Invalid value for order " . $_REQUEST['order']); Warning('Invalid value for order ' . $_REQUEST['order']);
} }
} }
@ -170,18 +170,23 @@ function queryRequest($filter, $search, $advsearch, $sort, $offset, $order, $lim
// The names of columns shown in the event view that are NOT dB columns in the database // The names of columns shown in the event view that are NOT dB columns in the database
$col_alt = array('Monitor', 'Storage'); $col_alt = array('Monitor', 'Storage');
if (!in_array($sort, array_merge($columns, $col_alt))) { if ( $sort != '' ) {
ZM\Error('Invalid sort field: ' . $sort); if (!in_array($sort, array_merge($columns, $col_alt))) {
$sort = 'Id'; ZM\Error('Invalid sort field: ' . $sort);
$sort = '';
} else if ( $sort == 'Monitor' ) {
$sort = 'M.Name';
} else {
$sort = 'E.'.$sort;
}
} }
$values = array(); $values = array();
$likes = array(); $likes = array();
$where = $filter->sql()?' WHERE ('.$filter->sql().')' : ''; $where = $filter->sql()?' WHERE ('.$filter->sql().')' : '';
$sort = $sort == 'Monitor' ? 'M.Name' : 'E.'.$sort;
$col_str = 'E.*, M.Name AS Monitor'; $col_str = 'E.*, M.Name AS Monitor';
$sql = 'SELECT ' .$col_str. ' FROM `Events` AS E INNER JOIN Monitors AS M ON E.MonitorId = M.Id'.$where.' ORDER BY '.$sort.' '.$order; $sql = 'SELECT ' .$col_str. ' FROM `Events` AS E INNER JOIN Monitors AS M ON E.MonitorId = M.Id'.$where.($sort?' ORDER BY '.$sort.' '.$order:'');
$storage_areas = ZM\Storage::find(); $storage_areas = ZM\Storage::find();
$StorageById = array(); $StorageById = array();