From df0aef89affbc8a0cb6e31bf5395a3f03892f255 Mon Sep 17 00:00:00 2001
From: Isaac Connor <isaac@zoneminder.com>
Date: Tue, 23 Jul 2019 10:03:28 -0400
Subject: [PATCH] gracefully handle when window[fnName] doesn't exist

---
 web/skins/classic/js/skin.js | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/web/skins/classic/js/skin.js b/web/skins/classic/js/skin.js
index d39062087..c29ef4a84 100644
--- a/web/skins/classic/js/skin.js
+++ b/web/skins/classic/js/skin.js
@@ -144,7 +144,7 @@ window.addEventListener("DOMContentLoaded", function onSkinDCL() {
     el.addEventListener("click", function onClick(evt) {
       var el = this;
       var url;
-      if (el.hasAttribute("href")) {
+      if ( el.hasAttribute("href") ) {
         // <a>
         url = el.getAttribute("href");
       } else {
@@ -167,12 +167,20 @@ window.addEventListener("DOMContentLoaded", function onSkinDCL() {
   // 'data-on-click-this' calls the global function in the attribute value with the element when a click happens.
   document.querySelectorAll("a[data-on-click-this], button[data-on-click-this], input[data-on-click-this]").forEach(function attachOnClick(el) {
     var fnName = el.getAttribute("data-on-click-this");
+    if ( !window[fnName] ) {
+      console.error("Nothing found to bind to " + fnName);
+      return;
+    }
     el.onclick = window[fnName].bind(el, el);
   });
 
   // 'data-on-click' calls the global function in the attribute value with no arguments when a click happens.
   document.querySelectorAll("a[data-on-click], button[data-on-click], input[data-on-click]").forEach(function attachOnClick(el) {
     var fnName = el.getAttribute("data-on-click");
+    if ( !window[fnName] ) {
+      console.error("Nothing found to bind to " + fnName);
+      return;
+    }
     el.onclick = function() {
       window[fnName]();
     };
@@ -181,6 +189,10 @@ window.addEventListener("DOMContentLoaded", function onSkinDCL() {
   // 'data-on-click-true' calls the global function in the attribute value with no arguments when a click happens.
   document.querySelectorAll("a[data-on-click-true], button[data-on-click-true], input[data-on-click-true]").forEach(function attachOnClick(el) {
     var fnName = el.getAttribute("data-on-click-true");
+    if ( !window[fnName] ) {
+      console.error("Nothing found to bind to " + fnName);
+      return;
+    }
     el.onclick = function() {
       window[fnName](true);
     };
@@ -189,12 +201,20 @@ window.addEventListener("DOMContentLoaded", function onSkinDCL() {
   // 'data-on-change-this' calls the global function in the attribute value with the element when a change happens.
   document.querySelectorAll("select[data-on-change-this], input[data-on-change-this]").forEach(function attachOnChangeThis(el) {
     var fnName = el.getAttribute("data-on-change-this");
+    if ( !window[fnName] ) {
+      console.error("Nothing found to bind to " + fnName);
+      return;
+    }
     el.onchange = window[fnName].bind(el, el);
   });
 
   // 'data-on-change' adds an event listener for the global function in the attribute value when a change happens.
   document.querySelectorAll("select[data-on-change], input[data-on-change]").forEach(function attachOnChange(el) {
     var fnName = el.getAttribute("data-on-change");
+    if ( !window[fnName] ) {
+      console.error("Nothing found to bind to " + fnName);
+      return;
+    }
     el.onchange = window[fnName];
   });
 });