From d76e9e5f5d81ef34ad41ea171a19ee32027cf3bd Mon Sep 17 00:00:00 2001 From: Kyle Johnson Date: Sat, 13 Dec 2014 23:15:31 -0500 Subject: [PATCH] Initial work on cleaning up monitor view. Starting by splitting each 'tab' out into their own php file, and then including it. Easier to manage. Following up by removing tables and replacing with a responsive form layout. Also working on removing PHP dependencies and using the UI instead. --- web/skins/bootstrap/views/monitor.php | 479 +----------------- .../bootstrap/views/tab-monitor-buffers.php | 26 + .../bootstrap/views/tab-monitor-control.php | 21 + .../bootstrap/views/tab-monitor-general.php | 65 +++ .../bootstrap/views/tab-monitor-misc.php | 84 +++ .../bootstrap/views/tab-monitor-source.php | 101 ++++ .../bootstrap/views/tab-monitor-timestamp.php | 14 + web/skins/bootstrap/views/tab-monitor-x10.php | 8 + 8 files changed, 340 insertions(+), 458 deletions(-) create mode 100644 web/skins/bootstrap/views/tab-monitor-buffers.php create mode 100644 web/skins/bootstrap/views/tab-monitor-control.php create mode 100644 web/skins/bootstrap/views/tab-monitor-general.php create mode 100644 web/skins/bootstrap/views/tab-monitor-misc.php create mode 100644 web/skins/bootstrap/views/tab-monitor-source.php create mode 100644 web/skins/bootstrap/views/tab-monitor-timestamp.php create mode 100644 web/skins/bootstrap/views/tab-monitor-x10.php diff --git a/web/skins/bootstrap/views/monitor.php b/web/skins/bootstrap/views/monitor.php index 8a35d3b7b..cb63c8966 100644 --- a/web/skins/bootstrap/views/monitor.php +++ b/web/skins/bootstrap/views/monitor.php @@ -421,468 +421,31 @@ xhtmlHeaders(__FILE__, $SLANG['Monitor']." - ".validHtmlStr($monitor['Name']) ); -
- -
-
    -$value ) -{ - if ( $tab == $name ) - { -?> -
  • - -
  • - -
-
-
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - $SLANG['None'], - '0' => $SLANG['Home'], - '1' => $SLANG['Preset']." 1", - ); -?> - - - - - - - - - - - - - - - - - - - - - - -
checked="checked"/>
- -
-"; -?> - checked="checked"/>  - - - -
- /> - - /> - - /> - -
 ()
()
()
checked="checked"/>
 
checked="checked"/>
    
    
-
- disabled="disabled"/> -
-
-
-
+
+ +
+ + +
+ + + + + +
+
+ +
diff --git a/web/skins/bootstrap/views/tab-monitor-buffers.php b/web/skins/bootstrap/views/tab-monitor-buffers.php new file mode 100644 index 000000000..eb72ae8d5 --- /dev/null +++ b/web/skins/bootstrap/views/tab-monitor-buffers.php @@ -0,0 +1,26 @@ +
+
+ + +
+
+ + +
+
+ + +
+
+ + +
+
+ + +
+
+ + +
+
diff --git a/web/skins/bootstrap/views/tab-monitor-control.php b/web/skins/bootstrap/views/tab-monitor-control.php new file mode 100644 index 000000000..c392dd41a --- /dev/null +++ b/web/skins/bootstrap/views/tab-monitor-control.php @@ -0,0 +1,21 @@ +
+ + + checked="checked"/> +   + + + + checked="checked"/> + $SLANG['None'], + '0' => $SLANG['Home'], + '1' => $SLANG['Preset']." 1", + ); +?> + + + + +
diff --git a/web/skins/bootstrap/views/tab-monitor-general.php b/web/skins/bootstrap/views/tab-monitor-general.php new file mode 100644 index 000000000..1f7dc4825 --- /dev/null +++ b/web/skins/bootstrap/views/tab-monitor-general.php @@ -0,0 +1,65 @@ +
+ +
+ + +
+
+ + +
+
+ + +
+
+ +
+
+ + +
+
+ + +
+ +
+ +
+
+
+ +
+ + +
+
+ +
+ +
diff --git a/web/skins/bootstrap/views/tab-monitor-misc.php b/web/skins/bootstrap/views/tab-monitor-misc.php new file mode 100644 index 000000000..258c5f2d2 --- /dev/null +++ b/web/skins/bootstrap/views/tab-monitor-misc.php @@ -0,0 +1,84 @@ +
+ + + + + + + + + + + +      + +      + + + + + + + + + + +"; +?> + checked="checked"/>  + + + + + +
diff --git a/web/skins/bootstrap/views/tab-monitor-source.php b/web/skins/bootstrap/views/tab-monitor-source.php new file mode 100644 index 000000000..3913b96fc --- /dev/null +++ b/web/skins/bootstrap/views/tab-monitor-source.php @@ -0,0 +1,101 @@ +
+ + + + + + + + + + + + + + + /> + + /> + + /> + + + + + + + + + + + + + + + + + + + + + + +  () + + + () + () + + + + + + + +
diff --git a/web/skins/bootstrap/views/tab-monitor-timestamp.php b/web/skins/bootstrap/views/tab-monitor-timestamp.php new file mode 100644 index 000000000..9b76a4f80 --- /dev/null +++ b/web/skins/bootstrap/views/tab-monitor-timestamp.php @@ -0,0 +1,14 @@ +
+
+ + +
+
+ + +
+
+ + +
+
diff --git a/web/skins/bootstrap/views/tab-monitor-x10.php b/web/skins/bootstrap/views/tab-monitor-x10.php new file mode 100644 index 000000000..8d633bd20 --- /dev/null +++ b/web/skins/bootstrap/views/tab-monitor-x10.php @@ -0,0 +1,8 @@ +
+ + + + + + +